[8.10] [Profiling] removing ~ symbol (#164595) (#164680)

# Backport This will backport the following commits from `main` to `8.10`: - [[Profiling] removing ~ symbol (#164595)](#164595)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Cauê Marcondes <[email protected]>
elastic · Aug 24, 2023 · 9f91b8d · 9f91b8d
1 parent b8f9d4a
commit 9f91b8d
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 21 deletions.
diff --git a/x-pack/plugins/profiling/public/components/flamegraph/flamegraph_tooltip.tsx b/x-pack/plugins/profiling/public/components/flamegraph/flamegraph_tooltip.tsx
@@ -38,7 +38,6 @@ interface Props {
   comparisonCountExclusive?: number;
   comparisonTotalSamples?: number;
   comparisonTotalSeconds?: number;
-  samplingRate?: number;
   onShowMoreClick?: () => void;
 }
 
@@ -55,7 +54,6 @@ export function FlameGraphTooltip({
   comparisonCountExclusive,
   comparisonTotalSamples,
   comparisonTotalSeconds,
-  samplingRate,
   onShowMoreClick,
 }: Props) {
   const theme = useEuiTheme();
@@ -80,8 +78,6 @@ export function FlameGraphTooltip({
         })
       : undefined;
 
-  const prependString = samplingRate === 1.0 ? ' ' : '~';
-
   return (
     <TooltipContainer>
       <EuiPanel paddingSize="s">
@@ -104,7 +100,6 @@ export function FlameGraphTooltip({
                 formatValue={asPercentage}
                 showDifference
                 formatDifferenceAsPercentage
-                prependValue={prependString}
               />
               <TooltipRow
                 label={
@@ -120,7 +115,6 @@ export function FlameGraphTooltip({
                 showDifference
                 formatDifferenceAsPercentage
                 formatValue={asPercentage}
-                prependValue={prependString}
               />
             </>
           )}
@@ -138,7 +132,6 @@ export function FlameGraphTooltip({
             }
             showDifference
             formatDifferenceAsPercentage={false}
-            prependValue={prependString}
           />
           <TooltipRow
             label={i18n.translate('xpack.profiling.flameGraphTooltip.annualizedCo2', {
@@ -149,7 +142,6 @@ export function FlameGraphTooltip({
             formatValue={asWeight}
             showDifference
             formatDifferenceAsPercentage={false}
-            prependValue={prependString}
           />
           <TooltipRow
             label={i18n.translate('xpack.profiling.flameGraphTooltip.annualizedDollarCost', {
@@ -160,7 +152,6 @@ export function FlameGraphTooltip({
             formatValue={asCost}
             showDifference
             formatDifferenceAsPercentage={false}
-            prependValue={prependString}
           />
           {onShowMoreClick && (
             <>

diff --git a/x-pack/plugins/profiling/public/components/flamegraph/index.tsx b/x-pack/plugins/profiling/public/components/flamegraph/index.tsx
@@ -194,7 +194,6 @@ export function FlameGraph({
           frame={selected}
           totalSeconds={primaryFlamegraph?.TotalSeconds ?? 0}
           totalSamples={totalSamples}
-          samplingRate={primaryFlamegraph?.SamplingRate ?? 1.0}
         />
       )}
     </>

diff --git a/x-pack/plugins/profiling/public/components/frame_information_window/get_impact_rows.tsx b/x-pack/plugins/profiling/public/components/frame_information_window/get_impact_rows.tsx
@@ -20,13 +20,11 @@ export function getImpactRows({
   countExclusive,
   totalSamples,
   totalSeconds,
-  isApproximate = false,
 }: {
   countInclusive: number;
   countExclusive: number;
   totalSamples: number;
   totalSeconds: number;
-  isApproximate: boolean;
 }) {
   const { selfCPU, totalCPU } = calculateImpactEstimates({
     countInclusive,

diff --git a/x-pack/plugins/profiling/public/components/frame_information_window/index.tsx b/x-pack/plugins/profiling/public/components/frame_information_window/index.tsx
@@ -34,10 +34,9 @@ export interface Props {
   };
   totalSamples: number;
   totalSeconds: number;
-  samplingRate: number;
 }
 
-export function FrameInformationWindow({ frame, totalSamples, totalSeconds, samplingRate }: Props) {
+export function FrameInformationWindow({ frame, totalSamples, totalSeconds }: Props) {
   const aiAssistant = useObservabilityAIAssistant();
 
   const promptMessages = useMemo<Message[] | undefined>(() => {
@@ -155,16 +154,11 @@ export function FrameInformationWindow({ frame, totalSamples, totalSeconds, samp
     sourceLine,
   });
 
-  // Are the results sampled? If yes, prepend a '~'.
-  const isApproximate = (samplingRate ?? 1.0) === 1.0;
-  const prependString = isApproximate ? undefined : '~';
-
   const impactRows = getImpactRows({
     countInclusive,
     countExclusive,
     totalSamples,
     totalSeconds,
-    isApproximate,
   });
 
   return (
@@ -202,7 +196,7 @@ export function FrameInformationWindow({ frame, totalSamples, totalSeconds, samp
               </EuiTitle>
             </EuiFlexItem>
             <EuiFlexItem>
-              <KeyValueList rows={impactRows} prependString={prependString} />
+              <KeyValueList rows={impactRows} />
             </EuiFlexItem>
           </EuiFlexGroup>
         </EuiFlexItem>

diff --git a/x-pack/plugins/profiling/public/components/topn_functions/index.tsx b/x-pack/plugins/profiling/public/components/topn_functions/index.tsx
@@ -331,7 +331,6 @@ export const TopNFunctionsGrid = forwardRef(
             }}
             totalSeconds={totalSeconds}
             totalSamples={totalCount}
-            samplingRate={topNFunctions?.SamplingRate ?? 1.0}
           />
         )}
       </>
-Original file line number
+Diff line change
@@ Expand Up / @@ -331,7 +331,6 @@ export const TopNFunctionsGrid = forwardRef( @@
                 }}
                 totalSeconds={totalSeconds}
                 totalSamples={totalCount}
-                samplingRate={topNFunctions?.SamplingRate ?? 1.0}
               />
             )}
           </>
@@ Expand Down @@