[Security Solution][Endpoint] Fix server start to ensure it does not …

…prevent Kibana from starting if optional plugin dependencies are not available (#88291)

* Ensure that services that depend on fleet are only initialized if fleet dependency is available
* rename "Ingest manager" to "Fleet" in UI strings/code comments

x-pack/plugins/security_solution/public/app/home/setup.tsx

@@ -14,7 +14,7 @@ export const Setup: React.FunctionComponent<{
 }> = ({ fleet, notifications }) => {
   React.useEffect(() => {
     const defaultText = i18n.translate('xpack.securitySolution.endpoint.ingestToastMessage', {
-      defaultMessage: 'Ingest Manager failed during its setup.',
+      defaultMessage: 'Fleet failed during its setup.',
     });
 
     const title = i18n.translate('xpack.securitySolution.endpoint.ingestToastTitle', {

x-pack/plugins/security_solution/public/management/pages/index.tsx

@@ -74,7 +74,7 @@ const NoPermissions = memo(() => {
           <EuiText color="subdued">
             <FormattedMessage
               id="xpack.securitySolution.endpointManagement.noPermissionsSubText"
-              defaultMessage="It looks like Ingest Manager is disabled. Ingest Manager must be enabled to use this feature. If you do not have permissions to enable Ingest Manager, contact your Kibana administrator."
+              defaultMessage="It looks like Fleet is disabled. Fleet must be enabled to use this feature. If you do not have permissions to enable Fleet, contact your Kibana administrator."
             />
           </EuiText>
         }

x-pack/plugins/security_solution/server/endpoint/ingest_integration.ts

@@ -76,7 +76,7 @@ const getManifest = async (logger: Logger, manifestManager: ManifestManager): Pr
 };
 
 /**
- * Callback to handle creation of PackagePolicies in Ingest Manager
+ * Callback to handle creation of PackagePolicies in Fleet
  */
 export const getPackagePolicyCreateCallback = (
   logger: Logger,

x-pack/plugins/security_solution/server/endpoint/mocks.ts

@@ -93,7 +93,7 @@ export const createMockPackageService = (): jest.Mocked<PackageService> => {
 };
 
 /**
- * Creates a mock IndexPatternService for use in tests that need to interact with the Ingest Manager's
+ * Creates a mock IndexPatternService for use in tests that need to interact with the Fleet's
  * ESIndexPatternService.
  *
  * @param indexPattern a string index pattern to return when called by a test

x-pack/plugins/security_solution/server/plugin.ts

@@ -34,7 +34,7 @@ import { ListPluginSetup } from '../../lists/server';
 import { EncryptedSavedObjectsPluginSetup as EncryptedSavedObjectsSetup } from '../../encrypted_saved_objects/server';
 import { SpacesPluginSetup as SpacesSetup } from '../../spaces/server';
 import { ILicense, LicensingPluginStart } from '../../licensing/server';
-import { FleetStartContract, ExternalCallback } from '../../fleet/server';
+import { FleetStartContract } from '../../fleet/server';
 import { TaskManagerSetupContract, TaskManagerStartContract } from '../../task_manager/server';
 import { initServer } from './init_server';
 import { compose } from './lib/compose/kibana';
@@ -323,27 +323,41 @@ export class Plugin implements IPlugin<PluginSetup, PluginStart, SetupPlugins, S
 
   public start(core: CoreStart, plugins: StartPlugins) {
     const savedObjectsClient = new SavedObjectsClient(core.savedObjects.createInternalRepository());
-
+    const registerIngestCallback = plugins.fleet?.registerExternalCallback;
     let manifestManager: ManifestManager | undefined;
-    let registerIngestCallback: ((...args: ExternalCallback) => void) | undefined;
 
-    const exceptionListsStartEnabled = () => {
-      return this.lists && plugins.taskManager && plugins.fleet;
-    };
+    this.licensing$ = plugins.licensing.license$;
 
-    if (exceptionListsStartEnabled()) {
-      const exceptionListClient = this.lists!.getExceptionListClient(savedObjectsClient, 'kibana');
+    if (this.lists && plugins.taskManager && plugins.fleet) {
+      // Exceptions, Artifacts and Manifests start
+      const exceptionListClient = this.lists.getExceptionListClient(savedObjectsClient, 'kibana');
       const artifactClient = new ArtifactClient(savedObjectsClient);
 
-      registerIngestCallback = plugins.fleet!.registerExternalCallback;
       manifestManager = new ManifestManager({
         savedObjectsClient,
         artifactClient,
         exceptionListClient,
-        packagePolicyService: plugins.fleet!.packagePolicyService,
+        packagePolicyService: plugins.fleet.packagePolicyService,
         logger: this.logger,
         cache: this.exceptionsCache,
       });
+
+      if (this.manifestTask) {
+        this.manifestTask.start({
+          taskManager: plugins.taskManager,
+        });
+      } else {
+        this.logger.debug('User artifacts task not available.');
+      }
+
+      // License related start
+      licenseService.start(this.licensing$);
+      this.policyWatcher = new PolicyWatcher(
+        plugins.fleet!.packagePolicyService,
+        core.savedObjects,
+        this.logger
+      );
+      this.policyWatcher.start(licenseService);
     }
 
     this.endpointAppContextService.start({
@@ -362,23 +376,7 @@ export class Plugin implements IPlugin<PluginSetup, PluginStart, SetupPlugins, S
       licenseService,
     });
 
-    if (exceptionListsStartEnabled() && this.manifestTask) {
-      this.manifestTask.start({
-        taskManager: plugins.taskManager!,
-      });
-    } else {
-      this.logger.debug('User artifacts task not available.');
-    }
-
     this.telemetryEventsSender.start(core, plugins.telemetry, plugins.taskManager);
-    this.licensing$ = plugins.licensing.license$;
-    licenseService.start(this.licensing$);
-    this.policyWatcher = new PolicyWatcher(
-      plugins.fleet!.packagePolicyService,
-      core.savedObjects,
-      this.logger
-    );
-    this.policyWatcher.start(licenseService);
     return {};
   }