fix: docs feedback

elastic · Dec 13, 2023 · 9e951fe · 9e951fe
1 parent 8d41f05
commit 9e951fe
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 18 deletions.
diff --git a/...plugins/security_solution/public/timelines/components/timeline/properties/translations.ts b/...plugins/security_solution/public/timelines/components/timeline/properties/translations.ts
@@ -56,14 +56,14 @@ export const NOTES = i18n.translate('xpack.securitySolution.timeline.properties.
 export const NEW_TIMELINE = i18n.translate(
   'xpack.securitySolution.timeline.properties.newTimelineButtonLabel',
   {
-    defaultMessage: 'Create new timeline',
+    defaultMessage: 'Create new Timeline',
   }
 );
 
 export const NEW_TEMPLATE_TIMELINE = i18n.translate(
   'xpack.securitySolution.timeline.properties.newTemplateTimelineButtonLabel',
   {
-    defaultMessage: 'Create new timeline template',
+    defaultMessage: 'Create new Timeline template',
   }
 );
 

diff --git a/x-pack/plugins/security_solution/public/timelines/components/timeline/tour/step_config.tsx b/x-pack/plugins/security_solution/public/timelines/components/timeline/tour/step_config.tsx
@@ -26,7 +26,7 @@ export const timelineTourSteps = [
       <EuiText>
         <FormattedMessage
           id="xpack.securitySolution.timeline.tour.newTimeline.description"
-          defaultMessage="Click {newButton} to create a new timeline. Click {openButton} to open an existing one"
+          defaultMessage="Click {newButton} to create a new timeline. Click {openButton} to open an existing one."
           values={{
             newButton: <EuiCode>{i18n.TIMELINE_TOUR_NEW}</EuiCode>,
             openButton: <EuiCode>{i18n.TIMELINE_TOUR_OPEN}</EuiCode>,
@@ -42,10 +42,7 @@ export const timelineTourSteps = [
       <EuiText>
         <FormattedMessage
           id="xpack.securitySolution.timeline.tour.addToFavorites.description"
-          defaultMessage="Click {addToFavoritesButton} to effortlessly curate and quickly access your most important timelines"
-          values={{
-            addToFavoritesButton: <EuiCode>{i18n.TIMELINE_TOUR_ADD_TO_FAV}</EuiCode>,
-          }}
+          defaultMessage="Click to favorite your Timeline so you can quickly find it later."
         />
       </EuiText>
     ),
@@ -58,7 +55,7 @@ export const timelineTourSteps = [
       <EuiText>
         <FormattedMessage
           id="xpack.securitySolution.timeline.tour.changeDataView.description"
-          defaultMessage="Click the {dataViewButton} menu to choose the event or alert data that you want to display"
+          defaultMessage="Click the {dataViewButton} menu to choose the event or alert data that you want to display."
           values={{
             dataViewButton: <EuiCode> {i18n.TIMELINE_TOUR_DATA_VIEW}</EuiCode>,
           }}
@@ -79,7 +76,7 @@ export const timelineTourSteps = [
       <EuiText>
         <FormattedMessage
           id="xpack.securitySolution.timeline.tour.saveTimeline.description"
-          defaultMessage="Click {saveButton} to manually save new changes. While saving your Timeline, you can {editButton} its name and description or save it as a new Timeline"
+          defaultMessage="Click {saveButton} to manually save new changes. While saving your Timeline, you can {editButton} its name and description or save it as a new Timeline."
           values={{
             saveButton: <EuiCode>{i18n.TIMELINE_TOUR_SAVE}</EuiCode>,
             editButton: <EuiCode>{i18n.TIMELINE_TOUR_EDIT}</EuiCode>,

diff --git a/x-pack/plugins/security_solution/public/timelines/components/timeline/tour/translations.ts b/x-pack/plugins/security_solution/public/timelines/components/timeline/tour/translations.ts
@@ -31,7 +31,7 @@ export const TIMELINE_TOUR_DATA_PROVIDER_VISIBILITY_TITLE = i18n.translate(
 export const TIMELINE_TOUR_DATA_PROVIDER_VISIBILITY_DESCRIPTION = i18n.translate(
   'xpack.securitySolution.timeline.tour.dataProviderToggle.description',
   {
-    defaultMessage: 'Click to expand or collapse the query builder',
+    defaultMessage: 'Click to expand or collapse the query builder.',
   }
 );
 
@@ -52,7 +52,7 @@ export const TIMELINE_TOUR_CHANGE_DATA_VIEW_TITLE = i18n.translate(
 export const TIMELINE_TOUR_ADD_TO_FAVORITES_STEP_TITLE = i18n.translate(
   'xpack.securitySolution.timeline.tour.addToFavorites.title',
   {
-    defaultMessage: 'Add to Favorites is now easier to access',
+    defaultMessage: 'A new and intuitive way to favorite your Timeline',
   }
 );
 
@@ -84,13 +84,6 @@ export const TIMELINE_TOUR_EDIT = i18n.translate('xpack.securitySolution.timelin
   defaultMessage: 'Edit',
 });
 
-export const TIMELINE_TOUR_ADD_TO_FAV = i18n.translate(
-  'xpack.securitySolution.timeline.tour.addToFavorites',
-  {
-    defaultMessage: 'Add to Favorites',
-  }
-);
-
 export const TIMELINE_TOUR_DATA_VIEW = i18n.translate(
   'xpack.securitySolution.timeline.tour.dataView',
   {