[Maps] handle case where fit to bounds does not match any documents (#…

…66307) * [Maps] handle case where fit to bounds does not match any documents * review feedback
elastic · May 13, 2020 · 9e0504e · 9e0504e
1 parent 9b01e6b
commit 9e0504e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 12 deletions.
diff --git a/x-pack/plugins/maps/public/actions/map_actions.js b/x-pack/plugins/maps/public/actions/map_actions.js
@@ -587,8 +587,8 @@ export function fitToDataBounds() {
       const b = bounds[i];
 
       //filter out undefined bounds (uses Infinity due to turf responses)
-
       if (
+        b === null ||
         b.minLon === Infinity ||
         b.maxLon === Infinity ||
         b.minLat === -Infinity ||

diff --git a/x-pack/plugins/maps/public/classes/sources/es_source/es_source.js b/x-pack/plugins/maps/public/classes/sources/es_source/es_source.js
@@ -161,18 +161,13 @@ export class AbstractESSource extends AbstractVectorSource {
     let esBounds;
     try {
       const esResp = await searchSource.fetch();
-      esBounds = _.get(esResp, 'aggregations.fitToBounds.bounds');
+      if (!esResp.aggregations.fitToBounds.bounds) {
+        // aggregations.fitToBounds is empty object when there are no matching documents
+        return null;
+      }
+      esBounds = esResp.aggregations.fitToBounds.bounds;
     } catch (error) {
-      esBounds = {
-        top_left: {
-          lat: 90,
-          lon: -180,
-        },
-        bottom_right: {
-          lat: -90,
-          lon: 180,
-        },
-      };
+      return null;
     }
 
     const minLon = esBounds.top_left.lon;