[ML] Replace .some() with for...of{}.

elastic · May 4, 2020 · 9d6f488 · 9d6f488
1 parent 5acdc0c
commit 9d6f488
Showing 1 changed file with 20 additions and 12 deletions.
diff --git a/...ns/create_transform/components/step_define/common/get_agg_name_conflict_toast_messages.ts b/...ns/create_transform/components/step_define/common/get_agg_name_conflict_toast_messages.ts
@@ -53,10 +53,11 @@ export function getAggNameConflictToastMessages(
   }
 
   // check all aggs against new aggName
-  Object.keys(aggList).some(aggListName => {
+  for (const aggListName of Object.keys(aggList)) {
     const aggListNameSplit = aggListName.split('.');
     let aggListNameCheck: string;
-    return aggListNameSplit.some(aggListNamePart => {
+    let shouldBreak = false;
+    for (const aggListNamePart of aggListNameSplit) {
       aggListNameCheck =
         aggListNameCheck === undefined ? aggListNamePart : `${aggListNameCheck}.${aggListNamePart}`;
       if (aggListNameCheck === aggName) {
@@ -66,21 +67,25 @@ export function getAggNameConflictToastMessages(
             values: { aggName, aggListName },
           })
         );
-        return true;
+        shouldBreak = true;
+        break;
       }
-      return false;
-    });
-  });
+    }
+    if (shouldBreak) {
+      break;
+    }
+  }
 
   if (conflicts.length > 0) {
     return conflicts;
   }
 
   // check all group-bys against new aggName
-  Object.keys(groupByList).some(groupByListName => {
+  for (const groupByListName of Object.keys(groupByList)) {
     const groupByListNameSplit = groupByListName.split('.');
     let groupByListNameCheck: string;
-    return groupByListNameSplit.some(groupByListNamePart => {
+    const shouldBreak = false;
+    for (const groupByListNamePart of groupByListNameSplit) {
       groupByListNameCheck =
         groupByListNameCheck === undefined
           ? groupByListNamePart
@@ -92,11 +97,14 @@ export function getAggNameConflictToastMessages(
             values: { aggName, groupByListName },
           })
         );
-        return true;
+        shouldBreak = true;
+        break;
       }
-      return false;
-    });
-  });
+    }
+    if (shouldBreak) {
+      break;
+    }
+  }
 
   return conflicts;
 }