Merge branch 'master' into saved-object-setup-client

.ci/Jenkinsfile_flaky

@@ -34,7 +34,7 @@ stage("Kibana Pipeline") {
                 if (!IS_XPACK) {
                   kibanaPipeline.buildOss()
                   if (CI_GROUP == '1') {
-                    runbld "./test/scripts/jenkins_build_kbn_tp_sample_panel_action.sh"
+                    runbld("./test/scripts/jenkins_build_kbn_tp_sample_panel_action.sh", "Build kbn tp sample panel action for ciGroup1")
                   }
                 } else {
                   kibanaPipeline.buildXpack()
@@ -62,18 +62,18 @@ stage("Kibana Pipeline") {
 def getWorkerFromParams(isXpack, job, ciGroup) {
   if (!isXpack) {
     if (job == 'firefoxSmoke') {
-      return kibanaPipeline.getPostBuildWorker('firefoxSmoke', { runbld './test/scripts/jenkins_firefox_smoke.sh' })
+      return kibanaPipeline.getPostBuildWorker('firefoxSmoke', { runbld('./test/scripts/jenkins_firefox_smoke.sh', 'Execute kibana-firefoxSmoke') })
     } else if(job == 'visualRegression') {
-      return kibanaPipeline.getPostBuildWorker('visualRegression', { runbld './test/scripts/jenkins_visual_regression.sh' })
+      return kibanaPipeline.getPostBuildWorker('visualRegression', { runbld('./test/scripts/jenkins_visual_regression.sh', 'Execute kibana-visualRegression') })
     } else {
       return kibanaPipeline.getOssCiGroupWorker(ciGroup)
     }
   }
 
   if (job == 'firefoxSmoke') {
-    return kibanaPipeline.getPostBuildWorker('xpack-firefoxSmoke', { runbld './test/scripts/jenkins_xpack_firefox_smoke.sh' })
+    return kibanaPipeline.getPostBuildWorker('xpack-firefoxSmoke', { runbld('./test/scripts/jenkins_xpack_firefox_smoke.sh', 'Execute xpack-firefoxSmoke') })
   } else if(job == 'visualRegression') {
-    return kibanaPipeline.getPostBuildWorker('xpack-visualRegression', { runbld './test/scripts/jenkins_xpack_visual_regression.sh' })
+    return kibanaPipeline.getPostBuildWorker('xpack-visualRegression', { runbld('./test/scripts/jenkins_xpack_visual_regression.sh', 'Execute xpack-visualRegression') })
   } else {
     return kibanaPipeline.getXpackCiGroupWorker(ciGroup)
   }

.eslintrc.js

@@ -64,12 +64,6 @@ module.exports = {
         'jsx-a11y/no-onchange': 'off',
       },
     },
-    {
-      files: ['src/core/public/application/**/*.{js,ts,tsx}'],
-      rules: {
-        'react/no-danger': 'off',
-      },
-    },
     {
       files: ['src/legacy/core_plugins/console/**/*.{js,ts,tsx}'],
       rules: {
@@ -214,13 +208,6 @@ module.exports = {
         'jsx-a11y/click-events-have-key-events': 'off',
       },
     },
-    {
-      files: ['x-pack/legacy/plugins/siem/**/*.{js,ts,tsx}'],
-      rules: {
-        'react-hooks/exhaustive-deps': 'off',
-        'react-hooks/rules-of-hooks': 'off',
-      },
-    },
     {
       files: ['x-pack/legacy/plugins/snapshot_restore/**/*.{js,ts,tsx}'],
       rules: {
@@ -839,6 +826,8 @@ module.exports = {
         // might be introduced after the other warns are fixed
         // 'react/jsx-sort-props': 'error',
         'react/jsx-tag-spacing': 'error',
+        // might be introduced after the other warns are fixed
+        'react-hooks/exhaustive-deps': 'off',
         'require-atomic-updates': 'error',
         'rest-spread-spacing': ['error', 'never'],
         'symbol-description': 'error',

.github/CODEOWNERS

@@ -28,11 +28,6 @@
 # Canvas
 /x-pack/legacy/plugins/canvas/  @elastic/kibana-canvas
 
-# Code
-/x-pack/legacy/plugins/code/  @teams/code
-/x-pack/test/functional/apps/code/  @teams/code
-/x-pack/test/api_integration/apis/code/  @teams/code
-
 # Logs & Metrics UI
 /x-pack/legacy/plugins/infra/ @elastic/logs-metrics-ui
 /x-pack/legacy/plugins/integrations_manager/ @elastic/epm

.i18nrc.json

@@ -6,9 +6,9 @@
     "dashboardEmbeddableContainer": "src/plugins/dashboard_embeddable_container",
     "data": ["src/legacy/core_plugins/data", "src/plugins/data"],
     "embeddableApi": "src/plugins/embeddable",
+    "share": "src/plugins/share",
     "esUi": "src/plugins/es_ui_shared",
-    "expressions_np": "src/plugins/expressions",
-    "expressions": "src/legacy/core_plugins/expressions",
+    "expressions": "src/plugins/expressions",
     "inputControl": "src/legacy/core_plugins/input_control_vis",
     "inspector": "src/plugins/inspector",
     "inspectorViews": "src/legacy/core_plugins/inspector_views",
@@ -34,7 +34,7 @@
     "visTypeTagCloud": "src/legacy/core_plugins/vis_type_tagcloud",
     "visTypeTimeseries": "src/legacy/core_plugins/vis_type_timeseries",
     "visTypeVega": "src/legacy/core_plugins/vis_type_vega",
-    "visualizations": "src/plugins/visualizations"
+    "visualizations": ["src/plugins/visualizations", "src/legacy/core_plugins/visualizations"]
   },
   "exclude": ["src/legacy/ui/ui_render/ui_render_mixin.js"],
   "translations": []

CONTRIBUTING.md

@@ -325,7 +325,7 @@ Note that for VSCode, to enable "live" linting of TypeScript (and other) file ty
   "eslint.autoFixOnSave": true,
 ```
 
-It is **not** recommended to use `prettier` plugin on Kibana project. Because settings are in `eslintrc.js` file and it is applied to too many files that shouldn't be prettier-ized. 
+:warning: It is **not** recommended to use the [`Prettier` extension/IDE plugin](https://prettier.io/) while maintaining the Kibana project. Formatting and styling roles are set in the multiple `.eslintrc.js` files across the project and some of them use the [NPM version of Prettier](https://www.npmjs.com/package/prettier). Using the IDE extension might cause conflicts, applying the formatting to too many files that shouldn't be prettier-ized and/or highlighting errors that are actually OK.
 
 ### Internationalization
 

Jenkinsfile

@@ -4,7 +4,7 @@ library 'kibana-pipeline-library'
 kibanaLibrary.load()
 
 stage("Kibana Pipeline") { // This stage is just here to help the BlueOcean UI a little bit
-  timeout(time: 180, unit: 'MINUTES') {
+  timeout(time: 120, unit: 'MINUTES') {
     timestamps {
       ansiColor('xterm') {
         catchError {
@@ -24,9 +24,9 @@ stage("Kibana Pipeline") { // This stage is just here to help the BlueOcean UI a
               'oss-ciGroup10': kibanaPipeline.getOssCiGroupWorker(10),
               'oss-ciGroup11': kibanaPipeline.getOssCiGroupWorker(11),
               'oss-ciGroup12': kibanaPipeline.getOssCiGroupWorker(12),
-              'oss-firefoxSmoke': kibanaPipeline.getPostBuildWorker('firefoxSmoke', { runbld './test/scripts/jenkins_firefox_smoke.sh' }),
-              'oss-accessibility': kibanaPipeline.getPostBuildWorker('accessibility', { runbld './test/scripts/jenkins_accessibility.sh' }),
-              'oss-visualRegression': kibanaPipeline.getPostBuildWorker('visualRegression', { runbld './test/scripts/jenkins_visual_regression.sh' }),
+              'oss-firefoxSmoke': kibanaPipeline.getPostBuildWorker('firefoxSmoke', { runbld('./test/scripts/jenkins_firefox_smoke.sh', 'Execute kibana-firefoxSmoke') }),
+              'oss-accessibility': kibanaPipeline.getPostBuildWorker('accessibility', { runbld('./test/scripts/jenkins_accessibility.sh', 'Execute kibana-accessibility') }),
+              'oss-visualRegression': kibanaPipeline.getPostBuildWorker('visualRegression', { runbld('./test/scripts/jenkins_visual_regression.sh', 'Execute kibana-visualRegression') }),
             ]),
             'kibana-xpack-agent': kibanaPipeline.withWorkers('kibana-xpack-tests', { kibanaPipeline.buildXpack() }, [
               'xpack-ciGroup1': kibanaPipeline.getXpackCiGroupWorker(1),
@@ -39,9 +39,9 @@ stage("Kibana Pipeline") { // This stage is just here to help the BlueOcean UI a
               'xpack-ciGroup8': kibanaPipeline.getXpackCiGroupWorker(8),
               'xpack-ciGroup9': kibanaPipeline.getXpackCiGroupWorker(9),
               'xpack-ciGroup10': kibanaPipeline.getXpackCiGroupWorker(10),
-              'xpack-firefoxSmoke': kibanaPipeline.getPostBuildWorker('xpack-firefoxSmoke', { runbld './test/scripts/jenkins_xpack_firefox_smoke.sh' }),
-              'xpack-accessibility': kibanaPipeline.getPostBuildWorker('xpack-accessibility', { runbld './test/scripts/jenkins_xpack_accessibility.sh' }),
-              'xpack-visualRegression': kibanaPipeline.getPostBuildWorker('xpack-visualRegression', { runbld './test/scripts/jenkins_xpack_visual_regression.sh' }),
+              'xpack-firefoxSmoke': kibanaPipeline.getPostBuildWorker('xpack-firefoxSmoke', { runbld('./test/scripts/jenkins_xpack_firefox_smoke.sh', 'Execute xpack-firefoxSmoke') }),
+              'xpack-accessibility': kibanaPipeline.getPostBuildWorker('xpack-accessibility', { runbld('./test/scripts/jenkins_xpack_accessibility.sh', 'Execute xpack-accessibility') }),
+              'xpack-visualRegression': kibanaPipeline.getPostBuildWorker('xpack-visualRegression', { runbld('./test/scripts/jenkins_xpack_visual_regression.sh', 'Execute xpack-visualRegression') }),
             ]),
           ])
         }

STYLEGUIDE.md

@@ -120,6 +120,7 @@ You should prefer modern language features in a lot of cases, e.g.:
 * Prefer arrow function over storing `this` (no `const self = this;`)
 * Prefer template strings over string concatenation
 * Prefer the spread operator for copying arrays (`[...arr]`) over `arr.slice()`
+* Use optional chaining (`?.`) and nullish Coalescing (`??`) over `lodash.get` (and similar utilities)
 
 ### Avoid mutability and state
 

docs/apm/advanced-queries.asciidoc

@@ -10,7 +10,7 @@ so it's easy to share a specific query or view with others.
 In the screenshot below, you can begin to see some of the transaction fields available for filtering on:  
 
 [role="screenshot"]
-image::apm/images/apm-query-bar.png[Example of the Kibana Query bar in APM UI in Kibana]
+image::apm/images/apm-query-bar.png[Example of the Kibana Query bar in APM app in Kibana]
 
 [float]
 ==== Example queries

docs/apm/agent-configuration.asciidoc

@@ -2,18 +2,15 @@
 [[agent-configuration]]
 === APM Agent configuration
 
-beta[] APM Agent configuration allows you to fine-tune your agent configuration directly in Kibana.
+APM Agent configuration allows you to fine-tune your agent configuration directly in Kibana.
 Best of all, changes are automatically propagated to your APM agents so there's no need to redeploy.
 
-To get started, simply choose the service and environment you wish to configure.
+To get started, simply choose the services and environments you wish to configure.
+The APM app will let you know when your configurations have been applied by your agents.
 
 [role="screenshot"]
 image::apm/images/apm-agent-configuration.png[APM Agent configuration in Kibana]
 
-IMPORTANT: As this feature is in Beta, a limited number of configuration settings are supported.
-We recommend you watch your agent logs to confirm that configuration has been applied.
-If you have feedback, please reach out in our https://discuss.elastic.co/c/apm[Discuss forum].
-
 [float]
 ==== Precedence
 
@@ -34,6 +31,26 @@ Kibana communicates any changed settings to APM Server so that your agents only
 [float]
 ==== Supported configurations
 
+[float]
+===== `CAPTURE_BODY`
+
+added[7.5.0] Can be `"off"`, `"errors"`, `"transactions"`, or `"all"`. Defaults to `"off"`.
+
+For transactions that are HTTP requests, the Agent can optionally capture the request body, e.g., POST variables.
+Remember, request bodies often contain sensitive values like passwords, credit card numbers, etc.
+If your service handles sensitive data, enable this feature with care.
+Turning on body capturing can also significantly increase the overhead the overhead of the Agent,
+and the Elasticsearch index size.
+
+[float]
+===== `TRANSACTION_MAX_SPANS`
+
+added[7.5.0] A number between `0` and `32000`. Defaults to `500`.
+
+Limit the number of spans that are recorded per transaction.
+This is helpful in cases where a transaction creates a very high amount of spans, e.g., thousands of SQL queries.
+Setting an upper limit will help prevent the Agent and the APM Server from being overloaded.
+
 [float]
 ===== `TRANSACTION_SAMPLE_RATE`
 

docs/apm/errors.asciidoc

@@ -10,12 +10,12 @@ This makes it very easy to quickly see which errors are affecting your services,
 and to take actions to rectify them.
 
 [role="screenshot"]
-image::apm/images/apm-errors-overview.png[Example view of the errors overview in the APM UI in Kibana]
+image::apm/images/apm-errors-overview.png[Example view of the errors overview in the APM app in Kibana]
 
 Selecting an error group ID or error message brings you to the *Error group*.
 
 [role="screenshot"]
-image::apm/images/apm-error-group.png[Example view of the error group page in the APM UI in Kibana]
+image::apm/images/apm-error-group.png[Example view of the error group page in the APM app in Kibana]
 
 Here, you'll see the error message, culprit, and the number of occurrences over time.
 
@@ -43,4 +43,4 @@ With Watcher, your team can set up reports within minutes.
 Watches are managed separately in the dedicated Watcher UI available in Advanced Settings.
 
 [role="screenshot"]
-image::apm/images/apm-errors-watcher-assistant.png[Example view of the Watcher assistant for errors in APM UI in Kibana]
+image::apm/images/apm-errors-watcher-assistant.png[Example view of the Watcher assistant for errors in APM app in Kibana]

docs/apm/getting-started.asciidoc

@@ -10,7 +10,7 @@ image::apm/images/apm-setup.png[Installation instructions on the APM page in Kib
 
 
 Index patterns tell Kibana which Elasticsearch indices you want to explore.
-An APM index pattern is necessary for certain features in the APM UI, like the query bar. 
+An APM index pattern is necessary for certain features in the APM app, like the query bar. 
 To set up the correct index pattern,
 simply click *Load Kibana objects* at the bottom of the Setup Instructions.
 

docs/apm/metrics.asciidoc

@@ -2,13 +2,21 @@
 === Metrics overview
 
 The *Metrics* overview provides agent-specific metrics,
-which lets you perform more in-depth root cause analysis investigations within the APM UI.
+which lets you perform more in-depth root cause analysis investigations within the APM app.
 
 If you're experiencing a problem with your service, you can use this page to attempt to find the underlying cause.
 For example, you might be able to correlate a high number of errors with a long transaction duration, high CPU usage, or a memory leak.   
 
 [role="screenshot"]
-image::apm/images/apm-metrics.png[Example view of the Metrics overview in APM UI in Kibana]
+image::apm/images/apm-metrics.png[Example view of the Metrics overview in APM app in Kibana]
+
+If you're using the Java Agent, the metrics view focuses on JVMs.
+A detailed view of metrics per JVM makes it much easier to analyze the provided metrics:
+CPU usage, memory usage, heap or non-heap memory,
+thread count, garbage collection rate, and garbage collection time spent per minute.
+
+[role="screenshot"]
+image::apm/images/jvm-metrics.png[Example view of the Metrics overview for the Java Agent]
 
 [[machine-learning-integration]]
 === Machine Learning integration
@@ -17,7 +25,7 @@ The Machine Learning integration will initiate a new job predefined to calculate
 The response time graph will show the expected bounds and annotate the graph when the anomaly score is 75 or above.
 
 [role="screenshot"]
-image::apm/images/apm-ml-integration.png[Example view of anomaly scores on response times in APM UI in Kibana]
+image::apm/images/apm-ml-integration.png[Example view of anomaly scores on response times in APM app in Kibana]
 
 Jobs can be created per transaction type and based on the average response time.
 You can manage jobs in the *Machine Learning jobs management*.

docs/apm/services.asciidoc

@@ -6,4 +6,4 @@ The *Services* overview gives you quick insights into the health and general per
 You can add services by setting the `service.name` configuration in each of the {apm-agents-ref}[APM agents] you’re instrumenting.
 
 [role="screenshot"]
-image::apm/images/apm-services-overview.png[Example view of services table the APM UI in Kibana]
+image::apm/images/apm-services-overview.png[Example view of services table the APM app in Kibana]

docs/apm/spans.asciidoc

@@ -9,7 +9,7 @@ The span timeline visualization is a bird's-eye view of what your application wa
 This makes it useful for visualizing where the selected transaction spent most of its time.
 
 [role="screenshot"]
-image::apm/images/apm-distributed-tracing.png[Example view of the distributed tracing in APM UI in Kibana]
+image::apm/images/apm-distributed-tracing.png[Example view of the distributed tracing in APM app in Kibana]
 
 View a span in detail by clicking on it in the timeline waterfall.
 For example, in the below screenshot we've clicked on an SQL Select database query.
@@ -20,13 +20,13 @@ Finally, APM knows which files are your code and which are just modules or libra
 These library frames will be minimized by default in order to show you the most relevant stack trace. 
 
 [role="screenshot"]
-image::apm/images/apm-span-detail.png[Example view of a span detail in the APM UI in Kibana]
+image::apm/images/apm-span-detail.png[Example view of a span detail in the APM app in Kibana]
 
 If your span timeline is colorful, it's indicative of a <<distributed-tracing,distributed trace>>.
 Services in a distributed trace are separated by color and listed in the order they occur.
 
 [role="screenshot"]
-image::apm/images/apm-services-trace.png[Example of distributed trace colors in the APM UI in Kibana]
+image::apm/images/apm-services-trace.png[Example of distributed trace colors in the APM app in Kibana]
 
 Don't forget, a distributed trace includes more than one transaction.
 When viewing these distributed traces in the timeline waterfall, you'll see this image:apm/images/transaction-icon.png[APM icon] icon,
@@ -37,4 +37,4 @@ After exploring these traces,
 you can return to the full trace by clicking *View full trace* in the upper right hand corner of the page.
 
 [role="screenshot"]
-image::apm/images/apm-transaction-sample.png[Example of distributed trace colors in the APM UI in Kibana]
+image::apm/images/apm-transaction-sample.png[Example of distributed trace colors in the APM app in Kibana]

docs/apm/traces.asciidoc

@@ -11,7 +11,7 @@ it's the collective amount of pain a specific endpoint is causing your users.
 If there's a particular endpoint you're worried about, you can click on it to view the <<transaction-details, transaction details>>.
 
 [role="screenshot"]
-image::apm/images/apm-traces.png[Example view of the Traces overview in APM UI in Kibana]
+image::apm/images/apm-traces.png[Example view of the Traces overview in APM app in Kibana]
 
 [float]
 [[distributed-tracing]]
@@ -22,7 +22,7 @@ Distributed tracing is a key feature of modern application performance monitorin
 service-based architectures.
 
 Distributed tracing allows APM users to automatically trace requests all the way through the service architecture,
-and visualize those traces in one single view in the APM UI.
+and visualize those traces in one single view in the APM app.
 This is accomplished by tracing all of the requests, from the initial web request to your front-end service,
 to queries made to your back-end services.
 This makes finding possible bottlenecks throughout your application much easier and faster.
@@ -31,6 +31,6 @@ By definition, a distributed trace includes more than one transaction.
 You can use the <<spans,span timeline visualization>> to view a waterfall display of all of the transactions from individual services that are connected in a trace.
 
 [role="screenshot"]
-image::apm/images/apm-distributed-tracing.png[Example view of the distributed tracing in APM UI in Kibana]
+image::apm/images/apm-distributed-tracing.png[Example view of the distributed tracing in APM app in Kibana]
 
 TIP: Distributed tracing is supported by all APM agents and there’s no additional configuration needed.