[7.x] Use credentials: same-origin when we fetch translations JSON. (…

…#34123)
elastic · Mar 28, 2019 · 9abeb16 · 9abeb16
1 parent 7cf702b
commit 9abeb16
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/kbn-i18n/src/core/i18n.test.ts b/packages/kbn-i18n/src/core/i18n.test.ts
@@ -921,7 +921,7 @@ describe('I18n engine', () => {
       await expect(i18n.load('some-url')).resolves.toBeUndefined();
 
       expect(mockFetch).toHaveBeenCalledTimes(1);
-      expect(mockFetch).toHaveBeenCalledWith('some-url');
+      expect(mockFetch).toHaveBeenCalledWith('some-url', { credentials: 'same-origin' });
 
       expect(i18n.getTranslation()).toEqual(translations);
     });

diff --git a/packages/kbn-i18n/src/core/i18n.ts b/packages/kbn-i18n/src/core/i18n.ts
@@ -240,7 +240,11 @@ export function init(newTranslation?: Translation) {
  * @param translationsUrl URL pointing to the JSON bundle with translations.
  */
 export async function load(translationsUrl: string) {
-  const response = await fetch(translationsUrl);
+  // Once this package is integrated into core Kibana we should switch to an abstraction
+  // around `fetch` provided by the platform, e.g. `kfetch`.
+  const response = await fetch(translationsUrl, {
+    credentials: 'same-origin',
+  });
 
   if (response.status >= 300) {
     throw new Error(`Translations request failed with status code: ${response.status}`);