[eslint] convert to @typescript-eslint/no-unused-expressions (#76471)

* [eslint] convert to @typescript-eslint/no-unused-expressions * fix lint errors Co-authored-by: spalger <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
elastic · Sep 4, 2020 · 9a8a028 · 9a8a028
1 parent 63a08b4
commit 9a8a028
Show file tree

Hide file tree

Showing 8 changed files with 15 additions and 16 deletions.
diff --git a/packages/elastic-eslint-config-kibana/typescript.js b/packages/elastic-eslint-config-kibana/typescript.js
@@ -224,7 +224,8 @@ module.exports = {
           'no-undef-init': 'error',
           'no-unsafe-finally': 'error',
           'no-unsanitized/property': 'error',
-          'no-unused-expressions': 'error',
+          'no-unused-expressions': 'off',
+          '@typescript-eslint/no-unused-expressions': 'error',
           'no-unused-labels': 'error',
           'no-var': 'error',
           'object-shorthand': 'error',

diff --git a/test/functional/apps/visualize/_tsvb_markdown.ts b/test/functional/apps/visualize/_tsvb_markdown.ts
@@ -30,10 +30,11 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
     await visualBuilder.markdownSwitchSubTab('markdown');
     const rerenderedTable = await visualBuilder.getMarkdownTableVariables();
     rerenderedTable.forEach((row) => {
-      // eslint-disable-next-line no-unused-expressions
-      variableName === 'label'
-        ? expect(row.key).to.include.string(checkedValue)
-        : expect(row.key).to.not.include.string(checkedValue);
+      if (variableName === 'label') {
+        expect(row.key).to.include.string(checkedValue);
+      } else {
+        expect(row.key).to.not.include.string(checkedValue);
+      }
     });
   }
 
@@ -107,10 +108,11 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
 
         table.forEach((row, index) => {
           // exception: last index for variable is always: {{count.label}}
-          // eslint-disable-next-line no-unused-expressions
-          index === table.length - 1
-            ? expect(row.key).to.not.include.string(VARIABLE)
-            : expect(row.key).to.include.string(VARIABLE);
+          if (index === table.length - 1) {
+            expect(row.key).to.not.include.string(VARIABLE);
+          } else {
+            expect(row.key).to.include.string(VARIABLE);
+          }
         });
 
         await cleanupMarkdownData(VARIABLE, VARIABLE);

diff --git a/...ck/plugins/apm/public/components/shared/TransactionDurationAlertTrigger/index.stories.tsx b/...ck/plugins/apm/public/components/shared/TransactionDurationAlertTrigger/index.stories.tsx
@@ -19,7 +19,7 @@ import { MockUrlParamsContextProvider } from '../../../context/UrlParamsContext/
 // our current storybook setup has core-js-related problems when trying to import
 // it.
 // storiesOf('app/TransactionDurationAlertTrigger', module).add('example',
-// eslint-disable-next-line no-unused-expressions
+// eslint-disable-next-line @typescript-eslint/no-unused-expressions
 () => {
   const params = {
     threshold: 1500,

diff --git a/x-pack/plugins/infra/public/components/logging/log_text_stream/log_entry_row.tsx b/x-pack/plugins/infra/public/components/logging/log_text_stream/log_entry_row.tsx
@@ -85,7 +85,7 @@ export const LogEntryRow = memo(
     ]);
 
     const handleOpenViewLogInContext = useCallback(() => {
-      openViewLogInContext?.(logEntry); // eslint-disable-line no-unused-expressions
+      openViewLogInContext?.(logEntry);
       trackMetric({ metric: 'view_in_context__stream' });
     }, [openViewLogInContext, logEntry, trackMetric]);
 

diff --git a/x-pack/plugins/infra/public/pages/logs/log_entry_categories/page_results_content.tsx b/x-pack/plugins/infra/public/pages/logs/log_entry_categories/page_results_content.tsx
@@ -73,7 +73,6 @@ export const LogEntryCategoriesResultsContent: React.FunctionComponent<LogEntryC
 
   const showLoadDataErrorNotification = useCallback(
     (error: Error) => {
-      // eslint-disable-next-line no-unused-expressions
       services.notifications?.toasts.addError(error, {
         title: loadDataErrorTitle,
       });

diff --git a/x-pack/plugins/infra/public/pages/logs/log_entry_rate/page_results_content.tsx b/x-pack/plugins/infra/public/pages/logs/log_entry_rate/page_results_content.tsx
@@ -103,7 +103,6 @@ export const LogEntryRateResultsContent: React.FunctionComponent = () => {
         }),
       };
 
-      // eslint-disable-next-line no-unused-expressions
       navigateToApp?.('logs', { path: `/stream?${stringify(params)}` });
     },
     [queryTimeRange, navigateToApp]

diff --git a/x-pack/plugins/security_solution/public/timelines/components/row_renderers_browser/index.tsx b/x-pack/plugins/security_solution/public/timelines/components/row_renderers_browser/index.tsx
@@ -102,12 +102,10 @@ const StatefulRowRenderersBrowserComponent: React.FC<StatefulRowRenderersBrowser
   const hideFieldBrowser = useCallback(() => setShow(false), []);
 
   const handleDisableAll = useCallback(() => {
-    // eslint-disable-next-line no-unused-expressions
     tableRef?.current?.setSelection([]);
   }, [tableRef]);
 
   const handleEnableAll = useCallback(() => {
-    // eslint-disable-next-line no-unused-expressions
     tableRef?.current?.setSelection(renderers);
   }, [tableRef]);
 

diff --git a/...rity_solution/public/timelines/components/row_renderers_browser/row_renderers_browser.tsx b/...rity_solution/public/timelines/components/row_renderers_browser/row_renderers_browser.tsx
@@ -88,7 +88,7 @@ const RowRenderersBrowserComponent = React.forwardRef(
       (item: RowRendererOption) => () => {
         const newSelection = xor([item], notExcludedRowRenderers);
         // @ts-expect-error
-        ref?.current?.setSelection(newSelection); // eslint-disable-line no-unused-expressions
+        ref?.current?.setSelection(newSelection);
       },
       [notExcludedRowRenderers, ref]
     );