Fix scrolling list on Firefox (#26246)

* Fix scrolling list on Firefox * Update jest snapshost after adding a class to modal
elastic · Dec 3, 2018 · 97f0dcb · 97f0dcb
1 parent cfb1404
commit 97f0dcb
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/...acy/core_plugins/kibana/public/visualize/wizard/__snapshots__/new_vis_modal.test.tsx.snap b/...acy/core_plugins/kibana/public/visualize/wizard/__snapshots__/new_vis_modal.test.tsx.snap
@@ -366,6 +366,7 @@ exports[`NewVisModal should render as expected 1`] = `
                             >
                               <EuiFlexGroup
                                 alignItems="stretch"
+                                className="visNewVisDialog__list"
                                 component="div"
                                 direction="column"
                                 gutterSize="none"
@@ -374,7 +375,7 @@ exports[`NewVisModal should render as expected 1`] = `
                                 wrap={false}
                               >
                                 <div
-                                  className="euiFlexGroup euiFlexGroup--directionColumn"
+                                  className="euiFlexGroup euiFlexGroup--directionColumn visNewVisDialog__list"
                                 >
                                   <EuiFlexItem
                                     className="visNewVisDialog__searchWrapper"

diff --git a/src/legacy/core_plugins/kibana/public/visualize/wizard/_dialog.scss b/src/legacy/core_plugins/kibana/public/visualize/wizard/_dialog.scss
@@ -8,6 +8,10 @@
 .visNewVisDialog__body {
   display: flex;
   padding: $euiSizeM $euiSizeL 0;
+  min-height: 0;
+}
+.visNewVisDialog__list {
+  min-height: 0;
 }
 
 .visNewVisDialog__searchWrapper {
@@ -16,6 +20,7 @@
 
 .visNewVisDialog__typesWrapper {
   max-width: $euiSizeXXL * 10;
+  min-height: 0;
   padding-top: 2px; // Account for search field dropshadow
   padding-bottom: $euiSize;
   // Add overflow shadows via pseudo elements

diff --git a/src/legacy/core_plugins/kibana/public/visualize/wizard/type_selection/type_selection.tsx b/src/legacy/core_plugins/kibana/public/visualize/wizard/type_selection/type_selection.tsx
@@ -79,7 +79,12 @@ class TypeSelection extends React.Component<TypeSelectionProps, TypeSelectionSta
         <div className="visNewVisDialog__body">
           <EuiFlexGroup gutterSize="xl">
             <EuiFlexItem>
-              <EuiFlexGroup direction="column" gutterSize="none" responsive={false}>
+              <EuiFlexGroup
+                className="visNewVisDialog__list"
+                direction="column"
+                gutterSize="none"
+                responsive={false}
+              >
                 <EuiFlexItem grow={false} className="visNewVisDialog__searchWrapper">
                   <EuiFieldSearch
                     placeholder="Filter"