Skip to content

Commit

Permalink
few changes didnt get in, updated tests
Browse files Browse the repository at this point in the history
  • Loading branch information
yctercero committed Jul 1, 2020
1 parent 3026957 commit 9341cba
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,9 @@ export const getOperators = (field: IFieldType | undefined): OperatorOption[] =>
};

export function validateParams(params: string | undefined, type: string) {
if (params == null) {
return false;
// Box would show error state if empty otherwise
if (params == null || params === '') {
return true;
}

switch (type) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -242,17 +242,7 @@ export const getFormattedBuilderEntries = (
({ name }) => item.field != null && item.field === name
);
return {
field: {
name: 'nestedField.child',
type: 'nested',
esTypes: ['text'],
count: 0,
scripted: false,
searchable: true,
aggregatable: false,
readFromDocValues: false,
subType: { nested: { path: 'nestedField' } },
},
field: selectedField,
operator: getExceptionOperatorSelect(item),
value: getEntryValue(item),
};
Expand Down

0 comments on commit 9341cba

Please sign in to comment.