Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[8.10] [Fleet] Only show agent dashboard links if there is more than …
…one non-server agent and if the dashboards exist (#164469) (#164539) # Backport This will backport the following commits from `main` to `8.10`: - [[Fleet] Only show agent dashboard links if there is more than one non-server agent and if the dashboards exist (#164469)](#164469) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mark Hopkin","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-23T08:53:49Z","message":"[Fleet] Only show agent dashboard links if there is more than one non-server agent and if the dashboards exist (#164469)\n\n## Summary\r\n\r\nCloses #161827\r\n\r\nThese buttons were showing in cloud when there was only the cloud agent\r\nadded:\r\n\r\n<img width=\"647\" alt=\"Screenshot 2023-08-22 at 16 18 51\"\r\nsrc=\"https://github.com/elastic/kibana/assets/3315046/baaff9b9-17fc-49b5-bad9-980f91a5ae15\">\r\n\r\nThe ingest dashboard links will now only show if:\r\n\r\n- the user has one agent that is not part of a policy containing fleet\r\nserver (I have re-used an existing hook we have to check this here)\r\n- the agent ingest metrics dashaboard exists in the current space\r\n\r\nTest Scenarios\r\n\r\n1. Setup fleet with ONLY a fleet server connected, the dashboard links\r\nshould not show\r\n2. Setup fleet with fleet server and another non-fleet server agent, the\r\ndashboard links should show\r\n3. With the same setup as test case 2, now create another space, visit\r\nfleet in the new space, the links should not show as the dashboards are\r\nnot installed in the current space.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"805c974ed0c6f30be9153734859e0a28fa95eae1","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Fleet","backport:prev-minor","v8.11.0"],"number":164469,"url":"https://github.com/elastic/kibana/pull/164469","mergeCommit":{"message":"[Fleet] Only show agent dashboard links if there is more than one non-server agent and if the dashboards exist (#164469)\n\n## Summary\r\n\r\nCloses #161827\r\n\r\nThese buttons were showing in cloud when there was only the cloud agent\r\nadded:\r\n\r\n<img width=\"647\" alt=\"Screenshot 2023-08-22 at 16 18 51\"\r\nsrc=\"https://github.com/elastic/kibana/assets/3315046/baaff9b9-17fc-49b5-bad9-980f91a5ae15\">\r\n\r\nThe ingest dashboard links will now only show if:\r\n\r\n- the user has one agent that is not part of a policy containing fleet\r\nserver (I have re-used an existing hook we have to check this here)\r\n- the agent ingest metrics dashaboard exists in the current space\r\n\r\nTest Scenarios\r\n\r\n1. Setup fleet with ONLY a fleet server connected, the dashboard links\r\nshould not show\r\n2. Setup fleet with fleet server and another non-fleet server agent, the\r\ndashboard links should show\r\n3. With the same setup as test case 2, now create another space, visit\r\nfleet in the new space, the links should not show as the dashboards are\r\nnot installed in the current space.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"805c974ed0c6f30be9153734859e0a28fa95eae1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164469","number":164469,"mergeCommit":{"message":"[Fleet] Only show agent dashboard links if there is more than one non-server agent and if the dashboards exist (#164469)\n\n## Summary\r\n\r\nCloses #161827\r\n\r\nThese buttons were showing in cloud when there was only the cloud agent\r\nadded:\r\n\r\n<img width=\"647\" alt=\"Screenshot 2023-08-22 at 16 18 51\"\r\nsrc=\"https://github.com/elastic/kibana/assets/3315046/baaff9b9-17fc-49b5-bad9-980f91a5ae15\">\r\n\r\nThe ingest dashboard links will now only show if:\r\n\r\n- the user has one agent that is not part of a policy containing fleet\r\nserver (I have re-used an existing hook we have to check this here)\r\n- the agent ingest metrics dashaboard exists in the current space\r\n\r\nTest Scenarios\r\n\r\n1. Setup fleet with ONLY a fleet server connected, the dashboard links\r\nshould not show\r\n2. Setup fleet with fleet server and another non-fleet server agent, the\r\ndashboard links should show\r\n3. With the same setup as test case 2, now create another space, visit\r\nfleet in the new space, the links should not show as the dashboards are\r\nnot installed in the current space.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"805c974ed0c6f30be9153734859e0a28fa95eae1"}}]}] BACKPORT--> Co-authored-by: Mark Hopkin <[email protected]>
- Loading branch information