Merge branch '8.5' into backport/8.5/pr-142278

.buildkite/pipelines/es_snapshots/build.yml

@@ -1,5 +1,6 @@
 steps:
   - command: .buildkite/scripts/steps/es_snapshots/build.sh
     label: Build ES Snapshot
+    timeout_in_minutes: 30
     agents:
       queue: c2-8

.ci/Dockerfile

@@ -1,7 +1,7 @@
 # NOTE: This Dockerfile is ONLY used to run certain tasks in CI. It is not used to run Kibana or as a distributable.
 # If you're looking for the Kibana Docker image distributable, please see: src/dev/build/tasks/os_packages/docker_generator/templates/dockerfile.template.ts
 
-ARG NODE_VERSION=16.17.1
+ARG NODE_VERSION=16.18.1
 
 FROM node:${NODE_VERSION} AS base
 

.gitignore

@@ -92,6 +92,7 @@ report.asciidoc
 .yarn-local-mirror
 
 # Bazel
+.ijwb
 /bazel
 /bazel-*
 .bazelrc.user

.node-version

@@ -1 +1 @@
-16.17.1
+16.18.1

.nvmrc

@@ -1 +1 @@
-16.17.1
+16.18.1

WORKSPACE.bazel

@@ -22,13 +22,13 @@ load("@build_bazel_rules_nodejs//:index.bzl", "node_repositories", "yarn_install
 # Setup the Node.js toolchain for the architectures we want to support
 node_repositories(
   node_repositories = {
-    "16.17.1-darwin_amd64": ("node-v16.17.1-darwin-x64.tar.gz", "node-v16.17.1-darwin-x64", "3db26761ad8493b894d42260d7e65094b7af9bc473588739e61bc1c32d6ff955"),
-    "16.17.1-darwin_arm64": ("node-v16.17.1-darwin-arm64.tar.gz", "node-v16.17.1-darwin-arm64", "f9f02f7872e2e8ee54320fce13deb9d56904f32bb0615b6e21aa3371d8899150"),
-    "16.17.1-linux_arm64": ("node-v16.17.1-linux-arm64.tar.xz", "node-v16.17.1-linux-arm64", "3dfb8fd8f6b97df69cdc56524abc906c50ef1d0bf091188616802e6c7c731389"),
-    "16.17.1-linux_amd64": ("node-v16.17.1-linux-x64.tar.xz", "node-v16.17.1-linux-x64", "06ba2eb34aa385967f5f58c87a44753f83212f6cccea892b33f80a2e7fda8384"),
-    "16.17.1-windows_amd64": ("node-v16.17.1-win-x64.zip", "node-v16.17.1-win-x64", "ed290151efb417262b9808a70738d4ab79e9d53653a6a9f4b8dd97912e279dce"),
+    "16.18.1-darwin_amd64": ("node-v16.18.1-darwin-x64.tar.gz", "node-v16.18.1-darwin-x64", "c190e106d4ac6177d1db3a5a739d39dd68bd276ba17f3d3c84039a93717e081e"),
+    "16.18.1-darwin_arm64": ("node-v16.18.1-darwin-arm64.tar.gz", "node-v16.18.1-darwin-arm64", "71720bb0a80cf158d8fdf492def08048befd953ad45e2458b1d095e32c612ba7"),
+    "16.18.1-linux_arm64": ("node-v16.18.1-linux-arm64.tar.xz", "node-v16.18.1-linux-arm64", "98d81a2d08f88646541d282b7ccc32429f8706ddcb30943fc3779ef9674ebb93"),
+    "16.18.1-linux_amd64": ("node-v16.18.1-linux-x64.tar.xz", "node-v16.18.1-linux-x64", "de2c694e7081c37022817d27a65b02f69ecf4c49699d65585e8e24431b7bc920"),
+    "16.18.1-windows_amd64": ("node-v16.18.1-win-x64.zip", "node-v16.18.1-win-x64", "db6a81de8e8ca3444495f1bcf04a883c076b4325d0fbaa032a190f88b38b30c5"),
   },
-  node_version = "16.17.1",
+  node_version = "16.18.1",
   node_urls = [
     "https://nodejs.org/dist/v{version}/{filename}",
   ],

docs/CHANGELOG.asciidoc

@@ -8,8 +8,9 @@
 :issue: https://github.com/elastic/kibana/issues/
 :pull: https://github.com/elastic/kibana/pull/
 
-Review important information about the {kib} 8.5.0 release.
+Review important information about the {kib} 8.5.x releases.
 
+* <<release-notes-8.5.1>>
 * <<release-notes-8.5.0>>
 //* <<release-notes-8.4.3>>
 //* <<release-notes-8.4.2>>
@@ -36,6 +37,68 @@ Review important information about the {kib} 8.5.0 release.
 //* <<release-notes-8.0.0-alpha1>>
 
 --
+
+[[release-notes-8.5.1]]
+== {kib} 8.5.1
+
+coming::[8.5.1]
+
+Review the following information about the {kib} 8.5.1 release.
+
+[float]
+[[breaking-changes-8.5.1]]
+=== Breaking changes
+
+Breaking changes can prevent your application from optimal operation and performance.
+Before you upgrade, review the breaking change, then mitigate the impact to your application.
+
+// tag::notable-breaking-changes[]
+There are no breaking changes in {kib} 8.5.1.
+// end::notable-breaking-changes[]
+
+{kibana-ref-all}/8.4/release-notes-8.4.0.html#breaking-changes-8.4.0[8.4.0] | {kibana-ref-all}/8.3/release-notes-8.3.0.html#breaking-changes-8.3.0[8.3.0] | {kibana-ref-all}/8.2/release-notes-8.2.0.html#breaking-changes-8.2.0[8.2.0] | {kibana-ref-all}/8.1/release-notes-8.1.0.html#breaking-changes-8.1.0[8.1.0] | {kibana-ref-all}/8.0/release-notes-8.0.0.html#breaking-changes-8.0.0[8.0.0] | {kibana-ref-all}/8.0/release-notes-8.0.0-rc2.html#breaking-changes-8.0.0-rc2[8.0.0-rc2] | {kibana-ref-all}/8.0/release-notes-8.0.0-rc1.html#breaking-changes-8.0.0-rc1[8.0.0-rc1] | {kibana-ref-all}/8.0/release-notes-8.0.0-beta1.html#breaking-changes-8.0.0-beta1[8.0.0-beta1] | {kibana-ref-all}/8.0/release-notes-8.0.0-alpha2.html#breaking-changes-8.0.0-alpha2[8.0.0-alpha2] | {kibana-ref-all}/8.0/release-notes-8.0.0-alpha1.html#breaking-changes-8.0.0-alpha1[8.0.0-alpha1]
+
+[float]
+[[enhancement-v8.5.1]]
+=== Enhancements
+Elastic Security::
+For the Elastic Security 8.5.1 release information, refer to {security-guide}/release-notes.html[_Elastic Security Solution Release Notes_].
+
+[float]
+[[fixes-v8.5.1]]
+=== Bug fixes
+APM::
+* Fixes a bug where Metadata API does not filter by environment {kibana-pull}144472[#144472]
+* Fixes a bug where AWS lambda checks for an undefined value {kibana-pull}143987[#143987]
+* Limits the number of source map artifacts {kibana-pull}144963[#144963]
+* Fixes an incorrect documentation link {kibana-pull}145077[#145077]
+
+Dashboard::
+* Removes support for scripted fields in options list {kibana-pull}144643[#144643]
+* Fixes help documentation link for dashboard {kibana-pull}143894[#143894]
+
+Elastic Security::
+For the Elastic Security 8.5.1 release information, refer to {security-guide}/release-notes.html[_Elastic Security Solution Release Notes_].
+
+Fleet::
+Make asset tags space aware {kibana-pull}144066[#144066]
+
+Machine Learning::
+* Correcting the size of the free ML node on cloud {kibana-pull}144512[#144512]
+* Fixes model testing flyout reload {kibana-pull}144318[#144318]
+* Explain Log Rate Spikes: Wrap analysis in try/catch block {kibana-pull}143651[#143651]
+* Explain Log Rate Spikes: Fix uncompressed streams and backpressure handling {kibana-pull}142970[#142970]
+
+Osquery::
+* Fixes a bug that prevented users from viewing Osquery results if they were in a non-default {kib} space {kibana-pull}144210[#144210]
+
+Platform::
+Fixes the execution pipeline not to stop on a flaky subexpression {kibana-pull}143852[#143852]
+
+Uptime::
+* Adjust forumla for synthetics monitor availability {kibana-pull}144868[#144868]
+* TLS alert - do not alert when status cannot be determined {kibana-pull}144767[#144767]
+
 [[release-notes-8.5.0]]
 == {kib} 8.5.0
 
@@ -57,7 +120,6 @@ To download the {kib} 8.5.0 image, use the https://www.docker.elastic.co/r/kiban
 Breaking changes can prevent your application from optimal operation and performance.
 Before you upgrade to 8.5.0, review the breaking changes, then mitigate the impact to your application.
 
-// tag::notable-breaking-changes[]
 [discrete]
 [[breaking-141757]]
 .Updates bulk action API to return actionId instead of agent success
@@ -93,7 +155,10 @@ The bidirectional foreign key between agent policy and package policy has been r
 *Impact* +
 The agent policy saved object no longer includes the `package_policies` field.
 ====
-// end::notable-breaking-changes[]
+
+To review the breaking changes in previous versions, refer to the following:
+
+{kibana-ref-all}/8.4/release-notes-8.4.0.html#breaking-changes-8.4.0[8.4.0] | {kibana-ref-all}/8.3/release-notes-8.3.0.html#breaking-changes-8.3.0[8.3.0] | {kibana-ref-all}/8.2/release-notes-8.2.0.html#breaking-changes-8.2.0[8.2.0] | {kibana-ref-all}/8.1/release-notes-8.1.0.html#breaking-changes-8.1.0[8.1.0] | {kibana-ref-all}/8.0/release-notes-8.0.0.html#breaking-changes-8.0.0[8.0.0] | {kibana-ref-all}/8.0/release-notes-8.0.0-rc2.html#breaking-changes-8.0.0-rc2[8.0.0-rc2] | {kibana-ref-all}/8.0/release-notes-8.0.0-rc1.html#breaking-changes-8.0.0-rc1[8.0.0-rc1] | {kibana-ref-all}/8.0/release-notes-8.0.0-beta1.html#breaking-changes-8.0.0-beta1[8.0.0-beta1] | {kibana-ref-all}/8.0/release-notes-8.0.0-alpha2.html#breaking-changes-8.0.0-alpha2[8.0.0-alpha2] | {kibana-ref-all}/8.0/release-notes-8.0.0-alpha1.html#breaking-changes-8.0.0-alpha1[8.0.0-alpha1]
 
 [float]
 [[features-8.5.0]]

docs/developer/advanced/upgrading-nodejs.asciidoc

@@ -17,7 +17,7 @@ These files must be updated when upgrading Node.js:
   - {kib-repo}blob/{branch}/WORKSPACE.bazel[`WORKSPACE.bazel`] - The version is specified in the `node_version` property.
     Besides this property, the list of files under `node_repositories` must be updated along with their respective SHA256 hashes.
     These can be found on the https://nodejs.org[nodejs.org] website.
-    Example for Node.js v16.17.1: https://nodejs.org/dist/v16.17.1/SHASUMS256.txt.asc
+    Example for Node.js v16.18.1: https://nodejs.org/dist/v16.18.1/SHASUMS256.txt.asc
 
 See PR {kib-repo}pull/128123[#128123] for an example of how the Node.js version has been upgraded previously.
 

docs/settings/fleet-settings.asciidoc

@@ -33,6 +33,9 @@ The address to use to reach the {package-manager} registry.
 The proxy address to use to reach the {package-manager} registry if an internet connection is not directly available.
 Refer to {fleet-guide}/air-gapped.html[Air-gapped environments] for details.
 
+`xpack.fleet.packageVerification.gpgKeyPath`::
+The path on disk to the GPG key used to verify {package-manager} packages. If the Elastic public key
+is ever reissued as a security precaution, you can use this setting to specify the new key.
 
 ==== {fleet} settings
 

docs/user/troubleshooting/using-server-logs.asciidoc

@@ -34,24 +34,24 @@ logging.loggers:
     level: debug
     appenders: [file]
 ----
-WARNING: Kibana's `file` appender is configured to produce logs in https://www.elastic.co/guide/en/ecs/master/ecs-reference.html[ECS JSON] format. It's the only format that includes the meta information necessary for https://www.elastic.co/guide/en/apm/agent/nodejs/current/log-correlation.html[log correlation] out-of-the-box.
+WARNING: Kibana's `file` appender is configured to produce logs in {ecs-ref}/ecs-reference.html[ECS JSON] format. It's the only format that includes the meta information necessary for {apm-node-ref}/log-correlation.html[log correlation] out-of-the-box.
 
 The next step is to define what https://www.elastic.co/observability[observability tools] are available. 
 For a better experience, set up an https://www.elastic.co/guide/en/apm/get-started/current/observability-integrations.html[Observability integration] provided by Elastic to debug your application with the <<debugging-logs-apm-ui, APM UI.>>
 To debug something quickly without setting up additional tooling, you can work with <<plain-kibana-logs, the plain {kib} logs.>>
 
 [[debugging-logs-apm-ui]]
 ==== APM UI
-*Prerequisites* {kib} logs are configured to be in https://www.elastic.co/guide/en/ecs/master/ecs-reference.html[ECS JSON] format to include tracing identifiers.
+*Prerequisites* {kib} logs are configured to be in {ecs-ref}/ecs-reference.html[ECS JSON] format to include tracing identifiers.
 
 To debug {kib} with the APM UI, you must set up the APM infrastructure. You can find instructions for the setup process
 https://www.elastic.co/guide/en/apm/get-started/current/observability-integrations.html[on the Observability integrations page].
 
-Once you set up the APM infrastructure, you can enable the APM agent and put {kib} under load to collect APM events. To analyze the collected metrics and logs, use the APM UI as demonstrated https://www.elastic.co/guide/en/kibana/master/transactions.html#transaction-trace-sample[in the docs].
+Once you set up the APM infrastructure, you can enable the APM agent and put {kib} under load to collect APM events. To analyze the collected metrics and logs, use the APM UI as demonstrated {kibana-ref}/transactions.html#transaction-trace-sample[in the docs].
 
 [[plain-kibana-logs]]
 ==== Plain {kib} logs
-*Prerequisites* {kib} logs are configured to be in https://www.elastic.co/guide/en/ecs/master/ecs-reference.html[ECS JSON] format to include tracing identifiers.
+*Prerequisites* {kib} logs are configured to be in {ecs-ref}/ecs-reference.html[ECS JSON] format to include tracing identifiers.
 
 Open {kib} Logs and search for an operation you are interested in.
 For example, suppose you want to investigate the response times for queries to the `/api/telemetry/v2/clusters/_stats` {kib} endpoint.

fleet_packages.json

@@ -37,6 +37,6 @@
   },
   {
     "name": "synthetics",
-    "version": "0.10.3"
+    "version": "0.11.2"
   }
-]
+]

package.json

@@ -69,7 +69,7 @@
     "url": "https://github.com/elastic/kibana.git"
   },
   "engines": {
-    "node": "16.17.1",
+    "node": "16.18.1",
     "yarn": "^1.22.19"
   },
   "resolutions": {
@@ -1133,7 +1133,7 @@
     "@types/kbn__yarn-lock-validator": "link:bazel-bin/packages/kbn-yarn-lock-validator/npm_module_types",
     "@types/license-checker": "15.0.0",
     "@types/listr": "^0.14.0",
-    "@types/loader-utils": "^1.1.3",
+    "@types/loader-utils": "^2.0.3",
     "@types/lodash": "^4.14.159",
     "@types/lru-cache": "^5.1.0",
     "@types/lz-string": "^1.3.34",
@@ -1184,7 +1184,7 @@
     "@types/redux-logger": "^3.0.8",
     "@types/resolve": "^1.20.1",
     "@types/seedrandom": ">=2.0.0 <4.0.0",
-    "@types/selenium-webdriver": "^4.1.5",
+    "@types/selenium-webdriver": "^4.1.6",
     "@types/semver": "^7",
     "@types/set-value": "^2.0.0",
     "@types/sharp": "^0.30.4",
@@ -1240,7 +1240,7 @@
     "callsites": "^3.1.0",
     "chance": "1.0.18",
     "chokidar": "^3.5.3",
-    "chromedriver": "^107.0.0",
+    "chromedriver": "^107.0.2",
     "clean-webpack-plugin": "^3.0.0",
     "compression-webpack-plugin": "^4.0.0",
     "copy-webpack-plugin": "^6.0.2",
@@ -1290,7 +1290,7 @@
     "fetch-mock": "^7.3.9",
     "file-loader": "^4.2.0",
     "form-data": "^4.0.0",
-    "geckodriver": "^3.0.2",
+    "geckodriver": "^3.2.0",
     "gulp-brotli": "^3.0.0",
     "gulp-postcss": "^9.0.1",
     "gulp-sourcemaps": "2.6.5",
@@ -1324,7 +1324,7 @@
     "license-checker": "^25.0.1",
     "listr": "^0.14.1",
     "lmdb-store": "^1.6.11",
-    "loader-utils": "^1.2.3",
+    "loader-utils": "^2.0.3",
     "marge": "^1.0.1",
     "micromatch": "^4.0.5",
     "mini-css-extract-plugin": "1.1.0",
@@ -1363,7 +1363,7 @@
     "resolve": "^1.22.0",
     "rxjs-marbles": "^7.0.1",
     "sass-loader": "^10.3.1",
-    "selenium-webdriver": "^4.4.0",
+    "selenium-webdriver": "^4.5.0",
     "simple-git": "^3.10.0",
     "sinon": "^7.4.2",
     "sort-package-json": "^1.53.1",

packages/kbn-optimizer/src/worker/theme_loader.ts

@@ -20,7 +20,7 @@ export default function (this: webpack.loader.LoaderContext) {
   this.cacheable(true);
 
   const options = getOptions(this);
-  const bundleId: string = options.bundleId!;
+  const bundleId = options.bundleId as string;
   const themeTags = parseThemeTags(options.themeTags);
 
   const cases = ALL_THEMES.map((tag) => {

src/plugins/console/public/lib/autocomplete/components/component_template_autocomplete_component.js

@@ -6,12 +6,18 @@
  * Side Public License, v 1.
  */
 
-import { getAutocompleteInfo } from '../../../services';
+import { getAutocompleteInfo, ENTITIES } from '../../../services';
 import { ListComponent } from './list_component';
 
 export class ComponentTemplateAutocompleteComponent extends ListComponent {
   constructor(name, parent) {
-    super(name, getAutocompleteInfo().getEntityProvider('componentTemplates'), parent, true, true);
+    super(
+      name,
+      getAutocompleteInfo().getEntityProvider(ENTITIES.COMPONENT_TEMPLATES),
+      parent,
+      true,
+      true
+    );
   }
 
   getContextKey() {

src/plugins/console/public/lib/autocomplete/components/data_stream_autocomplete_component.js

@@ -7,11 +7,16 @@
  */
 
 import { ListComponent } from './list_component';
-import { getAutocompleteInfo } from '../../../services';
+import { getAutocompleteInfo, ENTITIES } from '../../../services';
 
 export class DataStreamAutocompleteComponent extends ListComponent {
   constructor(name, parent, multiValued) {
-    super(name, getAutocompleteInfo().getEntityProvider('dataStreams'), parent, multiValued);
+    super(
+      name,
+      getAutocompleteInfo().getEntityProvider(ENTITIES.DATA_STREAMS),
+      parent,
+      multiValued
+    );
   }
 
   getContextKey() {

src/plugins/console/public/lib/autocomplete/components/field_autocomplete_component.js

@@ -7,11 +7,11 @@
  */
 
 import _ from 'lodash';
-import { getAutocompleteInfo } from '../../../services';
+import { getAutocompleteInfo, ENTITIES } from '../../../services';
 import { ListComponent } from './list_component';
 
 function FieldGenerator(context) {
-  return _.map(getAutocompleteInfo().getEntityProvider('fields', context), function (field) {
+  return _.map(getAutocompleteInfo().getEntityProvider(ENTITIES.FIELDS, context), function (field) {
     return { name: field.name, meta: field.type };
   });
 }

src/plugins/console/public/lib/autocomplete/components/index_autocomplete_component.js

@@ -7,7 +7,7 @@
  */
 
 import _ from 'lodash';
-import { getAutocompleteInfo } from '../../../services';
+import { getAutocompleteInfo, ENTITIES } from '../../../services';
 import { ListComponent } from './list_component';
 
 function nonValidIndexType(token) {
@@ -16,7 +16,7 @@ function nonValidIndexType(token) {
 
 export class IndexAutocompleteComponent extends ListComponent {
   constructor(name, parent, multiValued) {
-    super(name, getAutocompleteInfo().getEntityProvider('indices'), parent, multiValued);
+    super(name, getAutocompleteInfo().getEntityProvider(ENTITIES.INDICES), parent, multiValued);
   }
   validateTokens(tokens) {
     if (!this.multiValued && tokens.length > 1) {

src/plugins/console/public/lib/autocomplete/components/index_template_autocomplete_component.js

@@ -6,12 +6,18 @@
  * Side Public License, v 1.
  */
 
-import { getAutocompleteInfo } from '../../../services';
+import { getAutocompleteInfo, ENTITIES } from '../../../services';
 import { ListComponent } from './list_component';
 
 export class IndexTemplateAutocompleteComponent extends ListComponent {
   constructor(name, parent) {
-    super(name, getAutocompleteInfo().getEntityProvider('indexTemplates'), parent, true, true);
+    super(
+      name,
+      getAutocompleteInfo().getEntityProvider(ENTITIES.INDEX_TEMPLATES),
+      parent,
+      true,
+      true
+    );
   }
 
   getContextKey() {

src/plugins/console/public/lib/autocomplete/components/username_autocomplete_component.js

@@ -7,7 +7,7 @@
  */
 
 import _ from 'lodash';
-import { getAutocompleteInfo } from '../../../services';
+import { getAutocompleteInfo, ENTITIES } from '../../../services';
 import { ListComponent } from './list_component';
 
 function nonValidUsernameType(token) {
@@ -16,7 +16,7 @@ function nonValidUsernameType(token) {
 
 export class UsernameAutocompleteComponent extends ListComponent {
   constructor(name, parent, multiValued) {
-    super(name, getAutocompleteInfo().getEntityProvider('indices'), parent, multiValued);
+    super(name, getAutocompleteInfo().getEntityProvider(ENTITIES.INDICES), parent, multiValued);
   }
   validateTokens(tokens) {
     if (!this.multiValued && tokens.length > 1) {

src/plugins/console/public/lib/autocomplete_entities/types.ts

@@ -29,7 +29,7 @@ export interface FieldMapping {
   fields?: FieldMapping[];
 }
 
-export interface MappingsApiResponse {
+export interface AutoCompleteEntitiesApiResponse {
   mappings: IndicesGetMappingResponse;
   aliases: IndicesGetAliasResponse;
   dataStreams: IndicesGetDataStreamResponse;