Skip to content

Commit

Permalink
remove inessential differences
Browse files Browse the repository at this point in the history
  • Loading branch information
tsullivan committed Oct 23, 2024
1 parent 97d4836 commit 8e4ee0f
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ export default function ({ getService }: FtrProviderContext) {
const svlCommonApi = getService('svlCommonApi');
const supertestWithoutAuth = getService('supertestWithoutAuth');
const svlUserManager = getService('svlUserManager');
let roleAuthc: RoleCredentials;
const samlAuth = getService('samlAuth');
let roleAuthc: RoleCredentials;
let cookieCredentials: CookieCredentials;
let internalReqHeader: InternalRequestHeader;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export default ({ getService }: FtrProviderContext) => {
},
};

describe('Management: Deletion', function () {
describe('Reporting Management', function () {
let reportJob: ReportApiJSON;
let path: string;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
});
};

describe('Management: listing', function () {
describe('Reporting Management app', function () {
// security_exception: action [indices:admin/create] is unauthorized for user [elastic] with effective roles [superuser] on restricted indices [.reporting-2020.04.19], this action is granted by the index privileges [create_index,manage,all]
this.tags('failsOnMKI');

Expand All @@ -59,7 +59,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
};

// Kibana CI and MKI use different users
before(async () => {
before('initialize saved object archive', async () => {
cookieCredentials = await samlAuth.getM2MApiCookieCredentialsWithRoleScope('admin');
internalReqHeader = samlAuth.getInternalRequestHeader();
// add test saved search object
Expand All @@ -77,7 +77,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
reportJob = result.job;
});

after(async () => {
after('clean up archives', async () => {
await kibanaServer.importExport.unload(savedObjectsArchive);
await reportingAPI.waitForJobToFinish(path, cookieCredentials, internalReqHeader);
});
Expand Down
1 change: 0 additions & 1 deletion x-pack/test_serverless/shared/services/svl_reporting.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ export function SvlReportingServiceProvider({ getService }: FtrProviderContext)
internalReqHeader: InternalRequestHeader,
options?: { timeout?: number }
) {
log.debug(`ReportingAPI.waitForJobToFinish ${downloadReportPath}`);
await retry.waitForWithTimeout(
`job ${downloadReportPath} finished`,
options?.timeout ?? config.get('timeouts.kibanaReportCompletion'),
Expand Down

0 comments on commit 8e4ee0f

Please sign in to comment.