Renamed 'setUserMenuLinks' to 'addUserMenuLinks' in nav control service

elastic · Nov 5, 2020 · 8d706f2 · 8d706f2
1 parent b45467b
commit 8d706f2
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/x-pack/plugins/cloud/public/plugin.ts b/x-pack/plugins/cloud/public/plugin.ts
@@ -77,7 +77,7 @@ export class CloudPlugin implements Plugin<CloudSetup> {
 
     if (security && this.isCloudEnabled) {
       const userMenuLinks = createUserMenuLinks(this.config);
-      security.navControlService.setUserMenuLinks(userMenuLinks);
+      security.navControlService.addUserMenuLinks(userMenuLinks);
     }
   }
 }
diff --git a/x-pack/plugins/security/public/nav_control/index.mock.ts b/x-pack/plugins/security/public/nav_control/index.mock.ts
@@ -9,6 +9,6 @@ import { SecurityNavControlServiceStart } from '.';
 export const navControlServiceMock = {
   createStart: (): jest.Mocked<SecurityNavControlServiceStart> => ({
     getUserMenuLinks$: jest.fn(),
-    setUserMenuLinks: jest.fn(),
+    addUserMenuLinks: jest.fn(),
   }),
 };
diff --git a/x-pack/plugins/security/public/nav_control/nav_control_service.tsx b/x-pack/plugins/security/public/nav_control/nav_control_service.tsx
@@ -35,7 +35,7 @@ export interface SecurityNavControlServiceStart {
   /**
    * Registers the provided user menu links to be displayed in the user menu in the global nav
    */
-  setUserMenuLinks: (newUserMenuLink: UserMenuLink[]) => void;
+  addUserMenuLinks: (newUserMenuLink: UserMenuLink[]) => void;
 }
 
 export class SecurityNavControlService {
@@ -72,7 +72,7 @@ export class SecurityNavControlService {
     return {
       getUserMenuLinks$: () =>
         this.userMenuLinks$.pipe(map(this.sortUserMenuLinks), takeUntil(this.stop$)),
-      setUserMenuLinks: (userMenuLink: UserMenuLink[]) => {
+      addUserMenuLinks: (userMenuLink: UserMenuLink[]) => {
         this.userMenuLinks$.next(userMenuLink);
       },
     };

diff --git a/x-pack/plugins/security/public/plugin.test.tsx b/x-pack/plugins/security/public/plugin.test.tsx
@@ -100,7 +100,7 @@ describe('Security Plugin', () => {
       ).toEqual({
         navControlService: {
           getUserMenuLinks$: expect.any(Function),
-          setUserMenuLinks: expect.any(Function),
+          addUserMenuLinks: expect.any(Function),
         },
       });
     });