Skip to content

Commit

Permalink
[Discover] Remove the comment
Browse files Browse the repository at this point in the history
  • Loading branch information
jughosta committed Aug 11, 2023
1 parent c8728d4 commit 8d63088
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions packages/kbn-generate-csv/src/generate_csv.ts
Original file line number Diff line number Diff line change
Expand Up @@ -356,9 +356,6 @@ export class CsvGenerator {
// set the latest pit, which could be different from the last request
searchSource.setField('pit', { id: pitId, keep_alive: settings.scroll.duration });

// TODO: should we skip `_doc` (the tie breaker from Discover) from searchSource `sort` field when generating CSV?
// According to docs, the default `_shard_doc` is a better option when PIT is used.

const results = await this.doSearch(searchSource, settings, searchAfter);

const { hits } = results;
Expand Down

0 comments on commit 8d63088

Please sign in to comment.