Fix type errors

elastic · Apr 8, 2021 · 8bbf023 · 8bbf023
1 parent d3fbe43
commit 8bbf023
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/...lugins/enterprise_search/public/applications/app_search/components/result/result.test.tsx b/...lugins/enterprise_search/public/applications/app_search/components/result/result.test.tsx
@@ -10,7 +10,7 @@ import { DraggableProvidedDragHandleProps } from 'react-beautiful-dnd';
 
 import { shallow, ShallowWrapper } from 'enzyme';
 
-import { EuiButtonIcon, EuiPanel } from '@elastic/eui';
+import { EuiButtonIcon, EuiPanel, EuiButtonIconColor } from '@elastic/eui';
 
 import { SchemaTypes } from '../../../shared/types';
 
@@ -83,13 +83,13 @@ describe('Result', () => {
         title: 'Hide',
         onClick: jest.fn(),
         iconType: 'eyeClosed',
-        iconColor: 'danger',
+        iconColor: 'danger' as EuiButtonIconColor,
       },
       {
         title: 'Bookmark',
         onClick: jest.fn(),
         iconType: 'starFilled',
-        iconColor: '',
+        iconColor: undefined,
       },
     ];
 

diff --git a/...gins/enterprise_search/public/applications/app_search/components/result/result_header.tsx b/...gins/enterprise_search/public/applications/app_search/components/result/result_header.tsx
@@ -22,15 +22,15 @@ interface Props {
   isMetaEngine: boolean;
   resultMeta: ResultMeta;
   actions?: React.ReactNode;
-  shouldLinkToDetailPage: boolean;
+  shouldLinkToDetailPage?: boolean;
 }
 
 export const ResultHeader: React.FC<Props> = ({
   showScore,
   resultMeta,
   isMetaEngine,
   actions,
-  shouldLinkToDetailPage,
+  shouldLinkToDetailPage = false,
 }) => {
   const documentLink = generateEncodedPath(ENGINE_DOCUMENT_DETAIL_PATH, {
     engineName: resultMeta.engine,
@@ -49,7 +49,6 @@ export const ResultHeader: React.FC<Props> = ({
             type="id"
           />
         </EuiFlexItem>
-        {/* Score */}
         {showScore && (
           <EuiFlexItem grow={false}>
             <ResultHeaderItem