Revert unnecessary version fields in tests, fix schema

elastic · Jul 3, 2020 · 8a83e27 · 8a83e27
1 parent 87e6362
commit 8a83e27
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 6 deletions.
diff --git a/x-pack/plugins/ingest_manager/common/services/package_configs_to_agent_inputs.test.ts b/x-pack/plugins/ingest_manager/common/services/package_configs_to_agent_inputs.test.ts
@@ -21,7 +21,6 @@ describe('Ingest Manager - storedPackageConfigsToAgentInputs', () => {
     namespace: 'default',
     inputs: [],
     revision: 1,
-    version: '',
   };
 
   const mockInput: PackageConfigInput = {

diff --git a/x-pack/plugins/ingest_manager/server/routes/package_config/handlers.test.ts b/x-pack/plugins/ingest_manager/server/routes/package_config/handlers.test.ts
@@ -30,7 +30,6 @@ jest.mock('../../services/package_config', (): {
           ...newData,
           id: '1',
           revision: 1,
-          version: 'xxxx',
           updated_at: new Date().toISOString(),
           updated_by: 'elastic',
           created_at: new Date().toISOString(),

diff --git a/x-pack/plugins/ingest_manager/server/types/models/package_config.ts b/x-pack/plugins/ingest_manager/server/types/models/package_config.ts
@@ -68,11 +68,11 @@ export const NewPackageConfigSchema = schema.object({
 
 export const UpdatePackageConfigSchema = schema.object({
   ...PackageConfigBaseSchema,
-  version: schema.string(),
+  version: schema.maybe(schema.string()),
 });
 
 export const PackageConfigSchema = schema.object({
   ...PackageConfigBaseSchema,
   id: schema.string(),
-  version: schema.string(),
+  version: schema.maybe(schema.string()),
 });
diff --git a/x-pack/plugins/security_solution/common/endpoint/generate_data.ts b/x-pack/plugins/security_solution/common/endpoint/generate_data.ts
@@ -1054,7 +1054,6 @@ export class EndpointDocGenerator {
         version: '1.0.0',
       },
       revision: 1,
-      version: 'xxxx',
     };
   }
 

diff --git a/...ugins/security_solution/public/management/pages/policy/store/policy_details/index.test.ts b/...ugins/security_solution/public/management/pages/policy/store/policy_details/index.test.ts
@@ -61,7 +61,6 @@ describe('policy details: ', () => {
             version: '',
           },
           revision: 1,
-          version: 'xxxx',
         },
       },
     });
-Original file line number
+Diff line change
@@ Expand Up / @@ -1054,7 +1054,6 @@ export class EndpointDocGenerator { @@
             version: '1.0.0',
           },
           revision: 1,
-          version: 'xxxx',
         };
       }
@@ Expand Down @@