Skip to content

Commit

Permalink
Upgrade EUI to v74.0.1 (#149457)
Browse files Browse the repository at this point in the history
## Summary

`[email protected]` ⏩ `[email protected]`

---

## [`74.0.1`](https://github.com/elastic/eui/tree/v74.0.1)

**Bug fixes**

- Fixed `EuiModalHeaderTitle` type errors when passed `EuiTitle` props
([#6547](elastic/eui#6547))

## [`74.0.0`](https://github.com/elastic/eui/tree/v74.0.0)

- Added the `component` prop to `EuiModalHeaderTitle`, which allows
overriding the default `h1` tag
([#6530](elastic/eui#6530))
- Added the `titleProps` prop to `EuiConfirmModal`, which allows
overriding the default `h1` tag
([#6530](elastic/eui#6530))

**Bug fixes**

- Fixed slight row height jumping in `EuiBasicTable`s when actions with
tooltips became disabled
([#6538](elastic/eui#6538))

**Breaking changes**

- `EuiModalHeaderTitle` now **always** wraps its children in a `h1` tag
(previously attempted to conditionally detect whether its children were
raw strings or not). To change this tag type to, e.g. a more generic
`div`, use the new `component` prop.
([#6530](elastic/eui#6530))
- `EuiLink` now applies `rel="noreferrer"` to all domains, including
`elastic.co` ([#6535](elastic/eui#6535))
- `EuiBasicTable` no longer blocks mouse/keyboard interactions while
`loading` ([#6543](elastic/eui#6543))

**CSS-in-JS conversions**

- Converted `EuiBasicTable` to Emotion
([#6539](elastic/eui#6539))
- Added a new `RenderWithEuiTheme` render prop utility
([#6539](elastic/eui#6539))

---------

Co-authored-by: Kibana Machine <[email protected]>
  • Loading branch information
cee-chen and kibanamachine authored Jan 27, 2023
1 parent d7c62f3 commit 8a2ecc3
Show file tree
Hide file tree
Showing 76 changed files with 377 additions and 464 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@
"@elastic/datemath": "5.0.3",
"@elastic/elasticsearch": "npm:@elastic/[email protected]",
"@elastic/ems-client": "8.4.0",
"@elastic/eui": "73.0.0",
"@elastic/eui": "74.0.1",
"@elastic/filesaver": "1.1.2",
"@elastic/node-crypto": "1.2.1",
"@elastic/numeral": "^2.5.1",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const EditModalComponent: FC<EditModalProps> = ({ listDetails, onSave, onCancel
)}
<EuiModalHeader>
<EuiModalHeaderTitle data-test-subj="editModalTitle">
<h1>{i18n.EXCEPTION_LIST_HEADER_EDIT_MODAL_TITLE(listDetails.name)}</h1>
{i18n.EXCEPTION_LIST_HEADER_EDIT_MODAL_TITLE(listDetails.name)}
</EuiModalHeaderTitle>
</EuiModalHeader>

Expand Down
2 changes: 1 addition & 1 deletion src/dev/license_checker/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,6 @@ export const LICENSE_OVERRIDES = {
'[email protected]': ['Eclipse Distribution License - v 1.0'], // cf. https://github.com/bjornharrtell/jsts
'@mapbox/[email protected]': ['MIT'], // license in readme https://github.com/tmcw/jsonlint
'@elastic/[email protected]': ['Elastic License 2.0'],
'@elastic/eui@73.0.0': ['SSPL-1.0 OR Elastic License 2.0'],
'@elastic/eui@74.0.1': ['SSPL-1.0 OR Elastic License 2.0'],
'[email protected]': ['CC-BY-4.0'], // retired ODC‑By license https://github.com/mattcg/language-subtag-registry
};
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,8 @@ export function CopyToDashboardModal({
>
<PresentationUtilContext>
<EuiModalHeader>
<EuiModalHeaderTitle>
<h2 id={titleId}>{dashboardCopyToDashboardActionStrings.getDisplayName()}</h2>
<EuiModalHeaderTitle id={titleId} component="h2">
{dashboardCopyToDashboardActionStrings.getDisplayName()}
</EuiModalHeaderTitle>
</EuiModalHeader>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ export const confirmCreateWithUnsaved = (
aria-describedby={descriptionId}
>
<EuiModalHeader data-test-subj="dashboardCreateConfirm">
<EuiModalHeaderTitle>
<h2 id={titleId}>{createConfirmStrings.getCreateTitle()}</h2>
<EuiModalHeaderTitle id={titleId} component="h2">
{createConfirmStrings.getCreateTitle()}
</EuiModalHeaderTitle>
</EuiModalHeader>

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -297,12 +297,10 @@ export const getConflictModalContent = ({
<>
<EuiModalHeader>
<EuiModalHeaderTitle>
<h1>
<FormattedMessage
id="indexPatternManagement.editIndexPattern.fields.conflictModal.title"
defaultMessage="This field has a type conflict"
/>
</h1>
<FormattedMessage
id="indexPatternManagement.editIndexPattern.fields.conflictModal.title"
defaultMessage="This field has a type conflict"
/>
</EuiModalHeaderTitle>
</EuiModalHeader>
<EuiModalBody>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,12 @@ export class CustomizePanelModal extends Component<CustomizePanelProps, State> {
}}
>
<EuiModalHeader>
<EuiModalHeaderTitle data-test-subj="customizePanelTitle">
<h2 id={titleId}>Customize panel</h2>
<EuiModalHeaderTitle
data-test-subj="customizePanelTitle"
id={titleId}
component="h2"
>
Customize panel
</EuiModalHeaderTitle>
</EuiModalHeader>

Expand Down
9 changes: 1 addition & 8 deletions src/plugins/kibana_react/public/markdown/markdown.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ test('should render links with parentheses correctly', () => {
);
});

test('should add `noreferrer` and `nooopener` to unknown links in new tabs', () => {
test('should add `noreferrer` and `nooopener` to all links in new tabs', () => {
const component = shallow(
<Markdown
openLinksInNewTab={true}
Expand All @@ -42,13 +42,6 @@ test('should add `noreferrer` and `nooopener` to unknown links in new tabs', ()
expect(component.render().find('a').prop('rel')).toBe('noopener noreferrer');
});

test('should only add `nooopener` to known links in new tabs', () => {
const component = shallow(
<Markdown openLinksInNewTab={true} markdown="[link](https://www.elastic.co/cool/path" />
);
expect(component.render().find('a').prop('rel')).toBe('noopener');
});

describe('props', () => {
const markdown = 'I am *some* [content](https://en.wikipedia.org/wiki/Content) with `markdown`';

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -135,13 +135,11 @@ export class SavedObjectSaveModal extends React.Component<Props, SaveModalState>
>
<EuiModalHeader>
<EuiModalHeaderTitle>
<h1>
<FormattedMessage
id="savedObjects.saveModal.saveTitle"
defaultMessage="Save {objectType}"
values={{ objectType: this.props.objectType }}
/>
</h1>
<FormattedMessage
id="savedObjects.saveModal.saveTitle"
defaultMessage="Save {objectType}"
values={{ objectType: this.props.objectType }}
/>
</EuiModalHeaderTitle>
</EuiModalHeader>

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,10 @@ export default class ApplyFiltersPopoverContent extends Component<Props, State>
<React.Fragment>
<EuiModalHeader>
<EuiModalHeaderTitle>
<h1>
<FormattedMessage
id="unifiedSearch.filter.applyFilters.popupHeader"
defaultMessage="Select filters to apply"
/>
</h1>
<FormattedMessage
id="unifiedSearch.filter.applyFilters.popupHeader"
defaultMessage="Select filters to apply"
/>
</EuiModalHeaderTitle>
</EuiModalHeader>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,12 @@ export default function TextBasedLanguagesTransitionModal({
<EuiModal onClose={() => setIsTextLangTransitionModalVisible(false)} style={{ width: 700 }}>
<EuiModalHeader>
<EuiModalHeaderTitle>
<h1>
{i18n.translate(
'unifiedSearch.query.queryBar.indexPattern.textBasedLanguagesTransitionModalTitle',
{
defaultMessage: 'Your query will be removed',
}
)}
</h1>
{i18n.translate(
'unifiedSearch.query.queryBar.indexPattern.textBasedLanguagesTransitionModalTitle',
{
defaultMessage: 'Your query will be removed',
}
)}
</EuiModalHeaderTitle>
</EuiModalHeader>

Expand Down
Loading

0 comments on commit 8a2ecc3

Please sign in to comment.