PR feedback

elastic · Aug 23, 2023 · 878b0f2 · 878b0f2
1 parent f69b714
commit 878b0f2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/x-pack/plugins/cases/public/components/all_cases/translations.ts b/x-pack/plugins/cases/public/components/all_cases/translations.ts
@@ -31,18 +31,18 @@ export const SHOWING_SELECTED_CASES = (totalRules: number) =>
     defaultMessage: 'Selected {totalRules} {totalRules, plural, =1 {case} other {cases}}',
   });
 
-export const SHOWING_CASES = (totalCases: number, pageSize: number) =>
-  i18n.translate('xpack.cases.caseTable.showingCasesTitle', {
-    values: { totalCases, pageSize },
+export const SHOWING_CASES = (totalRules: number, pageSize: number) =>
+  i18n.translate('xpack.cases.caseTable.showingCases', {
+    values: { totalRules, pageSize },
     defaultMessage:
-      'Showing {pageSize} of {totalCases} {totalCases, plural, =1 {case} other {cases}}',
+      'Showing {pageSize} of {totalRules} {totalRules, plural, =1 {case} other {cases}}',
   });
 
-export const MAX_CASES = (totalCases: number) =>
+export const MAX_CASES = (maxCases: number) =>
   i18n.translate('xpack.cases.caseTable.maxCases', {
-    values: { totalCases },
+    values: { maxCases },
     defaultMessage:
-      'The results were capped at {totalCases} to maintain performance. Try limiting your search to reduce the results.',
+      'The results were capped at {maxCases} to maintain performance. Try limiting your search to reduce the results.',
   });
 
 export const DISMISS = i18n.translate('xpack.cases.caseTable.dismiss', {

diff --git a/x-pack/plugins/cases/public/components/all_cases/utility_bar.tsx b/x-pack/plugins/cases/public/components/all_cases/utility_bar.tsx
@@ -97,7 +97,7 @@ export const CasesTableUtilityBar: FunctionComponent<Props> = React.memo(
               margin-top: 4px;
             `}
           >
-            {i18n.MAX_CASES(totalCases)}
+            {i18n.MAX_CASES(MAX_DOCS_PER_PAGE)}
           </EuiText>
         </EuiFlexItem>
         <EuiFlexItem grow={false}>
@@ -203,7 +203,7 @@ export const CasesTableUtilityBar: FunctionComponent<Props> = React.memo(
         </EuiFlexGroup>
         {modals}
         {flyouts}
-        {hasReachedMaxCases && !isMessageDismissed && !isDoNotShowAgainSelected ? (
+        {hasReachedMaxCases && !isMessageDismissed && !isDoNotShowAgainSelected && (
           <>
             <EuiSpacer size="m" />
             <EuiFlexGroup>
@@ -218,7 +218,7 @@ export const CasesTableUtilityBar: FunctionComponent<Props> = React.memo(
             </EuiFlexGroup>
             <EuiSpacer size="m" />
           </>
-        ) : null}
+        )}
       </>
     );
   }