[Security Solution] [Sourcerer] Jest beef up (#79907)

elastic · Oct 12, 2020 · 87715a2 · 87715a2
1 parent 5e79523
commit 87715a2
Show file tree

Hide file tree

Showing 8 changed files with 303 additions and 224 deletions.
diff --git a/x-pack/plugins/security_solution/public/common/components/sourcerer/index.test.tsx b/x-pack/plugins/security_solution/public/common/components/sourcerer/index.test.tsx
@@ -7,7 +7,7 @@
 import React from 'react';
 import { mount } from 'enzyme';
 import { SourcererScopeName } from '../../store/sourcerer/model';
-import { SourcererComponent } from './index';
+import { Sourcerer } from './index';
 import { DEFAULT_INDEX_PATTERN } from '../../../../common/constants';
 import { sourcererActions, sourcererModel } from '../../store/sourcerer';
 import {
@@ -75,7 +75,7 @@ describe('Sourcerer component', () => {
   it('Mounts with all options selected', () => {
     const wrapper = mount(
       <TestProviders store={store}>
-        <SourcererComponent {...defaultProps} />
+        <Sourcerer {...defaultProps} />
       </TestProviders>
     );
     wrapper.find(`[data-test-subj="sourcerer-trigger"]`).first().simulate('click');
@@ -108,7 +108,7 @@ describe('Sourcerer component', () => {
     );
     const wrapper = mount(
       <TestProviders store={store}>
-        <SourcererComponent {...defaultProps} />
+        <Sourcerer {...defaultProps} />
       </TestProviders>
     );
     wrapper.find(`[data-test-subj="sourcerer-trigger"]`).first().simulate('click');
@@ -119,19 +119,21 @@ describe('Sourcerer component', () => {
   it('onChange calls updateSourcererScopeIndices', async () => {
     const wrapper = mount(
       <TestProviders store={store}>
-        <SourcererComponent {...defaultProps} />
+        <Sourcerer {...defaultProps} />
       </TestProviders>
     );
-    expect(true).toBeTruthy();
     wrapper.find(`[data-test-subj="sourcerer-trigger"]`).first().simulate('click');
-
+    expect(
+      wrapper.find(`[data-test-subj="sourcerer-popover"]`).first().prop('isOpen')
+    ).toBeTruthy();
     await waitFor(() => {
       ((wrapper.find(EuiComboBox).props() as unknown) as {
         onChange: (a: EuiComboBoxOptionOption[]) => void;
       }).onChange([mockOptions[0], mockOptions[1]]);
       wrapper.update();
     });
     wrapper.find(`[data-test-subj="add-index"]`).first().simulate('click');
+    expect(wrapper.find(`[data-test-subj="sourcerer-popover"]`).first().prop('isOpen')).toBeFalsy();
 
     expect(mockDispatch).toHaveBeenCalledWith(
       sourcererActions.setSelectedIndexPatterns({
@@ -140,4 +142,110 @@ describe('Sourcerer component', () => {
       })
     );
   });
+  it('resets to config index patterns', async () => {
+    store = createStore(
+      {
+        ...state,
+        sourcerer: {
+          ...state.sourcerer,
+          kibanaIndexPatterns: [{ id: '1234', title: 'auditbeat-*' }],
+          configIndexPatterns: ['packetbeat-*'],
+        },
+      },
+      SUB_PLUGINS_REDUCER,
+      apolloClientObservable,
+      kibanaObservable,
+      storage
+    );
+    const wrapper = mount(
+      <TestProviders store={store}>
+        <Sourcerer {...defaultProps} />
+      </TestProviders>
+    );
+    wrapper.find(`[data-test-subj="sourcerer-trigger"]`).first().simulate('click');
+    expect(wrapper.find(`[data-test-subj="config-option"]`).first().exists()).toBeFalsy();
+    wrapper
+      .find(
+        `[data-test-subj="indexPattern-switcher"] [title="packetbeat-*"] button.euiBadge__iconButton`
+      )
+      .first()
+      .simulate('click');
+    expect(wrapper.find(`[data-test-subj="config-option"]`).first().exists()).toBeTruthy();
+    wrapper.find(`[data-test-subj="sourcerer-reset"]`).first().simulate('click');
+    expect(wrapper.find(`[data-test-subj="config-option"]`).first().exists()).toBeFalsy();
+  });
+  it('returns index pattern options for kibanaIndexPatterns and configIndexPatterns', () => {
+    store = createStore(
+      {
+        ...state,
+        sourcerer: {
+          ...state.sourcerer,
+          kibanaIndexPatterns: [{ id: '1234', title: 'auditbeat-*' }],
+          configIndexPatterns: ['packetbeat-*'],
+        },
+      },
+      SUB_PLUGINS_REDUCER,
+      apolloClientObservable,
+      kibanaObservable,
+      storage
+    );
+    const wrapper = mount(
+      <TestProviders store={store}>
+        <Sourcerer {...defaultProps} />
+      </TestProviders>
+    );
+    wrapper.find(`[data-test-subj="sourcerer-trigger"]`).first().simulate('click');
+    expect(wrapper.find(`[data-test-subj="config-option"]`).first().exists()).toBeFalsy();
+    wrapper
+      .find(
+        `[data-test-subj="indexPattern-switcher"] [title="auditbeat-*"] button.euiBadge__iconButton`
+      )
+      .first()
+      .simulate('click');
+    wrapper.update();
+    expect(wrapper.find(`[data-test-subj="kip-option"]`).first().text()).toEqual(' auditbeat-*');
+    wrapper
+      .find(
+        `[data-test-subj="indexPattern-switcher"] [title="packetbeat-*"] button.euiBadge__iconButton`
+      )
+      .first()
+      .simulate('click');
+    wrapper.update();
+    expect(wrapper.find(`[data-test-subj="config-option"]`).first().text()).toEqual('packetbeat-*');
+  });
+  it('combines index pattern options for kibanaIndexPatterns and configIndexPatterns', () => {
+    store = createStore(
+      {
+        ...state,
+        sourcerer: {
+          ...state.sourcerer,
+          kibanaIndexPatterns: [
+            { id: '1234', title: 'auditbeat-*' },
+            { id: '5678', title: 'packetbeat-*' },
+          ],
+          configIndexPatterns: ['packetbeat-*'],
+        },
+      },
+      SUB_PLUGINS_REDUCER,
+      apolloClientObservable,
+      kibanaObservable,
+      storage
+    );
+    const wrapper = mount(
+      <TestProviders store={store}>
+        <Sourcerer {...defaultProps} />
+      </TestProviders>
+    );
+    wrapper.find(`[data-test-subj="sourcerer-trigger"]`).first().simulate('click');
+    wrapper
+      .find(
+        `[data-test-subj="indexPattern-switcher"] [title="packetbeat-*"] button.euiBadge__iconButton`
+      )
+      .first()
+      .simulate('click');
+    wrapper.update();
+    expect(
+      wrapper.find(`[title="packetbeat-*"] [data-test-subj="kip-option"]`).first().text()
+    ).toEqual(' packetbeat-*');
+  });
 });
diff --git a/x-pack/plugins/security_solution/public/common/components/sourcerer/index.tsx b/x-pack/plugins/security_solution/public/common/components/sourcerer/index.tsx
@@ -24,7 +24,6 @@ import { useDispatch, useSelector } from 'react-redux';
 import styled from 'styled-components';
 
 import * as i18n from './translations';
-import { SOURCERER_FEATURE_FLAG_ON } from '../../containers/sourcerer/constants';
 import { sourcererActions, sourcererModel } from '../../store/sourcerer';
 import { State } from '../../store';
 import { getSourcererScopeSelector, SourcererScopeSelector } from './selectors';
@@ -40,7 +39,7 @@ interface SourcererComponentProps {
   scope: sourcererModel.SourcererScopeName;
 }
 
-export const SourcererComponent = React.memo<SourcererComponentProps>(({ scope: scopeId }) => {
+export const Sourcerer = React.memo<SourcererComponentProps>(({ scope: scopeId }) => {
   const dispatch = useDispatch();
   const sourcererScopeSelector = useMemo(getSourcererScopeSelector, []);
   const { configIndexPatterns, kibanaIndexPatterns, sourcererScope } = useSelector<
@@ -71,17 +70,14 @@ export const SourcererComponent = React.memo<SourcererComponentProps>(({ scope:
   );
 
   const renderOption = useCallback(
-    (option) => {
-      const { value } = option;
-      if (kibanaIndexPatterns.some((kip) => kip.title === value)) {
-        return (
-          <>
-            <EuiIcon type="logoKibana" size="s" /> {value}
-          </>
-        );
-      }
-      return <>{value}</>;
-    },
+    ({ value }) =>
+      kibanaIndexPatterns.some((kip) => kip.title === value) ? (
+        <span data-test-subj="kip-option">
+          <EuiIcon type="logoKibana" size="s" /> {value}
+        </span>
+      ) : (
+        <span data-test-subj="config-option">{value}</span>
+      ),
     [kibanaIndexPatterns]
   );
 
@@ -175,6 +171,7 @@ export const SourcererComponent = React.memo<SourcererComponentProps>(({ scope:
   return (
     <EuiToolTip position="top" content={tooltipContent}>
       <EuiPopover
+        data-test-subj="sourcerer-popover"
         button={trigger}
         isOpen={isPopoverOpen}
         closePopover={handleClosePopOver}
@@ -221,6 +218,4 @@ export const SourcererComponent = React.memo<SourcererComponentProps>(({ scope:
     </EuiToolTip>
   );
 });
-SourcererComponent.displayName = 'Sourcerer';
-
-export const Sourcerer = SOURCERER_FEATURE_FLAG_ON ? SourcererComponent : () => null;
+Sourcerer.displayName = 'Sourcerer';
diff --git a/x-pack/plugins/security_solution/public/common/containers/sourcerer/constants.ts b/x-pack/plugins/security_solution/public/common/containers/sourcerer/constants.ts