Skip to content

Commit

Permalink
[Security Solution] Full screen Timeline CSS fixes (#72559)
Browse files Browse the repository at this point in the history
## [Security Solution] Full screen Timeline CSS fixes

Fixes CSS issues related to the [Full screen timeline, Collapse event](#71786) feature:

- Sometimes, Timeline's left padding is missing in Full screen mode
- The `Attach to new case` and `Attach to existing case...` actions should be centered in Full screen mode
- The Timeline flyout button is not opaque when the alerts table is in Full screen mode

### Sometimes, Timeline's left padding is missing in Full screen mode

To reproduce:

1) Drag anything to the Timeline
2) Click the `Full screen` button

**Expected result**
- [x] The timeline has left padding in full screen mode

**Actual result**
- [x] Sometimes, the left padding of the Timeline is missing, per the screenshot below:

![timeline-full-screen-before](https://user-images.githubusercontent.com/4459398/87998223-8acf8000-cab4-11ea-91a1-6b5644856b44.png)

### Fix: screenshot

![timeline-full-screen-after](https://user-images.githubusercontent.com/4459398/87998363-e3068200-cab4-11ea-8484-41d87ba4c97e.png)

### The `Attach to new case` and `Attach to existing case...` actions should be centered in full screen mode

1) Create a new timeline with the following KQL query: `agent.type : endpoint`
2) Click the `Analyze event` button on any enabled event to view Resolver

**Expected result**
- [x] The `Attach to new case` and `Attach to existing case...` actions should be centered between the horizontal lines

**Actual result**
- [x] The `Attach to new case` and `Attach to existing case...` actions are **NOT** centered, per the screenshot below:

![attach-to-case-before](https://user-images.githubusercontent.com/4459398/87998636-b9018f80-cab5-11ea-87e8-a54355386519.png)

### Fix: screenshot

![attach-to-case-after](https://user-images.githubusercontent.com/4459398/87998553-82c41000-cab5-11ea-9e33-fcffce11e4b4.png)

### The Timeline flyout button is not opaque when the alerts table is in Full screen mode

To reproduce:

1) Navigate to Security > Detections
2) Click on the `Full screen` button

**Expected result**
- [x] The Timeline flyout button is opaque when the alerts table is in Full screen mode

**Actual result**
- [x] The Timeline flyout button is **NOT** opaque when the alerts table is in Full screen mode, per the screenshot below:

![flyout-button-before](https://user-images.githubusercontent.com/4459398/87998761-0d0c7400-cab6-11ea-9cd3-0c091e0291c9.png)

## Fix: screenshot (light theme)

![flyout-button-after-light](https://user-images.githubusercontent.com/4459398/87998784-231a3480-cab6-11ea-8fc9-17c28cf25202.png)

## Fix: screenshot (dark theme)

![flyout-button-after-dark](https://user-images.githubusercontent.com/4459398/87998824-45ac4d80-cab6-11ea-96ef-6242b8494f84.png)

### Desk testing

Desk tested in :
- Chrome `84.0.4147.89`
- Firefox `78.0.2`
- Safari `13.1.2`
  • Loading branch information
andrew-goldstein committed Jul 21, 2020
1 parent 1df44e5 commit 8671803
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ const Container = styled.div`
}
.${FLYOUT_BUTTON_CLASS_NAME} {
background: ${({ theme }) => rgba(theme.eui.euiPageBackgroundColor, 1)};
border-radius: 4px 4px 0 0;
box-shadow: none;
height: 46px;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ const StyledResizable = styled(Resizable)`

const RESIZABLE_ENABLE = { left: true };

const RESIZABLE_DISABLED = { left: false };

const FlyoutPaneComponent: React.FC<FlyoutPaneComponentProps> = ({
children,
onClose,
Expand Down Expand Up @@ -98,10 +100,10 @@ const FlyoutPaneComponent: React.FC<FlyoutPaneComponentProps> = ({
size="l"
>
<StyledResizable
enable={RESIZABLE_ENABLE}
enable={timelineFullScreen ? RESIZABLE_DISABLED : RESIZABLE_ENABLE}
defaultSize={resizableDefaultSize}
minWidth={timelineFullScreen ? '100vw' : minWidthPixels}
maxWidth={timelineFullScreen ? '100vw' : `${maxWidthPercent}vw`}
minWidth={timelineFullScreen ? 'calc(100vw - 8px)' : minWidthPixels}
maxWidth={timelineFullScreen ? 'calc(100vw - 8px)' : `${maxWidthPercent}vw`}
handleComponent={resizableHandleComponent}
onResizeStop={onResizeStop}
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ const GraphOverlayComponent = ({
</EuiFlexItem>
{timelineId === TimelineId.active && timelineType === TimelineType.default && (
<EuiFlexItem grow={false}>
<EuiFlexGroup gutterSize="none">
<EuiFlexGroup alignItems="center" gutterSize="none">
<EuiFlexItem grow={false}>
<NewCase
compact={true}
Expand Down

0 comments on commit 8671803

Please sign in to comment.