[Uptime] Convert anomaly Jobs name to lowercase to comply with… (#62293)

* converted ml job name to lower case * update type
elastic · Apr 2, 2020 · 8265ebc · 8265ebc
1 parent a025f59
commit 8265ebc
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 13 deletions.
diff --git a/...me/public/components/monitor_details/ml/__tests__/__snapshots__/ml_job_link.test.tsx.snap b/...me/public/components/monitor_details/ml/__tests__/__snapshots__/ml_job_link.test.tsx.snap
diff --git a/x-pack/legacy/plugins/uptime/public/components/monitor_details/ml/ml_flyout_container.tsx b/x-pack/legacy/plugins/uptime/public/components/monitor_details/ml/ml_flyout_container.tsx
@@ -48,13 +48,13 @@ const showMLJobNotification = (
           </MLJobLink>
         </p>
       ),
-      toastLifeTimeMs: 5000,
+      toastLifeTimeMs: 10000,
     });
   } else {
-    notifications.toasts.warning({
+    notifications.toasts.danger({
       title: <p>{labels.JOB_CREATION_FAILED}</p>,
       body: message ?? <p>{labels.JOB_CREATION_FAILED_MESSAGE}</p>,
-      toastLifeTimeMs: 5000,
+      toastLifeTimeMs: 10000,
     });
   }
 };
@@ -108,7 +108,7 @@ export const MachineLearningFlyout: React.FC<Props> = ({ onClose }) => {
           basePath,
           { to: dateRangeEnd, from: dateRangeStart },
           false,
-          error?.body?.message
+          error?.message || error?.body?.message
         );
       }
       setIsCreatingJob(false);

diff --git a/x-pack/legacy/plugins/uptime/public/state/api/ml_anomaly.ts b/x-pack/legacy/plugins/uptime/public/state/api/ml_anomaly.ts
@@ -13,7 +13,7 @@ import { CreateMLJobSuccess, DeleteJobResults, MonitorIdParam } from '../actions
 import { DataRecognizerConfigResponse } from '../../../../../../plugins/ml/common/types/modules';
 import { JobExistResult } from '../../../../../../plugins/ml/common/types/data_recognizer';
 
-export const getMLJobId = (monitorId: string) => `${monitorId}_${ML_JOB_ID}`;
+export const getMLJobId = (monitorId: string) => `${monitorId}_${ML_JOB_ID}`.toLowerCase();
 
 export const getMLCapabilities = async (): Promise<PrivilegesResponse> => {
   return await apiService.get(API_URLS.ML_CAPABILITIES);
@@ -28,8 +28,11 @@ export const createMLJob = async ({
 }: MonitorIdParam): Promise<CreateMLJobSuccess | null> => {
   const url = API_URLS.ML_SETUP_MODULE + ML_MODULE_ID;
 
+  // ML App doesn't support upper case characters in job name
+  const lowerCaseMonitorId = monitorId.toLowerCase();
+
   const data = {
-    prefix: `${monitorId}_`,
+    prefix: `${lowerCaseMonitorId}_`,
     useDedicatedIndex: false,
     startDatafeed: true,
     start: moment()
@@ -41,7 +44,7 @@ export const createMLJob = async ({
         filter: [
           {
             term: {
-              'monitor.id': monitorId,
+              'monitor.id': lowerCaseMonitorId,
             },
           },
         ],
@@ -50,11 +53,17 @@ export const createMLJob = async ({
   };
 
   const response: DataRecognizerConfigResponse = await apiService.post(url, data);
-  if (response?.jobs?.[0]?.id === getMLJobId(monitorId) && response?.jobs?.[0]?.success) {
-    return {
-      count: 1,
-      jobId: response?.jobs?.[0]?.id,
-    };
+  if (response?.jobs?.[0]?.id === getMLJobId(monitorId)) {
+    const jobResponse = response.jobs[0];
+    if (jobResponse.success) {
+      return {
+        count: 1,
+        jobId: jobResponse.id,
+      };
+    } else {
+      const { error } = jobResponse;
+      throw new Error(error?.msg);
+    }
   } else {
     return null;
   }