use eslint-import-plugin/no-export-default instead of custom rule (#3…

…4285) (#34332)
elastic · Apr 2, 2019 · 8257078 · 8257078
1 parent decb5ee
commit 8257078
Show file tree

Hide file tree

Showing 24 changed files with 22 additions and 52 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -129,7 +129,7 @@ module.exports = {
     {
       files: ['x-pack/test/functional/apps/**/*', 'x-pack/plugins/apm/**/*'],
       rules: {
-        '@kbn/eslint/no-default-export': 'off',
+        'import/no-default-export': 'off',
         'import/no-named-as-default': 'off',
       },
     },

diff --git a/packages/kbn-eslint-plugin-eslint/index.js b/packages/kbn-eslint-plugin-eslint/index.js
@@ -21,7 +21,6 @@ module.exports = {
   rules: {
     'require-license-header': require('./rules/require_license_header'),
     'disallow-license-headers': require('./rules/disallow_license_headers'),
-    'no-default-export': require('./rules/no_default_export'),
     'no-restricted-paths': require('./rules/no_restricted_paths'),
     module_migration: require('./rules/module_migration'),
   },

diff --git a/packages/kbn-eslint-plugin-eslint/rules/no_default_export.js b/packages/kbn-eslint-plugin-eslint/rules/no_default_export.js
diff --git a/src/legacy/core_plugins/kibana/public/.eslintrc b/src/legacy/core_plugins/kibana/public/.eslintrc
@@ -1,3 +1,3 @@
 rules:
   no-console: 2
-  '@kbn/eslint/no-default-export': error
+  'import/no-default-export': error
diff --git a/src/legacy/core_plugins/kibana/public/field_formats/__tests__/_conformance.js b/src/legacy/core_plugins/kibana/public/field_formats/__tests__/_conformance.js
@@ -43,7 +43,7 @@ const formatIds = [
   'static_lookup'
 ];
 
-// eslint-disable-next-line @kbn/eslint/no-default-export
+// eslint-disable-next-line import/no-default-export
 export default describe('conformance', function () {
 
   const getConfig = (...args) => config.get(...args);

diff --git a/src/legacy/ui/public/.eslintrc b/src/legacy/ui/public/.eslintrc
@@ -1,3 +1,3 @@
 rules:
   no-console: 2
-  '@kbn/eslint/no-default-export': error
+  'import/no-default-export': error
diff --git a/src/legacy/ui/public/agg_response/hierarchical/_collect_branch.js b/src/legacy/ui/public/agg_response/hierarchical/_collect_branch.js
@@ -17,7 +17,7 @@
  * under the License.
  */
 
-// eslint-disable-next-line @kbn/eslint/no-default-export
+// eslint-disable-next-line import/no-default-export
 export default function (leaf) {
   // walk up the branch for each parent
   function walk(item, memo) {

diff --git a/src/legacy/ui/public/agg_types/__tests__/agg_param_writer.js b/src/legacy/ui/public/agg_types/__tests__/agg_param_writer.js
@@ -22,7 +22,7 @@ import { VisProvider } from '../../vis';
 import { aggTypes } from '..';
 import FixturesStubbedLogstashIndexPatternProvider from 'fixtures/stubbed_logstash_index_pattern';
 
-// eslint-disable-next-line @kbn/eslint/no-default-export
+// eslint-disable-next-line import/no-default-export
 export default function AggParamWriterHelper(Private) {
   const Vis = Private(VisProvider);
   const stubbedLogstashIndexPattern = Private(FixturesStubbedLogstashIndexPatternProvider);

diff --git a/src/legacy/ui/public/agg_types/__tests__/param_types/_json.js b/src/legacy/ui/public/agg_types/__tests__/param_types/_json.js
@@ -22,7 +22,7 @@ import expect from '@kbn/expect';
 import { BaseParamType } from '../../param_types/base';
 import { JsonParamType } from '../../param_types/json';
 
-// eslint-disable-next-line @kbn/eslint/no-default-export
+// eslint-disable-next-line import/no-default-export
 export default describe('JSON', function () {
   const paramName = 'json_test';
   let aggParam;

diff --git a/src/legacy/ui/public/agg_types/__tests__/param_types/_string.js b/src/legacy/ui/public/agg_types/__tests__/param_types/_string.js
@@ -22,7 +22,7 @@ import expect from '@kbn/expect';
 import { BaseParamType } from '../../param_types/base';
 import { StringParamType } from '../../param_types/string';
 
-// eslint-disable-next-line @kbn/eslint/no-default-export
+// eslint-disable-next-line import/no-default-export
 export default describe('String', function () {
   const paramName = 'json_test';
   let aggParam;

diff --git a/src/legacy/ui/public/agg_types/__tests__/utils/_stub_agg_params.js b/src/legacy/ui/public/agg_types/__tests__/utils/_stub_agg_params.js
@@ -46,7 +46,7 @@ function ParamClassStub(parent, body) {
  * @param  {PrivateLoader} Private - The private module loader, inject by passing this function to ngMock.inject()
  * @return {undefined}
  */
-// eslint-disable-next-line @kbn/eslint/no-default-export
+// eslint-disable-next-line import/no-default-export
 export default function stubParamClasses(Private) {
   const BaseAggParam = Private.stub(
     BaseParamType,

diff --git a/src/legacy/ui/public/chrome/api/apps.js b/src/legacy/ui/public/chrome/api/apps.js
@@ -20,7 +20,7 @@
 import { clone, get } from 'lodash';
 import { resolve } from 'url';
 
-// eslint-disable-next-line @kbn/eslint/no-default-export
+// eslint-disable-next-line import/no-default-export
 export default function (chrome, internals) {
 
   if (get(internals, 'app.navLink.url')) {

diff --git a/src/legacy/ui/public/chrome/api/template.js b/src/legacy/ui/public/chrome/api/template.js
@@ -17,7 +17,7 @@
  * under the License.
  */
 
-// eslint-disable-next-line @kbn/eslint/no-default-export
+// eslint-disable-next-line import/no-default-export
 export default function (chrome, internals) {
 
   /**

diff --git a/src/legacy/ui/public/chrome/index.js b/src/legacy/ui/public/chrome/index.js
@@ -19,5 +19,5 @@
 
 import { chrome } from './chrome';
 
-// eslint-disable-next-line @kbn/eslint/no-default-export
+// eslint-disable-next-line import/no-default-export
 export default chrome;
diff --git a/src/legacy/ui/public/index_patterns/route_setup/load_default.js b/src/legacy/ui/public/index_patterns/route_setup/load_default.js
@@ -59,7 +59,7 @@ function displayBanner() {
   }, 15000);
 }
 
-// eslint-disable-next-line @kbn/eslint/no-default-export
+// eslint-disable-next-line import/no-default-export
 export default function (opts) {
   opts = opts || {};
   const whenMissingRedirectTo = opts.whenMissingRedirectTo || null;

diff --git a/src/legacy/ui/public/routes/index.js b/src/legacy/ui/public/routes/index.js
@@ -19,5 +19,5 @@
 
 import { uiRoutes } from './routes';
 
-// eslint-disable-next-line @kbn/eslint/no-default-export
+// eslint-disable-next-line import/no-default-export
 export default uiRoutes;
diff --git a/src/legacy/ui/public/routes/route_manager.js b/src/legacy/ui/public/routes/route_manager.js
@@ -23,7 +23,7 @@ import { wrapRouteWithPrep } from './wrap_route_with_prep';
 import { RouteSetupManager } from './route_setup_manager';
 import { parsePathToBreadcrumbs } from './breadcrumbs';
 
-// eslint-disable-next-line @kbn/eslint/no-default-export
+// eslint-disable-next-line import/no-default-export
 export default function RouteManager() {
   const self = this;
   const setup = new RouteSetupManager();

diff --git a/src/legacy/ui/public/utils/ipv4_address.ts b/src/legacy/ui/public/utils/ipv4_address.ts
@@ -30,7 +30,7 @@ function isIntegerInRange(integer: number, min: number, max: number) {
   );
 }
 
-// eslint-disable-next-line @kbn/eslint/no-default-export
+// eslint-disable-next-line import/no-default-export
 // tslint:disable:no-default-export
 export default class Ipv4Address {
   private value: number;

diff --git a/src/legacy/ui/public/utils/mapping_setup.js b/src/legacy/ui/public/utils/mapping_setup.js
@@ -20,7 +20,7 @@
 import angular from 'angular';
 import _ from 'lodash';
 
-// eslint-disable-next-line @kbn/eslint/no-default-export
+// eslint-disable-next-line import/no-default-export
 export default function MappingSetupService() {
   const mappingSetup = this;
 

diff --git a/src/legacy/ui/public/vis/agg_config_result.js b/src/legacy/ui/public/vis/agg_config_result.js
@@ -19,7 +19,7 @@
 
 import chrome from '../chrome';
 
-// eslint-disable-next-line @kbn/eslint/no-default-export
+// eslint-disable-next-line import/no-default-export
 export default function AggConfigResult(aggConfig, parent, value, key, filters) {
   this.key = key;
   this.value = value;

diff --git a/src/legacy/ui/public/vislib/index.js b/src/legacy/ui/public/vislib/index.js
@@ -19,5 +19,5 @@
 
 import { VislibProvider } from './vislib';
 
-// eslint-disable-next-line @kbn/eslint/no-default-export
+// eslint-disable-next-line import/no-default-export
 export default VislibProvider;
diff --git a/src/legacy/ui/public/vislib/lib/layout/splits/gauge_chart/chart_split.js b/src/legacy/ui/public/vislib/lib/layout/splits/gauge_chart/chart_split.js
@@ -19,7 +19,7 @@
 
 import d3 from 'd3';
 
-// eslint-disable-next-line @kbn/eslint/no-default-export
+// eslint-disable-next-line import/no-default-export
 export default function ChartSplitFactory() {
 
   /*

diff --git a/src/legacy/ui/public/vislib/lib/layout/splits/gauge_chart/chart_title_split.js b/src/legacy/ui/public/vislib/lib/layout/splits/gauge_chart/chart_title_split.js
@@ -19,7 +19,7 @@
 
 import d3 from 'd3';
 
-// eslint-disable-next-line @kbn/eslint/no-default-export
+// eslint-disable-next-line import/no-default-export
 export default function ChartTitleSplitFactory() {
 
   /*

diff --git a/x-pack/test/functional/config.js b/x-pack/test/functional/config.js
@@ -4,7 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-/* eslint-disable @kbn/eslint/no-default-export */
+/* eslint-disable import/no-default-export */
 
 import { resolve } from 'path';