[TIP] Code clean

elastic · Sep 19, 2022 · 7d81350 · 7d81350
1 parent eb5538a
commit 7d81350
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/x-pack/plugins/threat_intelligence/public/modules/indicators/lib/field_value.test.ts b/x-pack/plugins/threat_intelligence/public/modules/indicators/lib/field_value.test.ts
@@ -53,6 +53,14 @@ describe('field_value', () => {
       expect(result).toEqual(false);
     });
 
+    it('should return false for empty string value', () => {
+      const mockField = 'abc';
+      const mockValue = '';
+
+      const result = fieldAndValueValid(mockField, mockValue);
+      expect(result).toEqual(false);
+    });
+
     it(`should return false for ${EMPTY_VALUE} value`, () => {
       const mockField = 'abc';
       const mockValue = EMPTY_VALUE;

diff --git a/x-pack/plugins/threat_intelligence/public/modules/indicators/lib/field_value.ts b/x-pack/plugins/threat_intelligence/public/modules/indicators/lib/field_value.ts
@@ -38,4 +38,4 @@ export const getIndicatorFieldAndValue = (
  * @returns true if correct, false if not
  */
 export const fieldAndValueValid = (field: string | null, value: string | null): boolean =>
-  value != null && value !== '' && value !== EMPTY_VALUE && field != null && field !== '';
+  !!value && value !== EMPTY_VALUE && !!field;