handles nits from PR review

elastic · Sep 19, 2022 · 7aa18ba · 7aa18ba
1 parent 0ce4a5d
commit 7aa18ba
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/...ages/core/saved-objects/core-saved-objects-api-server-internal/src/lib/repository.test.ts b/...ages/core/saved-objects/core-saved-objects-api-server-internal/src/lib/repository.test.ts
@@ -2454,7 +2454,7 @@ describe('SavedObjectsRepository', () => {
         );
       });
 
-      it(`returns an for an object when the object's type is hidden`, async () => {
+      it(`returns an error for an object when the object's type is hidden`, async () => {
         const hiddenObject = { ...obj1, type: HIDDEN_TYPE };
         await repositoryBulkDeleteError(hiddenObject, false, expectErrorInvalidType(hiddenObject));
       });

diff --git a/packages/core/saved-objects/core-saved-objects-api-server-internal/src/lib/repository.ts b/packages/core/saved-objects/core-saved-objects-api-server-internal/src/lib/repository.ts
@@ -240,7 +240,7 @@ export class SavedObjectsRepository implements ISavedObjectsRepository {
       serializer,
       migrator,
       allowedTypes = [],
-      logger, // 'savedobjects-service.repository'
+      logger,
     } = options;
 
     // It's important that we migrate documents / mark them as up-to-date

diff --git a/src/core/server/integration_tests/saved_objects/service/lib/repository_with_proxy.test.ts b/src/core/server/integration_tests/saved_objects/service/lib/repository_with_proxy.test.ts
@@ -263,8 +263,11 @@ describe('404s from proxies', () => {
     });
 
     it('handles `bulkDelete` requests that are successful when the proxy passes through the product header', async () => {
-      const docsToGet = myBulkDeleteTypeDocs;
-      const bulkDeleteDocs = docsToGet.map((doc) => ({ id: doc.id, type: 'my_bulk_delete_type' }));
+      const docsToDelete = myBulkDeleteTypeDocs;
+      const bulkDeleteDocs = docsToDelete.map((doc) => ({
+        id: doc.id,
+        type: 'my_bulk_delete_type',
+      }));
 
       const docsFound = await repository.bulkDelete(bulkDeleteDocs, { force: false });
       expect(docsFound.statuses.length).toBeGreaterThan(0);