[App Search] Small route fixes/updates (#98556)

* Various route URL updates

- Snake case Kibana routes
- Remove unnecessary extra subdirectory pathing

* Fix missing ability check

- There isn't currently a role that would fail the check, but since the nav link is wrapped in the role, we might as well copy it and look at our role checks in the 8.0 refactor

* fix test

x-pack/plugins/enterprise_search/public/applications/app_search/components/engine/engine_router.test.tsx

@@ -19,6 +19,7 @@ import { Loading } from '../../../shared/loading';
 import { AnalyticsRouter } from '../analytics';
 import { ApiLogs } from '../api_logs';
 import { CurationsRouter } from '../curations';
+import { Documents, DocumentDetail } from '../documents';
 import { EngineOverview } from '../engine_overview';
 import { RelevanceTuning } from '../relevance_tuning';
 import { ResultSettings } from '../result_settings';
@@ -103,6 +104,14 @@ describe('EngineRouter', () => {
     expect(wrapper.find(AnalyticsRouter)).toHaveLength(1);
   });
 
+  it('renders a documents view', () => {
+    setMockValues({ ...values, myRole: { canViewEngineDocuments: true } });
+    const wrapper = shallow(<EngineRouter />);
+
+    expect(wrapper.find(Documents)).toHaveLength(1);
+    expect(wrapper.find(DocumentDetail)).toHaveLength(1);
+  });
+
   it('renders a synonyms view', () => {
     setMockValues({ ...values, myRole: { canManageEngineSynonyms: true } });
     const wrapper = shallow(<EngineRouter />);

x-pack/plugins/enterprise_search/public/applications/app_search/components/engine/engine_router.tsx

@@ -17,7 +17,6 @@ import { SetAppSearchChrome as SetPageChrome } from '../../../shared/kibana_chro
 import { Loading } from '../../../shared/loading';
 import { AppLogic } from '../../app_logic';
 
-// TODO: Uncomment and add more routes as we migrate them
 import {
   ENGINES_PATH,
   ENGINE_ANALYTICS_PATH,
@@ -50,7 +49,7 @@ export const EngineRouter: React.FC = () => {
   const {
     myRole: {
       canViewEngineAnalytics,
-      // canViewEngineDocuments,
+      canViewEngineDocuments,
       // canViewEngineSchema,
       // canViewEngineCrawler,
       canViewMetaEngineSourceEngines,
@@ -93,12 +92,16 @@ export const EngineRouter: React.FC = () => {
           <AnalyticsRouter />
         </Route>
       )}
-      <Route path={ENGINE_DOCUMENT_DETAIL_PATH}>
-        <DocumentDetail />
-      </Route>
-      <Route path={ENGINE_DOCUMENTS_PATH}>
-        <Documents />
-      </Route>
+      {canViewEngineDocuments && (
+        <Route path={ENGINE_DOCUMENT_DETAIL_PATH}>
+          <DocumentDetail />
+        </Route>
+      )}
+      {canViewEngineDocuments && (
+        <Route path={ENGINE_DOCUMENTS_PATH}>
+          <Documents />
+        </Route>
+      )}
       {canManageEngineCurations && (
         <Route path={ENGINE_CURATIONS_PATH}>
           <CurationsRouter />

x-pack/plugins/enterprise_search/public/applications/app_search/index.test.tsx

@@ -173,7 +173,7 @@ describe('AppSearchNav', () => {
     setMockValues({ myRole: { canViewSettings: true } });
     const wrapper = shallow(<AppSearchNav />);
 
-    expect(wrapper.find(SideNavLink).last().prop('to')).toEqual('/settings/account');
+    expect(wrapper.find(SideNavLink).last().prop('to')).toEqual('/settings');
   });
 
   it('renders the Credentials link', () => {

x-pack/plugins/enterprise_search/public/applications/app_search/routes.ts

@@ -12,7 +12,7 @@ export const DOCS_PREFIX = docLinks.appSearchBase;
 export const ROOT_PATH = '/';
 export const SETUP_GUIDE_PATH = '/setup_guide';
 export const LIBRARY_PATH = '/library';
-export const SETTINGS_PATH = '/settings/account';
+export const SETTINGS_PATH = '/settings';
 export const CREDENTIALS_PATH = '/credentials';
 
 export const ROLE_MAPPINGS_PATH = '/role_mappings';
@@ -21,9 +21,7 @@ export const ROLE_MAPPING_NEW_PATH = `${ROLE_MAPPINGS_PATH}/new`;
 
 export const ENGINES_PATH = '/engines';
 export const ENGINE_CREATION_PATH = '/engine_creation';
-
 export const ENGINE_PATH = `${ENGINES_PATH}/:engineName`;
-export const SAMPLE_ENGINE_PATH = `${ENGINES_PATH}/national-parks-demo`;
 
 export const ENGINE_ANALYTICS_PATH = `${ENGINE_PATH}/analytics`;
 export const ENGINE_ANALYTICS_TOP_QUERIES_PATH = `${ENGINE_ANALYTICS_PATH}/top_queries`;
@@ -48,11 +46,11 @@ export const META_ENGINE_SOURCE_ENGINES_PATH = `${ENGINE_PATH}/engines`;
 
 export const ENGINE_RELEVANCE_TUNING_PATH = `${ENGINE_PATH}/relevance_tuning`;
 export const ENGINE_SYNONYMS_PATH = `${ENGINE_PATH}/synonyms`;
-export const ENGINE_RESULT_SETTINGS_PATH = `${ENGINE_PATH}/result-settings`;
+export const ENGINE_RESULT_SETTINGS_PATH = `${ENGINE_PATH}/result_settings`;
 
 export const ENGINE_CURATIONS_PATH = `${ENGINE_PATH}/curations`;
 export const ENGINE_CURATIONS_NEW_PATH = `${ENGINE_CURATIONS_PATH}/new`;
 export const ENGINE_CURATION_PATH = `${ENGINE_CURATIONS_PATH}/:curationId`;
 
-export const ENGINE_SEARCH_UI_PATH = `${ENGINE_PATH}/reference_application/new`;
+export const ENGINE_SEARCH_UI_PATH = `${ENGINE_PATH}/search_ui`;
 export const ENGINE_API_LOGS_PATH = `${ENGINE_PATH}/api_logs`;