Return the promise from setup so test passes

elastic · Aug 4, 2020 · 777925c · 777925c
1 parent afd064a
commit 777925c
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/x-pack/plugins/ingest_manager/server/services/setup.ts b/x-pack/plugins/ingest_manager/server/services/setup.ts
@@ -127,6 +127,11 @@ export async function setupIngestManager(
     // if anything errors, reject/fail
     onSetupReject(error);
   }
+
+  // be sure to return the promise because it has the resolved/rejected status attached to it
+  // otherwise, we effectively return success every time even if there are errors
+  // because `return undefined` -> `Promise.resolve(undefined)` in an `async` function
+  return setupIngestStatus;
 }
 
 export async function setupFleet(