Skip to content

Commit

Permalink
[8.11] Fix API Key flyout double submit (#167468) (#168483)
Browse files Browse the repository at this point in the history
# Backport

This will backport the following commits from `main` to `8.11`:
- [Fix API Key flyout double submit
(#167468)](#167468)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Sid","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-10T14:12:45Z","message":"Fix
API Key flyout double submit (#167468)\n\n## Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/163314\r\n\r\n\r\n##
Fixes\r\n\r\n- Removed an extra EuiPortal that was not needed as
EuiFlyout adds a\r\nPortal\r\n- Inverted control of the form by wrapping
the flyout content in the\r\nform. Prevents multiple submits by using
traditional form controls and\r\nbutton type as submit.\r\n\r\n\r\n##
Release Notes:\r\n\r\n- Fixes issue with multiple API keys being created
if the form is\r\nsubmitted using the enter key fired multiple times in
quick
succession.\r\nhttps://github.com//issues/163314\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"e3d9f3d62e403f56b9d3a553338a3c5201edc021","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Security","backport:prev-minor","v8.12.0"],"number":167468,"url":"https://github.com/elastic/kibana/pull/167468","mergeCommit":{"message":"Fix
API Key flyout double submit (#167468)\n\n## Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/163314\r\n\r\n\r\n##
Fixes\r\n\r\n- Removed an extra EuiPortal that was not needed as
EuiFlyout adds a\r\nPortal\r\n- Inverted control of the form by wrapping
the flyout content in the\r\nform. Prevents multiple submits by using
traditional form controls and\r\nbutton type as submit.\r\n\r\n\r\n##
Release Notes:\r\n\r\n- Fixes issue with multiple API keys being created
if the form is\r\nsubmitted using the enter key fired multiple times in
quick
succession.\r\nhttps://github.com//issues/163314\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"e3d9f3d62e403f56b9d3a553338a3c5201edc021"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/167468","number":167468,"mergeCommit":{"message":"Fix
API Key flyout double submit (#167468)\n\n## Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/163314\r\n\r\n\r\n##
Fixes\r\n\r\n- Removed an extra EuiPortal that was not needed as
EuiFlyout adds a\r\nPortal\r\n- Inverted control of the form by wrapping
the flyout content in the\r\nform. Prevents multiple submits by using
traditional form controls and\r\nbutton type as submit.\r\n\r\n\r\n##
Release Notes:\r\n\r\n- Fixes issue with multiple API keys being created
if the form is\r\nsubmitted using the enter key fired multiple times in
quick
succession.\r\nhttps://github.com//issues/163314\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"e3d9f3d62e403f56b9d3a553338a3c5201edc021"}}]}]
BACKPORT-->

Co-authored-by: Sid <[email protected]>
  • Loading branch information
kibanamachine and SiddharthMantri authored Oct 10, 2023
1 parent 14e9682 commit 76d0339
Show file tree
Hide file tree
Showing 2 changed files with 444 additions and 511 deletions.
104 changes: 0 additions & 104 deletions x-pack/plugins/security/public/components/form_flyout.tsx

This file was deleted.

Loading

0 comments on commit 76d0339

Please sign in to comment.