improve types for useSearchStrategy

elastic · Sep 13, 2023 · 766e198 · 766e198
1 parent 5944944
commit 766e198
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 7 deletions.
diff --git a/x-pack/plugins/security_solution/public/common/containers/cti/event_enrichment/api.ts b/x-pack/plugins/security_solution/public/common/containers/cti/event_enrichment/api.ts
@@ -14,7 +14,7 @@ import type { EventEnrichmentRequestOptionsInput } from '../../../../../common/a
 import type { CtiEventEnrichmentStrategyResponse } from '../../../../../common/search_strategy/security_solution/cti';
 import { CtiQueries } from '../../../../../common/search_strategy/security_solution/cti';
 
-type GetEventEnrichmentProps = EventEnrichmentRequestOptionsInput & {
+type GetEventEnrichmentProps = Omit<EventEnrichmentRequestOptionsInput, 'factoryQueryType'> & {
   data: DataPublicPluginStart;
   signal: AbortSignal;
 };

diff --git a/...ns/security_solution/public/common/containers/use_first_last_seen/use_first_last_seen.tsx b/...ns/security_solution/public/common/containers/use_first_last_seen/use_first_last_seen.tsx
@@ -45,7 +45,6 @@ export const useFirstLastSeen = ({
   useEffect(() => {
     search({
       defaultIndex,
-      factoryQueryType: FirstLastSeenQuery,
       field,
       value,
       order,

diff --git a/x-pack/plugins/security_solution/public/common/containers/use_search_strategy/index.tsx b/x-pack/plugins/security_solution/public/common/containers/use_search_strategy/index.tsx
@@ -58,7 +58,7 @@ export const useSearch = <QueryType extends FactoryQueryTypes>(
 
       const observable = data.search
         .search<StrategyRequestInputType<QueryType>, StrategyResponseType<QueryType>>(
-          { ...request, factoryQueryType } as unknown as StrategyRequestInputType<QueryType>,
+          { ...request, factoryQueryType } as StrategyRequestInputType<QueryType>,
           {
             strategy: 'securitySolutionSearchStrategy',
             abortSignal,

diff --git a/...ns/security_solution/public/overview/containers/overview_cti_links/use_ti_data_sources.ts b/...ns/security_solution/public/overview/containers/overview_cti_links/use_ti_data_sources.ts
@@ -22,7 +22,7 @@ import type { GlobalTimeArgs } from '../../../common/containers/use_global_time'
 import { OTHER_DATA_SOURCE_TITLE } from '../../components/overview_cti_links/translations';
 import { OTHER_TI_DATASET_KEY } from '../../../../common/cti/constants';
 
-type GetThreatIntelSourcProps = ThreatIntelSourceRequestOptionsInput & {
+type GetThreatIntelSourceProps = Omit<ThreatIntelSourceRequestOptionsInput, 'factoryQueryType'> & {
   data: DataPublicPluginStart;
   signal: AbortSignal;
 };
@@ -33,7 +33,7 @@ export const getTiDataSources = ({
   defaultIndex,
   timerange,
   signal,
-}: GetThreatIntelSourcProps): Observable<CtiDataSourceStrategyResponse> =>
+}: GetThreatIntelSourceProps): Observable<CtiDataSourceStrategyResponse> =>
   data.search.search<ThreatIntelSourceRequestOptionsInput, CtiDataSourceStrategyResponse>(
     {
       defaultIndex,
@@ -47,7 +47,7 @@ export const getTiDataSources = ({
   );
 
 export const getTiDataSourcesComplete = (
-  props: GetThreatIntelSourcProps
+  props: GetThreatIntelSourceProps
 ): Observable<CtiDataSourceStrategyResponse> => {
   return getTiDataSources(props).pipe(
     filter((response) => {

diff --git a/...plugins/security_solution/public/timelines/components/side_panel/new_user_detail/hooks.ts b/...plugins/security_solution/public/timelines/components/side_panel/new_user_detail/hooks.ts
@@ -111,7 +111,6 @@ export const useManagedUser = (userName: string) => {
     if (!isInitializing) {
       search({
         defaultIndex: MANAGED_USER_INDEX,
-        factoryQueryType: UsersQueries.managedDetails,
         userName,
       });
     }