css cleanup

elastic · Sep 10, 2020 · 71a78f8 · 71a78f8
1 parent e367824
commit 71a78f8
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 19 deletions.
diff --git a/src/core/public/_variables.scss b/src/core/public/_variables.scss
@@ -0,0 +1,3 @@
+@import '@elastic/eui/src/global_styling/variables/header';
+
+$headerOffset: $euiHeaderHeightCompensation * 2;
diff --git a/src/core/public/index.scss b/src/core/public/index.scss
@@ -1,6 +1,6 @@
+@import './variables';
 @import './core';
 @import './chrome/index';
 @import './overlays/index';
 @import './rendering/index';
 @import './styles/index';
-
diff --git a/src/core/public/rendering/_base.scss b/src/core/public/rendering/_base.scss
@@ -1,8 +1,4 @@
-@import '@elastic/eui/src/global_styling/variables/header';
-@import '@elastic/eui/src/components/nav_drawer/variables';
-@include euiHeaderAffordForFixed($euiHeaderHeightCompensation * 2);
-
-$headerOffset: $euiHeaderHeightCompensation * 2;
+@include euiHeaderAffordForFixed($headerOffset);
 
 /**
  * stretch the root element of the Kibana application to set the base-size that
@@ -21,12 +17,6 @@ $headerOffset: $euiHeaderHeightCompensation * 2;
   margin: 0 auto;
   min-height: calc(100vh - #{$headerOffset});
 
-  @include internetExplorerOnly {
-    // IE specific bug with min-height in flex container, described in the next link
-    // https://github.com/philipwalton/flexbugs#3-min-height-on-a-flex-container-wont-apply-to-its-flex-items
-    height: calc(100vh - #{$headerOffset});
-  }
-
   &.hidden-chrome {
     min-height: 100vh;
   }

diff --git a/src/plugins/timelion/public/_app.scss b/src/plugins/timelion/public/_app.scss
@@ -1,10 +1,5 @@
-@import '@elastic/eui/src/global_styling/variables/header';
-
-$headerOffset: $euiHeaderHeightCompensation * 2;
-
 .timApp {
   position: relative;
-  min-height: calc(100vh - #{$headerOffset});
   background: $euiColorEmptyShade;
 
   [ng-click] {

diff --git a/x-pack/plugins/maps/public/_main.scss b/x-pack/plugins/maps/public/_main.scss
@@ -1,5 +1,4 @@
-@import '@elastic/eui/src/global_styling/variables/header';
-$headerOffset: $euiHeaderHeightCompensation * 2;
+@import '../../../../src/core/public/variables';
 
 // sass-lint:disable no-ids
 #maps-plugin {
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		@import '@elastic/eui/src/global_styling/variables/header';

		$headerOffset: $euiHeaderHeightCompensation * 2;