Fix type issue

elastic · Mar 18, 2020 · 70abcc0 · 70abcc0
1 parent 99c81e2
commit 70abcc0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/x-pack/plugins/infra/public/components/alerting/metrics/expression.tsx b/x-pack/plugins/infra/public/components/alerting/metrics/expression.tsx
@@ -56,7 +56,7 @@ interface Props {
   errors: IErrorObject[];
   alertParams: {
     criteria: MetricExpression[];
-    groupBy?: string | null;
+    groupBy?: string;
     filterQuery?: string;
   };
   alertsContext: AlertsContextValue<AlertContextMeta>;
@@ -135,7 +135,7 @@ export const Expressions: React.FC<Props> = props => {
 
   const onGroupByChange = useCallback(
     (group: string | null) => {
-      setAlertParams('groupBy', group);
+      setAlertParams('groupBy', group || undefined);
     },
     [setAlertParams]
   );

diff --git a/x-pack/plugins/infra/public/components/waffle/node_context_menu.tsx b/x-pack/plugins/infra/public/components/waffle/node_context_menu.tsx
@@ -145,15 +145,6 @@ export const NodeContextMenu: React.FC<Props> = ({
     isDisabled: !showUptimeLink,
   };
 
-  const alertMenuItem: SectionLinkProps = {
-    label: i18n.translate('xpack.infra.nodeContextMenu.createAlertLink', {
-      defaultMessage: 'Create Alert',
-    }),
-    onClick: () => {
-      setFlyoutVisible(true);
-    },
-  };
-
   return (
     <>
       <ActionMenu