[7.x] [Vislib] Removes old implementation of xy chart (#110786) (#111558

) * [Vislib] Removes old implementation of xy chart (#110786) * [Vislib] Remove xy chart * Update i18n * Remove uncecessary file * Fix types * More fixes * Fix functional tests part 1 * Fix functional tests part 2 * Fix bug with shard-delay * Fix functional tests part 3 * fix functional tests part4 * Fix async_serch FT * Fix functional dashboard async test * REplace screenshot area chart image * Cleanup vislib from xy charts * Remove unused fixtures * Address PR comments * Remove miaou :D * Address PR comments * Fix i18n Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # docs/management/advanced-options.asciidoc # test/functional/screenshots/baseline/area_chart.png * Fixes * Remove setting from docs Co-authored-by: Kibana Machine <[email protected]>
elastic · Sep 8, 2021 · 705d2b0 · 705d2b0
1 parent d381d36
commit 705d2b0
Show file tree

Hide file tree

Showing 100 changed files with 883 additions and 5,317 deletions.
diff --git a/docs/management/advanced-options.asciidoc b/docs/management/advanced-options.asciidoc
@@ -548,10 +548,6 @@ The maximum geoHash precision displayed in tile maps. 7 is high, 10 is very high
 and 12 is the maximum. For more information, refer to
 {ref}/search-aggregations-bucket-geohashgrid-aggregation.html#_cell_dimensions_at_the_equator[Cell dimensions at the equator].
 
-[[visualization-visualize-chartslibrary]]`visualization:visualize:legacyChartsLibrary`::
-**The legacy XY charts are deprecated and will not be supported as of 7.16.**
-The visualize editor uses a new XY charts library with improved performance, color palettes, fill capacity, and more. Enable this option if you prefer to use the legacy charts library.
-
 [[visualization-visualize-pieChartslibrary]]`visualization:visualize:legacyPieChartsLibrary`::
 The visualize editor uses new pie charts with improved performance, color palettes, label positioning, and more. Enable this option if you prefer to use to the legacy charts library.
 

diff --git a/src/plugins/kibana_usage_collection/server/collectors/management/schema.ts b/src/plugins/kibana_usage_collection/server/collectors/management/schema.ts
@@ -408,10 +408,6 @@ export const stackManagementSchema: MakeSchemaFrom<UsageStats> = {
     type: 'boolean',
     _meta: { description: 'Non-default value of setting.' },
   },
-  'visualization:visualize:legacyChartsLibrary': {
-    type: 'boolean',
-    _meta: { description: 'Non-default value of setting.' },
-  },
   'visualization:visualize:legacyPieChartsLibrary': {
     type: 'boolean',
     _meta: { description: 'Non-default value of setting.' },

diff --git a/src/plugins/kibana_usage_collection/server/collectors/management/types.ts b/src/plugins/kibana_usage_collection/server/collectors/management/types.ts
@@ -28,7 +28,6 @@ export interface UsageStats {
   'autocomplete:useTimeRange': boolean;
   'autocomplete:valueSuggestionMethod': string;
   'search:timeout': number;
-  'visualization:visualize:legacyChartsLibrary': boolean;
   'visualization:visualize:legacyPieChartsLibrary': boolean;
   'doc_table:legacy': boolean;
   'discover:modifyColumnsOnSwitch': boolean;

diff --git a/src/plugins/telemetry/schema/oss_plugins.json b/src/plugins/telemetry/schema/oss_plugins.json
@@ -7759,12 +7759,6 @@
             "description": "Non-default value of setting."
           }
         },
-        "visualization:visualize:legacyChartsLibrary": {
-          "type": "boolean",
-          "_meta": {
-            "description": "Non-default value of setting."
-          }
-        },
         "visualization:visualize:legacyPieChartsLibrary": {
           "type": "boolean",
           "_meta": {

diff --git a/src/plugins/vis_type_timelion/public/components/timelion_vis_component.tsx b/src/plugins/vis_type_timelion/public/components/timelion_vis_component.tsx
@@ -177,7 +177,7 @@ const TimelionVisComponent = ({
   }, [chart]);
 
   return (
-    <div className="timelionChart" data-test-subj="visTypeXyChart">
+    <div className="timelionChart" data-test-subj="timelionChart">
       {title && (
         <EuiTitle className="timelionChart__topTitle" size="xxxs">
           <h4>{title}</h4>

diff --git a/src/plugins/vis_types/vislib/public/area.ts b/src/plugins/vis_types/vislib/public/area.ts
diff --git a/src/plugins/vis_types/vislib/public/fixtures/dispatch_bar_chart_config_normal.json b/src/plugins/vis_types/vislib/public/fixtures/dispatch_bar_chart_config_normal.json
diff --git a/src/plugins/vis_types/vislib/public/fixtures/dispatch_bar_chart_config_percentage.json b/src/plugins/vis_types/vislib/public/fixtures/dispatch_bar_chart_config_percentage.json
diff --git a/src/plugins/vis_types/vislib/public/fixtures/dispatch_bar_chart_d3.json b/src/plugins/vis_types/vislib/public/fixtures/dispatch_bar_chart_d3.json
diff --git a/src/plugins/vis_types/vislib/public/fixtures/dispatch_bar_chart_data_point.json b/src/plugins/vis_types/vislib/public/fixtures/dispatch_bar_chart_data_point.json
diff --git a/src/plugins/vis_types/vislib/public/histogram.ts b/src/plugins/vis_types/vislib/public/histogram.ts
diff --git a/src/plugins/vis_types/vislib/public/horizontal_bar.ts b/src/plugins/vis_types/vislib/public/horizontal_bar.ts
diff --git a/src/plugins/vis_types/vislib/public/line.ts b/src/plugins/vis_types/vislib/public/line.ts
diff --git a/src/plugins/vis_types/vislib/public/plugin.ts b/src/plugins/vis_types/vislib/public/plugin.ts
@@ -13,16 +13,11 @@ import { VisualizationsSetup } from '../../../visualizations/public';
 import { ChartsPluginSetup } from '../../../charts/public';
 import { DataPublicPluginStart } from '../../../data/public';
 import { KibanaLegacyStart } from '../../../kibana_legacy/public';
-import { LEGACY_CHARTS_LIBRARY } from '../../xy/common/index';
 import { LEGACY_PIE_CHARTS_LIBRARY } from '../../pie/common/index';
 
 import { createVisTypeVislibVisFn } from './vis_type_vislib_vis_fn';
 import { createPieVisFn } from './pie_fn';
-import {
-  convertedTypeDefinitions,
-  pieVisTypeDefinition,
-  visLibVisTypeDefinitions,
-} from './vis_type_vislib_vis_types';
+import { visLibVisTypeDefinitions, pieVisTypeDefinition } from './vis_type_vislib_vis_types';
 import { setFormatService, setDataActions } from './services';
 import { getVislibVisRenderer } from './vis_renderer';
 
@@ -51,11 +46,8 @@ export class VisTypeVislibPlugin
     core: VisTypeVislibCoreSetup,
     { expressions, visualizations, charts }: VisTypeVislibPluginSetupDependencies
   ) {
-    const typeDefinitions = !core.uiSettings.get(LEGACY_CHARTS_LIBRARY, false)
-      ? convertedTypeDefinitions
-      : visLibVisTypeDefinitions;
     // register vislib XY axis charts
-    typeDefinitions.forEach(visualizations.createBaseVisualization);
+    visLibVisTypeDefinitions.forEach(visualizations.createBaseVisualization);
     expressions.registerRenderer(getVislibVisRenderer(core, charts));
     expressions.registerFunction(createVisTypeVislibVisFn());
 

diff --git a/src/plugins/vis_types/vislib/public/types.ts b/src/plugins/vis_types/vislib/public/types.ts
@@ -37,12 +37,7 @@ export const GaugeType = Object.freeze({
 export type GaugeType = $Values<typeof GaugeType>;
 
 export const VislibChartType = Object.freeze({
-  Histogram: 'histogram' as const,
-  HorizontalBar: 'horizontal_bar' as const,
-  Line: 'line' as const,
   Pie: 'pie' as const,
-  Area: 'area' as const,
-  PointSeries: 'point_series' as const,
   Heatmap: 'heatmap' as const,
   Gauge: 'gauge' as const,
   Goal: 'goal' as const,

diff --git a/src/plugins/vis_types/vislib/public/vis_type_vislib_vis_types.ts b/src/plugins/vis_types/vislib/public/vis_type_vislib_vis_types.ts
@@ -7,27 +7,13 @@
  */
 
 import { VisTypeDefinition } from 'src/plugins/visualizations/public';
-import { histogramVisTypeDefinition } from './histogram';
-import { lineVisTypeDefinition } from './line';
-import { areaVisTypeDefinition } from './area';
 import { heatmapVisTypeDefinition } from './heatmap';
-import { horizontalBarVisTypeDefinition } from './horizontal_bar';
 import { gaugeVisTypeDefinition } from './gauge';
 import { goalVisTypeDefinition } from './goal';
 
 export { pieVisTypeDefinition } from './pie';
 
 export const visLibVisTypeDefinitions: Array<VisTypeDefinition<any>> = [
-  histogramVisTypeDefinition,
-  lineVisTypeDefinition,
-  areaVisTypeDefinition,
-  heatmapVisTypeDefinition,
-  horizontalBarVisTypeDefinition,
-  gaugeVisTypeDefinition,
-  goalVisTypeDefinition,
-];
-
-export const convertedTypeDefinitions: Array<VisTypeDefinition<any>> = [
   heatmapVisTypeDefinition,
   gaugeVisTypeDefinition,
   goalVisTypeDefinition,

diff --git a/src/plugins/vis_types/vislib/public/vislib/VISLIB.md b/src/plugins/vis_types/vislib/public/vislib/VISLIB.md
@@ -1,4 +1,8 @@
-# Vislib general overview
+# Charts supported
+
+Vislib supports the heatmap and gauge/goal charts from the aggregation-based visualizations. It also contains the legacy implemementation of the pie chart (enabled by the visualization:visualize:legacyPieChartsLibrary advanced setting).
+
+# General overview
 
 `vis.js` constructor accepts vis parameters and render method accepts data. it exposes event emitter interface so we can listen to certain events like 'renderComplete'.
 
@@ -18,7 +22,4 @@ All base visualizations extend from `visualizations/_chart`
 
 ### Point series chart
 
-`visualizations/point_series` takes care of drawing the point series chart (no axes or titles, just the chart itself). It creates all the series defined and calls render method on them.
-
-currently there are 3 series types available (line, area, bars), they all extend from `visualizations/point_series/_point_series`.
-
+`visualizations/point_series` takes care of drawing the point series chart (no axes or titles, just the chart itself). It creates all the series defined and calls render method on them.
diff --git a/src/plugins/vis_types/vislib/public/vislib/_index.scss b/src/plugins/vis_types/vislib/public/vislib/_index.scss
@@ -5,5 +5,4 @@
 @import './components/tooltip/index';
 @import './components/legend/index';
 
-@import './visualizations/point_series/index';
 @import './visualizations/gauges/index';
diff --git a/src/plugins/vis_types/vislib/public/vislib/lib/axis/axis.test.js b/src/plugins/vis_types/vislib/public/vislib/lib/axis/axis.test.js
@@ -96,7 +96,7 @@ describe('Vislib Axis Class Test Suite', function () {
 
     const visConfig = new VisConfig(
       {
-        type: 'histogram',
+        type: 'heatmap',
       },
       data,
       mockUiState,

diff --git a/src/plugins/vis_types/vislib/public/vislib/lib/axis/axis_title.test.js b/src/plugins/vis_types/vislib/public/vislib/lib/axis/axis_title.test.js
@@ -103,7 +103,7 @@ describe('Vislib AxisTitle Class Test Suite', function () {
     dataObj = new Data(data, getMockUiState(), () => undefined);
     visConfig = new VisConfig(
       {
-        type: 'histogram',
+        type: 'heatmap',
       },
       data,
       getMockUiState(),

diff --git a/src/plugins/vis_types/vislib/public/vislib/lib/axis/x_axis.test.js b/src/plugins/vis_types/vislib/public/vislib/lib/axis/x_axis.test.js
@@ -101,7 +101,7 @@ describe('Vislib xAxis Class Test Suite', function () {
 
     const visConfig = new VisConfig(
       {
-        type: 'histogram',
+        type: 'heatmap',
       },
       data,
       mockUiState,

diff --git a/src/plugins/vis_types/vislib/public/vislib/lib/axis/y_axis.test.js b/src/plugins/vis_types/vislib/public/vislib/lib/axis/y_axis.test.js
@@ -81,7 +81,7 @@ function createData(seriesData) {
   buildYAxis = function (params) {
     const visConfig = new VisConfig(
       {
-        type: 'histogram',
+        type: 'heatmap',
       },
       data,
       mockUiState,

diff --git a/src/plugins/vis_types/vislib/public/vislib/lib/chart_title.test.js b/src/plugins/vis_types/vislib/public/vislib/lib/chart_title.test.js
@@ -99,7 +99,7 @@ describe('Vislib ChartTitle Class Test Suite', function () {
 
     const visConfig = new VisConfig(
       {
-        type: 'histogram',
+        type: 'heatmap',
         title: {
           text: 'rows',
         },