fixed formatting issues pointed by pr feedback

elastic · Mar 23, 2020 · 6eade46 · 6eade46
1 parent 8d3feec
commit 6eade46
Show file tree

Hide file tree

Showing 7 changed files with 21 additions and 19 deletions.
diff --git a/x-pack/legacy/plugins/uptime/public/components/functional/charts/duration_chart.tsx b/x-pack/legacy/plugins/uptime/public/components/functional/charts/duration_chart.tsx
@@ -87,14 +87,12 @@ export const DurationChartComponent = ({
                   <FormattedMessage
                     id="xpack.uptime.monitorCharts.monitorDuration.titleLabelWithAnomaly"
                     defaultMessage="Monitor duration (Anomalies: {noOfAnomalies})"
-                    description="The 'ms' is an abbreviation for milliseconds."
                     values={{ noOfAnomalies: anomalies?.anomalies?.length ?? 0 }}
                   />
                 ) : (
                   <FormattedMessage
                     id="xpack.uptime.monitorCharts.monitorDuration.titleLabel"
                     defaultMessage="Monitor duration"
-                    description="The 'ms' is an abbreviation for milliseconds."
                   />
                 )}
               </h4>

diff --git a/...public/components/monitor_details/ml/__tests__/__snapshots__/confirm_delete.test.tsx.snap b/...public/components/monitor_details/ml/__tests__/__snapshots__/confirm_delete.test.tsx.snap
diff --git a/...time/public/components/monitor_details/ml/__tests__/__snapshots__/ml_flyout.test.tsx.snap b/...time/public/components/monitor_details/ml/__tests__/__snapshots__/ml_flyout.test.tsx.snap
diff --git a/x-pack/legacy/plugins/uptime/public/components/monitor_details/ml/ml_flyout.tsx b/x-pack/legacy/plugins/uptime/public/components/monitor_details/ml/ml_flyout.tsx
@@ -59,6 +59,8 @@ export function MLFlyoutView({ isCreatingJob, onClickCreate, onClose, canCreateM
                 ),
               }}
             />
+          </p>
+          <p>
             <em>{labels.TAKE_SOME_TIME_TEXT}</em>
           </p>
         </EuiText>

diff --git a/x-pack/legacy/plugins/uptime/public/components/monitor_details/ml/ml_flyout_container.tsx b/x-pack/legacy/plugins/uptime/public/components/monitor_details/ml/ml_flyout_container.tsx
@@ -144,13 +144,11 @@ export const MachineLearningFlyout: React.FC<Props> = ({ onClose }) => {
   };
 
   return (
-    <>
-      <MLFlyoutView
-        canCreateMLJob={!!canCreateMLJob}
-        isCreatingJob={isMLJobCreating}
-        onClickCreate={createAnomalyJob}
-        onClose={onClose}
-      />
-    </>
+    <MLFlyoutView
+      canCreateMLJob={!!canCreateMLJob}
+      isCreatingJob={isMLJobCreating}
+      onClickCreate={createAnomalyJob}
+      onClose={onClose}
+    />
   );
 };
diff --git a/x-pack/legacy/plugins/uptime/public/components/monitor_details/ml/translations.tsx b/x-pack/legacy/plugins/uptime/public/components/monitor_details/ml/translations.tsx
@@ -53,7 +53,7 @@ export const JOB_DELETION_SUCCESS = i18n.translate(
 export const JOB_DELETION_CONFIRMATION = i18n.translate(
   'xpack.uptime.ml.enableAnomalyDetectionPanel.jobDeletionConfirmLabel',
   {
-    defaultMessage: 'Delete Anomaly detection job?',
+    defaultMessage: 'Delete anomaly detection job?',
   }
 );
 
@@ -128,7 +128,7 @@ export const CREAT_ML_JOB_DESC = i18n.translate(
   'xpack.uptime.ml.enableAnomalyDetectionPanel.createMLJobDescription',
   {
     defaultMessage: `Here you can create a machine learning job to calculate anomaly scores on
-    response durations for Uptime Monitor. Once enabled, The monitor duration chart on details page
+    response durations for Uptime Monitor. Once enabled, the monitor duration chart on the details page
     will show the expected bounds and annotate the graph with anomalies. You can also potentially
      identify periods of increased latency across geographical regions.`,
   }

diff --git a/...te/effects/__tests__/fecth_effect.test.ts → ...te/effects/__tests__/fetch_effect.test.ts b/...te/effects/__tests__/fecth_effect.test.ts → ...te/effects/__tests__/fetch_effect.test.ts
@@ -28,7 +28,7 @@ describe('fetch saga effect factory', () => {
     )(calledAction);
     let next = fetchEffect.next();
 
-    // @ts-ignore TODO, dig dipper for TS issues here
+    // @ts-ignore TODO, dig deeper for TS issues here
     expect(next.value).toEqual(call(fetchStatus, calledAction.payload));
 
     const successResult = put(asyncAction.success(indexStatusResult));
@@ -52,7 +52,7 @@ describe('fetch saga effect factory', () => {
     )(calledAction);
     let next = fetchEffect.next();
 
-    // @ts-ignore TODO, dig dipper for TS issues here
+    // @ts-ignore TODO, dig deeper for TS issues here
     expect(next.value).toEqual(call(fetchIndexStatus, calledAction.payload));
 
     const errorResult = put(asyncAction.fail(indexStatusResultError));
@@ -76,7 +76,7 @@ describe('fetch saga effect factory', () => {
     )(calledAction);
     let next = fetchEffect.next();
 
-    // @ts-ignore TODO, dig dipper for TS issues here
+    // @ts-ignore TODO, dig deeper for TS issues here
     expect(next.value).toEqual(call(fetchIndexStatus, calledAction.payload));
 
     const unexpectedErrorResult = put(asyncAction.fail(unExpectedError));