[Dev Tools] Fix cat APIs returning as escaped string (#130638)

* Fix escaped strings * Add tests Co-authored-by: Muhammad Ibragimov <[email protected]>
elastic · Apr 21, 2022 · 6e8d198 · 6e8d198
1 parent bb9fc4b
commit 6e8d198
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 1 deletion.
diff --git a/...onsole/public/application/hooks/use_send_current_request_to_es/send_request_to_es.test.ts b/...onsole/public/application/hooks/use_send_current_request_to_es/send_request_to_es.test.ts
@@ -98,4 +98,36 @@ describe('sendRequestToES', () => {
       expect(mockedSendRequestToES).toHaveBeenCalledTimes(1);
     }
   });
+  describe('successful response value', () => {
+    describe('with text', () => {
+      it('should return value with lines separated', async () => {
+        mockedSendRequestToES.mockResolvedValue('\ntest_index-1    [] \ntest_index-2    []\n');
+        const response = await sendRequestToES({
+          http: mockContextValue.services.http,
+          requests: [{ method: 'GET', url: 'test-1', data: [] }],
+        });
+
+        expect(response).toMatchInlineSnapshot(`
+          "
+          test_index-1    [] 
+          test_index-2    []
+          "
+        `);
+        expect(mockedSendRequestToES).toHaveBeenCalledTimes(1);
+      });
+    });
+
+    describe('with parsed json', () => {
+      it('should stringify value', async () => {
+        mockedSendRequestToES.mockResolvedValue(JSON.stringify({ test: 'some value' }));
+        const response = await sendRequestToES({
+          http: mockContextValue.services.http,
+          requests: [{ method: 'GET', url: 'test-2', data: [] }],
+        });
+
+        expect(typeof response).toBe('string');
+        expect(mockedSendRequestToES).toHaveBeenCalledTimes(1);
+      });
+    });
+  });
 });
diff --git a/...ins/console/public/application/hooks/use_send_current_request_to_es/send_request_to_es.ts b/...ins/console/public/application/hooks/use_send_current_request_to_es/send_request_to_es.ts
@@ -93,7 +93,7 @@ export function sendRequestToES(args: EsRequestArgs): Promise<ESRequestResult[]>
             if (body instanceof ArrayBuffer) {
               value = body;
             } else {
-              value = JSON.stringify(body, null, 2);
+              value = typeof body === 'string' ? body : JSON.stringify(body, null, 2);
             }
 
             const warnings = response.headers.get('warning');