[ML] fix getFormattedSeverityScore and showSwimlane condition

elastic · Oct 6, 2020 · 6e63215 · 6e63215
1 parent 3a98bce
commit 6e63215
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 13 deletions.
diff --git a/x-pack/plugins/ml/common/util/anomaly_utils.ts b/x-pack/plugins/ml/common/util/anomaly_utils.ts
@@ -112,8 +112,8 @@ function getSeverityTypes() {
 /**
  * Return formatted severity score.
  */
-export function getFormattedSeverityScore(score: number) {
-  return score < 1 ? '< 1' : score.toFixed(2);
+export function getFormattedSeverityScore(score: number): string {
+  return score < 1 ? '< 1' : String(parseInt(String(score), 10));
 }
 
 // Returns a severity label (one of critical, major, minor, warning or unknown)

diff --git a/x-pack/plugins/ml/public/application/explorer/swimlane_container.tsx b/x-pack/plugins/ml/public/application/explorer/swimlane_container.tsx
@@ -174,17 +174,6 @@ export const SwimlaneContainer: FC<SwimlaneProps> = ({
     [chartWidth]
   );
 
-  const showSwimlane = swimlaneData?.laneLabels?.length > 0 && swimlaneData?.points.length > 0;
-
-  const isPaginationVisible =
-    (showSwimlane || isLoading) &&
-    swimlaneLimit !== undefined &&
-    onPaginationChange &&
-    fromPage &&
-    perPage;
-
-  const rowsCount = swimlaneData?.laneLabels?.length ?? 0;
-
   const swimLanePoints = useMemo(() => {
     const showFilterContext = filterActive === true && swimlaneType === SWIMLANE_TYPE.OVERALL;
 
@@ -206,6 +195,17 @@ export const SwimlaneContainer: FC<SwimlaneProps> = ({
       .filter((v) => v.value > 0);
   }, [swimlaneData?.points, filterActive, swimlaneType]);
 
+  const showSwimlane = swimlaneData?.laneLabels?.length > 0 && swimLanePoints.length > 0;
+
+  const isPaginationVisible =
+    (showSwimlane || isLoading) &&
+    swimlaneLimit !== undefined &&
+    onPaginationChange &&
+    fromPage &&
+    perPage;
+
+  const rowsCount = swimlaneData?.laneLabels?.length ?? 0;
+
   const containerHeight = useMemo(() => {
     // Persists container height during loading to prevent page from jumping
     return isLoading