PR feedback: reset search query on flyout re-open

elastic · Mar 18, 2021 · 6c559ac · 6c559ac
1 parent f232aec
commit 6c559ac
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/...ic/applications/app_search/components/curations/curation/results/add_result_logic.test.ts b/...ic/applications/app_search/components/curations/curation/results/add_result_logic.test.ts
@@ -43,14 +43,15 @@ describe('AddResultLogic', () => {
 
   describe('actions', () => {
     describe('openFlyout', () => {
-      it('sets isFlyoutOpen to true', () => {
-        mount({ isFlyoutOpen: false });
+      it('sets isFlyoutOpen to true and resets the searchQuery term', () => {
+        mount({ isFlyoutOpen: false, searchQuery: 'a previous search' });
 
         AddResultLogic.actions.openFlyout();
 
         expect(AddResultLogic.values).toEqual({
           ...DEFAULT_VALUES,
           isFlyoutOpen: true,
+          searchQuery: '',
         });
       });
     });

diff --git a/.../public/applications/app_search/components/curations/curation/results/add_result_logic.ts b/.../public/applications/app_search/components/curations/curation/results/add_result_logic.ts
@@ -54,6 +54,7 @@ export const AddResultLogic = kea<MakeLogicType<AddResultValues, AddResultAction
       '',
       {
         search: (_, { query }) => query,
+        openFlyout: () => '',
       },
     ],
     searchResults: [
-Original file line number
+Diff line change
@@ Expand Up @@
           '',
           {
             search: (_, { query }) => query,
+            openFlyout: () => '',
           },
         ],
         searchResults: [
@@ Expand Down @@