[PR feedback] Make empty array/obj stable references

elastic · Mar 22, 2024 · 6bd5dde · 6bd5dde
1 parent 1c4b1df
commit 6bd5dde
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/x-pack/plugins/security_solution/public/common/components/header_actions/header_actions.tsx b/x-pack/plugins/security_solution/public/common/components/header_actions/header_actions.tsx
@@ -6,7 +6,7 @@
  */
 
 import React, { useMemo, useCallback } from 'react';
-import type { EuiDataGridSorting } from '@elastic/eui';
+import type { EuiDataGridSorting, EuiDataGridSchemaDetector } from '@elastic/eui';
 import { EuiButtonIcon, EuiCheckbox, EuiToolTip, useDataGridColumnSorting } from '@elastic/eui';
 import { useDispatch } from 'react-redux';
 
@@ -64,6 +64,10 @@ const ActionsContainer = styled.div`
   display: flex;
 `;
 
+// Defined statically to reduce rerenders
+const emptySchema = {};
+const emptySchemaDetectors: EuiDataGridSchemaDetector[] = [];
+
 const HeaderActionsComponent: React.FC<HeaderActionProps> = ({
   width,
   browserFields,
@@ -196,8 +200,8 @@ const HeaderActionsComponent: React.FC<HeaderActionProps> = ({
   const ColumnSorting = useDataGridColumnSorting({
     columns: myColumns,
     sorting: sortedColumns,
-    schema: {},
-    schemaDetectors: [],
+    schema: emptySchema,
+    schemaDetectors: emptySchemaDetectors,
     displayValues,
   });