Skip to content

Commit

Permalink
[Logstash Management] Euify pipeline (#22902)
Browse files Browse the repository at this point in the history
* Begin replacing pipeline editor KUI elements.

* WIP build out EUI rendering of Create Pipeline view.

* Add settings components.

* Add close functionality.

* Add save functionality.

* Add temporary dependency hack for testing purposes until EUI XY Chart replaces jquery-flot.

* Add delete pipeline button/capability.

* Add delete modal.

* Remove TODO comment.

* Added toasts.

* Switch to global toast system.

* Add toast for inactive license and readonly state.

* Remove pipeline edit template.

* Add notify on PUT and DELETE errors.

* Add null check for username prop of securityService return value.

* Add disable save button if invalid ID.

* Remove pipeline id field when editing existing pipeline.

* Remove obsolete code.

* Move PipelineEditor component to dedicated file.

* Add EUI table to pipeline list view.

* Add search to pipelines table.

* Add create/delete pipelines buttons.

* Add pagination stubs. Complete after EUI bug resolved.

* Added unselectable for non-centrally-managed pipelines.

* Add clone button to pipelines list.

* Add min page height. Fix bug with edit pipeline link.

* Remove obsolete pipeline list code.

* Remove obsolete tooltip, edit, list code.

* Disable create pipeline if id is empty.

* Move PipelineList component to dedicated file.

* Add empty state to pipeline list. Add selection messages.

* Update loading message.

* Move methods to more logical positions in component.

* Add info alerts to pipeline list.

* Remove obsolete angular template.

* Remove obsolete imports from pipeline list directive.

* Define UpgradeFailure component.

* Move UpgradeFailure subcomponents to dedicated files. Write tests.

* Move PipelineEditor subcomponents to dedicated files.

* Write tests for pipeline editor subcomponents.

* Move bare strings into constants.

* Move PipelineEditor constant values into constants file.

* Break subcomponents of InfoAlerts component into dedicated files.

* Remove obsolete constants.

* WIP - write tests for PipelineList, break table into separate component, add error empty prompt message.

* Move ConfirmDeleteModal component to dedicated file and test.

* Add TODO comment.

* Add test tags to react components.

* Add 'data-test-subj' prop to fields for func tests. Minor layout update. Run prettier on some files.

* Add data-test-subj prop to button. Disable two tests until pagination is re-added.

* Re-enabled pagination for pipeline list.

* Remove wallaby hack.

* Update pagination options, remove obsolete code.

* Fix bug introduced in refactor to display delete button at appropriate time.

* Handle max_bytes setting correctly. Add theme/mode to code editor.

* Update snapshot for new pagination.

* Remove angular template for UpgradeFailure view.

* Move bare text from Modal functional component to constant file. Update test + snapshot.

* Ran prettier on all changed documents.

* Remove obsolete TODO comments.

* Re-enable disabled functional test. Clean up TODO code.

* Fix unresolved promise in functional tests.

* Pipeline delete button hidden unless enabled, move to left.

* Make filter title more readable.

* Apply width to clone column on Pipeline List.

* Modify pipeline edit view to use 's'-size icons.

* Change pipeline editor delete button to empty button.

* Move pipeline edit actions to bottom left of form.

* Add propTypes for PipelineEditor.

* Update test snapshots.

* Update pipeline list delete button func test.

* Add pipeline edit test. Add heading to pipeline edit page.

* Move constant files to modules where they are consumed.

* Move UPGRADE_FAILURE constants into module that consumes them.

* Remove redundant tests and remove text constant imports from tests.

* Give initial values to id and description text fields to make them controlled components.

* Clean up pipeline ID form regex validation and add tests.
  • Loading branch information
justinkambic authored Sep 27, 2018
1 parent 95f48c5 commit 6bb4355
Show file tree
Hide file tree
Showing 65 changed files with 5,382 additions and 1,100 deletions.
19 changes: 0 additions & 19 deletions x-pack/plugins/logstash/common/constants/editor.js

This file was deleted.

1 change: 0 additions & 1 deletion x-pack/plugins/logstash/common/constants/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,3 @@ export { ES_SCROLL_SETTINGS } from './es_scroll_settings';
export { TOOLTIPS } from './tooltips';
export { PIPELINE } from './pipeline';
export { MONITORING } from './monitoring';
export { EDITOR } from './editor';
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`ConfirmDeletePipelineModal component renders as expected 1`] = `
<EuiOverlayMask>
<EuiConfirmModal
buttonColor="danger"
cancelButtonText="Cancel"
confirmButtonText="Delete pipeline"
defaultFocusedButton="cancel"
onCancel={[MockFunction]}
onConfirm={[MockFunction]}
title="Delete pipeline the id"
>
<p>
You cannot recover a deleted pipeline.
</p>
</EuiConfirmModal>
</EuiOverlayMask>
`;
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`FlexItemSetting component renders a null label if label/tooltip text not supplied 1`] = `
<EuiFlexItem
component="div"
grow={false}
>
<EuiFormRow
describedByIds={Array []}
fullWidth={false}
hasEmptyLabelSpace={true}
label={null}
>
<p>
The child elements
</p>
</EuiFormRow>
</EuiFlexItem>
`;

exports[`FlexItemSetting component renders component and children as expected 1`] = `
<EuiFlexItem
component="div"
grow={false}
>
<EuiFormRow
describedByIds={Array []}
fullWidth={false}
hasEmptyLabelSpace={false}
label={
<FormLabelWithIconTip
formRowLabelText="label text"
formRowTooltipText="tooltip text"
/>
}
>
<p>
The child elements
</p>
</EuiFormRow>
</EuiFlexItem>
`;
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`FormLabelWithIconTip component renders as expected 1`] = `
<div>
<span>
label text
</span>
 
<EuiIconTip
aria-label="Info"
content="tooltip text"
size="s"
type="questionInCircle"
/>
</div>
`;
Loading

0 comments on commit 6bb4355

Please sign in to comment.