Disable statuses

elastic · Oct 3, 2022 · 6af1146 · 6af1146
1 parent 8d4421c
commit 6af1146
Show file tree

Hide file tree

Showing 4 changed files with 48 additions and 9 deletions.
diff --git a/x-pack/plugins/cases/public/components/actions/status/use_status_action.test.tsx b/x-pack/plugins/cases/public/components/actions/status/use_status_action.test.tsx
@@ -38,11 +38,11 @@ describe('useStatusAction', () => {
       }
     );
 
-    expect(result.current.getActions([])).toMatchInlineSnapshot(`
+    expect(result.current.getActions([basicCase])).toMatchInlineSnapshot(`
       Array [
         Object {
           "data-test-subj": "cases-bulk-action-status-open",
-          "disabled": false,
+          "disabled": true,
           "icon": "empty",
           "key": "cases-bulk-action-status-open",
           "name": "Open",
@@ -132,7 +132,7 @@ describe('useStatusAction', () => {
     }
   );
 
-  const multipleCasesTests = [
+  const multipleCasesTests: Array<[CaseStatuses, number, string]> = [
     [CaseStatuses.open, 0, 'Opened 2 cases'],
     [CaseStatuses['in-progress'], 1, 'Marked 2 cases as in progress'],
     [CaseStatuses.closed, 2, 'Closed 2 cases'],
@@ -162,4 +162,37 @@ describe('useStatusAction', () => {
       });
     }
   );
+
+  const disabledTests: Array<[CaseStatuses, number]> = [
+    [CaseStatuses.open, 0],
+    [CaseStatuses['in-progress'], 1],
+    [CaseStatuses.closed, 2],
+  ];
+
+  it.each(disabledTests)('disables the status button correctly: %s', async (status, index) => {
+    const { result } = renderHook(
+      () => useStatusAction({ onAction, onActionSuccess, isDisabled: false }),
+      {
+        wrapper: appMockRender.AppWrapper,
+      }
+    );
+
+    const actions = result.current.getActions([{ ...basicCase, status }]);
+    expect(actions[index].disabled).toBe(true);
+  });
+
+  it.each(disabledTests)(
+    'disables the status button correctly if isDisabled=true: %s',
+    async (status, index) => {
+      const { result } = renderHook(
+        () => useStatusAction({ onAction, onActionSuccess, isDisabled: true }),
+        {
+          wrapper: appMockRender.AppWrapper,
+        }
+      );
+
+      const actions = result.current.getActions([basicCase]);
+      expect(actions[index].disabled).toBe(true);
+    }
+  );
 });
diff --git a/x-pack/plugins/cases/public/components/actions/status/use_status_action.tsx b/x-pack/plugins/cases/public/components/actions/status/use_status_action.tsx
@@ -33,6 +33,12 @@ interface UseStatusActionProps extends UseActionProps {
   selectedStatus?: CaseStatuses;
 }
 
+const getCasesWithChanges = (cases: Case[], status: CaseStatuses): Case[] =>
+  cases.filter((theCase) => theCase.status !== status);
+
+const disableStatus = (cases: Case[], status: CaseStatuses) =>
+  getCasesWithChanges(cases, status).length === 0;
+
 export const useStatusAction = ({
   onAction,
   onActionSuccess,
@@ -70,23 +76,23 @@ export const useStatusAction = ({
         name: statuses[CaseStatuses.open].label,
         icon: getStatusIcon(CaseStatuses.open),
         onClick: () => handleUpdateCaseStatus(selectedCases, CaseStatuses.open),
-        disabled: isDisabled,
+        disabled: isDisabled || disableStatus(selectedCases, CaseStatuses.open),
         'data-test-subj': 'cases-bulk-action-status-open',
         key: 'cases-bulk-action-status-open',
       },
       {
         name: statuses[CaseStatuses['in-progress']].label,
         icon: getStatusIcon(CaseStatuses['in-progress']),
         onClick: () => handleUpdateCaseStatus(selectedCases, CaseStatuses['in-progress']),
-        disabled: isDisabled,
+        disabled: isDisabled || disableStatus(selectedCases, CaseStatuses['in-progress']),
         'data-test-subj': 'cases-bulk-action-status-in-progress',
         key: 'cases-bulk-action-status-in-progress',
       },
       {
         name: statuses[CaseStatuses.closed].label,
         icon: getStatusIcon(CaseStatuses.closed),
         onClick: () => handleUpdateCaseStatus(selectedCases, CaseStatuses.closed),
-        disabled: isDisabled,
+        disabled: isDisabled || disableStatus(selectedCases, CaseStatuses.closed),
         'data-test-subj': 'cases-bulk-action-status-closed',
         key: 'cases-bulk-status-action',
       },

diff --git a/x-pack/plugins/cases/public/components/all_cases/use_actions.test.tsx b/x-pack/plugins/cases/public/components/all_cases/use_actions.test.tsx
@@ -104,7 +104,7 @@ describe('useActions', () => {
     });
 
     act(() => {
-      userEvent.click(res.getByTestId('cases-bulk-action-status-open'));
+      userEvent.click(res.getByTestId('cases-bulk-action-status-in-progress'));
     });
 
     await waitFor(() => {

diff --git a/x-pack/plugins/cases/public/components/all_cases/use_bulk_actions.test.tsx b/x-pack/plugins/cases/public/components/all_cases/use_bulk_actions.test.tsx
@@ -86,7 +86,7 @@ describe('useBulkActions', () => {
               "items": Array [
                 Object {
                   "data-test-subj": "cases-bulk-action-status-open",
-                  "disabled": false,
+                  "disabled": true,
                   "icon": "empty",
                   "key": "cases-bulk-action-status-open",
                   "name": "Open",
@@ -147,7 +147,7 @@ describe('useBulkActions', () => {
       });
 
       act(() => {
-        userEvent.click(res.getByTestId('cases-bulk-action-status-open'));
+        userEvent.click(res.getByTestId('cases-bulk-action-status-in-progress'));
       });
 
       await waitForHook(() => {