Fix bugs found during PR review

elastic · Nov 6, 2020 · 6ac90aa · 6ac90aa
1 parent a998547
commit 6ac90aa
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/.../plugins/security_solution/public/detections/components/rules/step_define_rule/schema.tsx b/.../plugins/security_solution/public/detections/components/rules/step_define_rule/schema.tsx
@@ -77,12 +77,11 @@ export const schema: FormSchema<DefineStepRule> = {
           ...args: Parameters<ValidationFunc>
         ): ReturnType<ValidationFunc<{}, ERROR_CODE>> | undefined => {
           const [{ value, path, formData }] = args;
-          const { query, filters, edited } = value as DefineStepRule['queryBar'];
+          const { query, filters } = value as DefineStepRule['queryBar'];
           const needsValidation = !isMlRule(formData.ruleType);
-          if (!needsValidation || edited === false) {
+          if (!needsValidation) {
             return;
           }
-
           return isEmpty(query.query as string) && isEmpty(filters)
             ? {
                 code: 'ERR_FIELD_MISSING',
@@ -97,9 +96,9 @@ export const schema: FormSchema<DefineStepRule> = {
           ...args: Parameters<ValidationFunc>
         ): ReturnType<ValidationFunc<{}, ERROR_CODE>> | undefined => {
           const [{ value, path, formData }] = args;
-          const { query, edited } = value as DefineStepRule['queryBar'];
+          const { query } = value as DefineStepRule['queryBar'];
           const needsValidation = !isMlRule(formData.ruleType);
-          if (!needsValidation || edited === false) {
+          if (!needsValidation) {
             return;
           }