-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Logs UI] Move page template to avoid re-renders (#151311)
## Summary closes [#150624](#150624) This PR improves how the page template re-renders, preventing it from doing so when context providers in the hierarchy below it change. https://user-images.githubusercontent.com/2767137/219055025-7da3a0ab-446f-4a8e-9a8e-af24a1a254be.mov ### For maintainers At given moments, the Logs UI URL changes, updating the `logPosition` state. This will re-render the template and its children.
- Loading branch information
1 parent
7be9b50
commit 6943797
Showing
2 changed files
with
12 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters