PR feedback

elastic · Apr 10, 2024 · 66012c2 · 66012c2
1 parent 1054f9a
commit 66012c2
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/x-pack/plugins/actions/server/integration_tests/__snapshots__/connector_types.test.ts.snap b/x-pack/plugins/actions/server/integration_tests/__snapshots__/connector_types.test.ts.snap
diff --git a/x-pack/plugins/cases/server/connectors/cases/README.md b/x-pack/plugins/cases/server/connectors/cases/README.md
@@ -145,7 +145,7 @@ The deduplication ID will be constructed as
 
 where
 
-`<rule_id>`: The ID of the rule. It can be optional to support two different rules attaching alerts to the same case. The rule id must be included if the grouping definition is not defined.
+`<rule_id>`: The ID of the rule. Including it in the deduplication ID ensures all cases created are at least rule-specific.
 `<space_id>`: The space ID of the rule. Space ID is a required field.
 `<owner>`: The owner of the Case. This will be set to the application from which the rule was created from. Owner is a required field.
 `<grouping_definition>`: The grouping field and the grouping value. It can be optional to support attaching all alerts of a rule to the same case.

diff --git a/x-pack/plugins/cases/server/saved_object_types/cases_rules.ts b/x-pack/plugins/cases/server/saved_object_types/cases_rules.ts
@@ -14,9 +14,6 @@ export const casesRulesSavedObjectType: SavedObjectsType = {
   name: CASE_RULES_SAVED_OBJECT,
   indexPattern: ALERTING_CASES_SAVED_OBJECT_INDEX,
   hidden: true,
-  /**
-   * TODO: Verify
-   */
   namespaceType: 'agnostic',
   mappings: {
     dynamic: false,