Skip to content

Commit

Permalink
[7.x] [kbn/plugin-generator] remove sao, modernize (#75465) (#75619)
Browse files Browse the repository at this point in the history
Co-authored-by: spalger <[email protected]>
  • Loading branch information
Spencer and spalger authored Aug 21, 2020
1 parent 01170a4 commit 65293aa
Show file tree
Hide file tree
Showing 52 changed files with 24,129 additions and 24,503 deletions.
2 changes: 1 addition & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ target
# package overrides
/packages/eslint-config-kibana
/packages/kbn-interpreter/src/common/lib/grammar.js
/packages/kbn-plugin-generator/sao_template/template
/packages/kbn-plugin-generator/template
/packages/kbn-pm/dist
/packages/kbn-test/src/functional_test_runner/__tests__/fixtures/
/packages/kbn-test/src/functional_test_runner/lib/config/__tests__/fixtures/
Expand Down
1 change: 0 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -608,7 +608,6 @@ module.exports = {
{
files: [
'.eslintrc.js',
'packages/kbn-plugin-generator/**/*.js',
'packages/kbn-eslint-import-resolver-kibana/**/*.js',
'packages/kbn-eslint-plugin-eslint/**/*',
'x-pack/gulpfile.js',
Expand Down
10 changes: 5 additions & 5 deletions packages/kbn-plugin-generator/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,17 @@ If you are targeting **Kibana 6.3 or greater** then checkout the corresponding K
To target the current development version of Kibana just use the default `master` branch.

```sh
node scripts/generate_plugin my_plugin_name
node scripts/generate_plugin --name my_plugin_name -y
# generates a plugin in `plugins/my_plugin_name`
```

To target 6.3, use the `6.x` branch (until the `6.3` branch is created).
To target 6.8, use the `6.8` branch.

```sh
git checkout 6.x
yarn kbn bootstrap # always bootstrap when switching branches
node scripts/generate_plugin my_plugin_name
# generates a plugin for Kibana 6.3 in `../kibana-extra/my_plugin_name`
node scripts/generate_plugin --name my_plugin_name -y
# generates a plugin for Kibana 6.8 in `../kibana-extra/my_plugin_name`
```

The generate script supports a few flags; run it with the `--help` flag to learn more.
Expand All @@ -49,7 +49,7 @@ yarn kbn bootstrap

## Plugin Development Scripts

Generated plugins receive a handful of scripts that can be used during development. Those scripts are detailed in the [README.md](sao_template/template/README.md) file in each newly generated plugin, and expose the scripts provided by the [Kibana plugin helpers](../kbn-plugin-helpers), but here is a quick reference in case you need it:
Generated plugins receive a handful of scripts that can be used during development. Those scripts are detailed in the [README.md](template/README.md) file in each newly generated plugin, and expose the scripts provided by the [Kibana plugin helpers](../kbn-plugin-helpers), but here is a quick reference in case you need it:

> ***NOTE:*** All of these scripts should be run from the generated plugin.
Expand Down
69 changes: 0 additions & 69 deletions packages/kbn-plugin-generator/index.js

This file was deleted.

This file was deleted.

26 changes: 19 additions & 7 deletions packages/kbn-plugin-generator/package.json
Original file line number Diff line number Diff line change
@@ -1,14 +1,26 @@
{
"name": "@kbn/plugin-generator",
"license": "Apache-2.0",
"private": true,
"version": "1.0.0",
"private": true,
"license": "Apache-2.0",
"main": "target/index.js",
"scripts": {
"kbn:bootstrap": "node scripts/build",
"kbn:watch": "node scripts/build --watch"
},
"dependencies": {
"chalk": "^4.1.0",
"dedent": "^0.7.0",
"@kbn/dev-utils": "1.0.0",
"ejs": "^3.1.5",
"execa": "^4.0.2",
"getopts": "^2.2.4",
"lodash": "^4.17.15",
"sao": "^0.22.12"
"inquirer": "^7.3.3",
"normalize-path": "^3.0.0",
"prettier": "^2.0.5",
"vinyl": "^2.2.0",
"vinyl-fs": "^3.0.3"
},
"devDependencies": {
"@types/ejs": "^3.0.4",
"@types/prettier": "^2.0.2",
"@types/inquirer": "^7.3.1"
}
}
Loading

0 comments on commit 65293aa

Please sign in to comment.