cleanup

elastic · Apr 16, 2023 · 6469d33 · 6469d33
1 parent 10830bf
commit 6469d33
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 11 deletions.
diff --git a/src/plugins/data_views/common/content_management/constants.ts b/src/plugins/data_views/common/content_management/constants.ts
@@ -6,11 +6,6 @@
  * Side Public License, v 1.
  */
 
-/**
- * Data view saved object version.
- */
-export const LATEST_VERSION = 1;
-
 export const DataViewSOType = 'index-pattern';
 
 export type DataViewContentType = typeof DataViewSOType;
diff --git a/src/plugins/data_views/common/data_views/data_views.test.ts b/src/plugins/data_views/common/data_views/data_views.test.ts
@@ -265,7 +265,6 @@ describe('IndexPatterns', () => {
   test('savedObjectCache pre-fetches title, type, typeMeta', async () => {
     expect(await indexPatterns.getIds()).toEqual(['id']);
     expect(savedObjectsClient.find).toHaveBeenCalledWith({
-      type: 'index-pattern',
       fields: ['title', 'type', 'typeMeta', 'name'],
       perPage: 10000,
     });
@@ -374,7 +373,6 @@ describe('IndexPatterns', () => {
     await indexPatterns.find('kibana*', size);
 
     expect(savedObjectsClient.find).lastCalledWith({
-      type: 'index-pattern',
       fields: ['title'],
       search,
       searchFields: ['title'],

diff --git a/src/plugins/data_views/common/index.ts b/src/plugins/data_views/common/index.ts
@@ -13,8 +13,6 @@ export {
   DATA_VIEW_SAVED_OBJECT_TYPE,
 } from './constants';
 
-export { LATEST_VERSION } from './content_management';
-
 export type { ToSpecConfig } from './fields';
 export type { IIndexPatternFieldList } from './fields';
 export {

diff --git a/src/plugins/data_views/public/saved_objects_client_wrapper.ts b/src/plugins/data_views/public/saved_objects_client_wrapper.ts
@@ -89,8 +89,6 @@ export class SavedObjectsClientPublicToCommon implements SavedObjectsClientCommo
     return response.saved_object;
   }
 
-  // SO update method took a `version` value via the options object.
-  // This was used to make sure the update was based on the most recent version of the object.
   async update(id: string, attributes: DataViewAttributes, options: DataViewUpdateOptions) {
     const response = await this.contentManagementClient.update<DataViewUpdateIn, DataViewUpdateOut>(
       {