Makes arguments optional to reduce touch points in exisiting code

elastic · Feb 10, 2022 · 6468a6c · 6468a6c
1 parent df989b5
commit 6468a6c
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 33 deletions.
diff --git a/x-pack/plugins/lists/server/services/exception_lists/close_point_in_time.ts b/x-pack/plugins/lists/server/services/exception_lists/close_point_in_time.ts
@@ -9,10 +9,10 @@ import type {
   SavedObjectsClientContract,
   SavedObjectsClosePointInTimeResponse,
 } from 'kibana/server';
-import type { Pit } from '@kbn/securitysolution-io-ts-list-types';
+import type { PitId } from '@kbn/securitysolution-io-ts-list-types';
 
 interface ClosePointInTimeOptions {
-  pit: Pit['id'];
+  pit: PitId;
   savedObjectsClient: SavedObjectsClientContract;
 }
 

diff --git a/x-pack/plugins/lists/server/services/exception_lists/exception_list_client_types.ts b/x-pack/plugins/lists/server/services/exception_lists/exception_list_client_types.ts
@@ -40,7 +40,7 @@ import type {
   OsTypeArray,
   PageOrUndefined,
   PerPageOrUndefined,
-  Pit,
+  PitId,
   PitOrUndefined,
   SearchAfterOrUndefined,
   SortFieldOrUndefined,
@@ -201,8 +201,8 @@ export interface FindExceptionListItemOptions {
   namespaceType: NamespaceType;
   filter: FilterOrUndefined;
   perPage: PerPageOrUndefined;
-  pit: PitOrUndefined;
-  searchAfter: SearchAfterOrUndefined;
+  pit?: PitOrUndefined;
+  searchAfter?: SearchAfterOrUndefined;
   page: PageOrUndefined;
   sortField: SortFieldOrUndefined;
   sortOrder: SortOrderOrUndefined;
@@ -211,8 +211,8 @@ export interface FindExceptionListItemOptions {
 export interface FindEndpointListItemOptions {
   filter: FilterOrUndefined;
   perPage: PerPageOrUndefined;
-  pit: PitOrUndefined;
-  searchAfter: SearchAfterOrUndefined;
+  pit?: PitOrUndefined;
+  searchAfter?: SearchAfterOrUndefined;
   page: PageOrUndefined;
   sortField: SortFieldOrUndefined;
   sortOrder: SortOrderOrUndefined;
@@ -223,8 +223,8 @@ export interface FindExceptionListsItemOptions {
   namespaceType: NamespaceTypeArray;
   filter: EmptyStringArrayDecoded;
   perPage: PerPageOrUndefined;
-  pit: PitOrUndefined;
-  searchAfter: SearchAfterOrUndefined;
+  pit?: PitOrUndefined;
+  searchAfter?: SearchAfterOrUndefined;
   page: PageOrUndefined;
   sortField: SortFieldOrUndefined;
   sortOrder: SortOrderOrUndefined;
@@ -233,8 +233,8 @@ export interface FindExceptionListsItemOptions {
 export interface FindValueListExceptionListsItems {
   valueListId: Id;
   perPage: PerPageOrUndefined;
-  pit: PitOrUndefined;
-  searchAfter: SearchAfterOrUndefined;
+  pit?: PitOrUndefined;
+  searchAfter?: SearchAfterOrUndefined;
   page: PageOrUndefined;
   sortField: SortFieldOrUndefined;
   sortOrder: SortOrderOrUndefined;
@@ -245,8 +245,8 @@ export interface FindExceptionListOptions {
   filter: FilterOrUndefined;
   perPage: PerPageOrUndefined;
   page: PageOrUndefined;
-  pit: PitOrUndefined;
-  searchAfter: SearchAfterOrUndefined;
+  pit?: PitOrUndefined;
+  searchAfter?: SearchAfterOrUndefined;
   sortField: SortFieldOrUndefined;
   sortOrder: SortOrderOrUndefined;
 }
@@ -280,5 +280,5 @@ export interface OpenPointInTimeOptions {
 }
 
 export interface ClosePointInTimeOptions {
-  pit: Pit['id'];
+  pit: PitId;
 }
diff --git a/x-pack/plugins/security_solution/server/endpoint/lib/artifacts/lists.ts b/x-pack/plugins/security_solution/server/endpoint/lib/artifacts/lists.ts
@@ -83,8 +83,6 @@ export async function getFilteredEndpointExceptionList(
       listId,
       namespaceType: 'agnostic',
       filter,
-      pit: undefined,
-      searchAfter: undefined,
       perPage: 100,
       page,
       sortField: 'created_at',

diff --git a/...ugins/security_solution/server/fleet_integration/handlers/remove_policy_from_artifacts.ts b/...ugins/security_solution/server/fleet_integration/handlers/remove_policy_from_artifacts.ts
@@ -39,8 +39,6 @@ export const removePolicyFromArtifacts = async (
       namespaceType: ARTIFACT_LISTS_IDS_TO_REMOVE.map(() => 'agnostic'),
       page: currentPage,
       perPage: 50,
-      pit: undefined,
-      searchAfter: undefined,
       sortField: undefined,
       sortOrder: undefined,
     });

diff --git a/x-pack/plugins/security_solution/server/lib/telemetry/receiver.ts b/x-pack/plugins/security_solution/server/lib/telemetry/receiver.ts
@@ -319,16 +319,11 @@ export class TelemetryReceiver implements ITelemetryReceiver {
     // Ensure list is created if it does not exist
     await this.exceptionListClient.createTrustedAppsList();
 
-    // TODO: Will need to address this when we switch over to
-    // using PIT, don't want it to get lost
-    // https://github.com/elastic/kibana/issues/103944
     const results = await this.exceptionListClient.findExceptionListItem({
       listId: ENDPOINT_TRUSTED_APPS_LIST_ID,
       page: 1,
       perPage: 10_000,
       filter: undefined,
-      pit: undefined,
-      searchAfter: undefined,
       namespaceType: 'agnostic',
       sortField: 'name',
       sortOrder: 'asc',
@@ -350,16 +345,11 @@ export class TelemetryReceiver implements ITelemetryReceiver {
     // Ensure list is created if it does not exist
     await this.exceptionListClient.createEndpointList();
 
-    // TODO: Will need to address this when we switch over to
-    // using PIT, don't want it to get lost
-    // https://github.com/elastic/kibana/issues/103944
     const results = await this.exceptionListClient.findExceptionListItem({
       listId,
       page: 1,
       perPage: this.max_records,
       filter: undefined,
-      pit: undefined,
-      searchAfter: undefined,
       namespaceType: 'agnostic',
       sortField: 'name',
       sortOrder: 'asc',
@@ -433,16 +423,11 @@ export class TelemetryReceiver implements ITelemetryReceiver {
     // Ensure list is created if it does not exist
     await this.exceptionListClient.createTrustedAppsList();
 
-    // TODO: Will need to address this when we switch over to
-    // using PIT, don't want it to get lost
-    // https://github.com/elastic/kibana/issues/103944
     const results = await this.exceptionListClient?.findExceptionListsItem({
       listId: [listId],
       filter: [],
       perPage: this.max_records,
-      pit: undefined,
       page: 1,
-      searchAfter: undefined,
       sortField: 'exception-list.created_at',
       sortOrder: 'desc',
       namespaceType: ['single'],