Skip to content

Commit

Permalink
decl files
Browse files Browse the repository at this point in the history
  • Loading branch information
kimjoar committed Jul 26, 2017
1 parent b98d081 commit 639dc6f
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions packages/@elastic/kbn-types/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,3 +62,19 @@ There are two ways to fix this problem:
For grep-ability, this is the error you'll likely see if hitting this problem:

> has or is using name 'Foo' from external module "./bar" but cannot be named
## Why expose declaration files instead of TypeScript files?

This package builds TypeScript [declaration files][ts-decl] instead of just
including the TypeScript files themselves. There are a couple reasons for this:

- If we shipped `.ts` files packages that depend on `kbn-types` would have to
use the same compiler options. That means we also need to find a way to share
that in a sane manner. However, if TypeScript adds the option of using
[`extends` with a package][tsconfig-extends] it might become easier.
- Tools like ts-loader [does not work nicely][ts-loader-node-modules] with `.ts`
files in `node_modules`.

[ts-decl]: https://www.typescriptlang.org/docs/handbook/declaration-files/introduction.html
[tsconfig-extends]: https://github.com/Microsoft/TypeScript/issues/15984
[ts-loader-node-modules]: https://github.com/TypeStrong/ts-loader/issues/278

0 comments on commit 639dc6f

Please sign in to comment.