[Lens] Cache avilable operations meta data (#95034)

elastic · Mar 24, 2021 · 6295ae7 · 6295ae7
1 parent 326abc2
commit 6295ae7
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 3 deletions.
diff --git a/x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/operation_support.ts b/x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/operation_support.ts
@@ -8,7 +8,7 @@
 import _ from 'lodash';
 import { DatasourceDimensionDropProps } from '../../types';
 import { OperationType } from '../indexpattern';
-import { getAvailableOperationsByMetadata } from '../operations';
+import { memoizedGetAvailableOperationsByMetadata } from '../operations';
 import { IndexPatternPrivateState } from '../types';
 
 export interface OperationSupportMatrix {
@@ -30,7 +30,7 @@ export const getOperationSupportMatrix = (props: Props): OperationSupportMatrix
   const layerId = props.layerId;
   const currentIndexPattern = props.state.indexPatterns[props.state.layers[layerId].indexPatternId];
 
-  const filteredOperationsByMetadata = getAvailableOperationsByMetadata(
+  const filteredOperationsByMetadata = memoizedGetAvailableOperationsByMetadata(
     currentIndexPattern
   ).filter((operation) => props.filterOperations(operation.operationMetaData));
 

diff --git a/x-pack/plugins/lens/public/indexpattern_datasource/loader.ts b/x-pack/plugins/lens/public/indexpattern_datasource/loader.ts
@@ -29,6 +29,7 @@ import { VisualizeFieldContext } from '../../../../../src/plugins/ui_actions/pub
 import { documentField } from './document_field';
 import { readFromStorage, writeToStorage } from '../settings_storage';
 import { getFieldByNameFactory } from './pure_helpers';
+import { memoizedGetAvailableOperationsByMetadata } from './operations';
 
 type SetState = StateSetter<IndexPatternPrivateState>;
 type IndexPatternsService = Pick<IndexPatternsContract, 'get' | 'getIdsWithTitle'>;
@@ -49,6 +50,11 @@ export async function loadIndexPatterns({
     return cache;
   }
 
+  if (memoizedGetAvailableOperationsByMetadata.cache.clear) {
+    // clear operations meta data cache because index pattern reference may change
+    memoizedGetAvailableOperationsByMetadata.cache.clear();
+  }
+
   const allIndexPatterns = await Promise.allSettled(
     missingIds.map((id) => indexPatternsService.get(id))
   );

diff --git a/x-pack/plugins/lens/public/indexpattern_datasource/operations/__mocks__/index.ts b/x-pack/plugins/lens/public/indexpattern_datasource/operations/__mocks__/index.ts
@@ -19,6 +19,7 @@ jest.spyOn(actualHelpers, 'getErrorMessages');
 
 export const {
   getAvailableOperationsByMetadata,
+  memoizedGetAvailableOperationsByMetadata,
   getOperations,
   getOperationDisplay,
   getOperationTypesForField,

diff --git a/x-pack/plugins/lens/public/indexpattern_datasource/operations/operations.ts b/x-pack/plugins/lens/public/indexpattern_datasource/operations/operations.ts
@@ -5,7 +5,7 @@
  * 2.0.
  */
 
-import _ from 'lodash';
+import { memoize } from 'lodash';
 import { OperationMetadata } from '../../types';
 import {
   operationDefinitionMap,
@@ -187,3 +187,5 @@ export function getAvailableOperationsByMetadata(indexPattern: IndexPattern) {
 
   return Object.values(operationByMetadata);
 }
+
+export const memoizedGetAvailableOperationsByMetadata = memoize(getAvailableOperationsByMetadata);