review feedback

elastic · Apr 13, 2020 · 61fed69 · 61fed69
1 parent d18d3e7
commit 61fed69
Showing 1 changed file with 16 additions and 12 deletions.
diff --git a/x-pack/legacy/plugins/maps/public/actions/map_actions.js b/x-pack/legacy/plugins/maps/public/actions/map_actions.js
@@ -125,9 +125,21 @@ async function syncDataForAllLayers(dispatch, getState, dataFilters) {
 export function cancelAllInFlightRequests() {
   return (dispatch, getState) => {
     getLayerList(getState()).forEach(layer => {
-      layer.getInFlightRequestTokens().forEach(requestToken => {
-        dispatch(cancelRequest(requestToken));
-      });
+      dispatch(clearDataRequests(layer));
+    });
+  };
+}
+
+function clearDataRequests(layer) {
+  return dispatch => {
+    layer.getInFlightRequestTokens().forEach(requestToken => {
+      dispatch(cancelRequest(requestToken));
+    });
+    dispatch({
+      type: UPDATE_LAYER_PROP,
+      id: layer.getId(),
+      propName: '__dataRequests',
+      newValue: [],
     });
   };
 }
@@ -678,15 +690,7 @@ function updateLayerType(layerId, newLayerType) {
     if (!layer || layer.getType() === newLayerType) {
       return;
     }
-    layer.getInFlightRequestTokens().forEach(requestToken => {
-      dispatch(cancelRequest(requestToken));
-    });
-    dispatch({
-      type: UPDATE_LAYER_PROP,
-      id: layerId,
-      propName: '__dataRequests',
-      newValue: [],
-    });
+    dispatch(clearDataRequests(layer));
     dispatch({
       type: UPDATE_LAYER_PROP,
       id: layerId,