[Discover] Replace font-awesome data table filter in/out icons with E…

…UI (#79622)
elastic · Oct 7, 2020 · 603adab · 603adab
1 parent 019e2ad
commit 603adab
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/plugins/discover/public/application/angular/doc_table/components/table_row.ts b/src/plugins/discover/public/application/angular/doc_table/components/table_row.ts
@@ -109,7 +109,7 @@ export function createTableRowDirective($compile: ng.ICompileService) {
       });
 
       $scope.inlineFilter = function inlineFilter($event: any, type: string) {
-        const column = $($event.target).data().column;
+        const column = $($event.currentTarget).data().column;
         const field = $scope.indexPattern.fields.getByName(column);
         $scope.filter(field, $scope.flattenedRow[column], type);
       };

diff --git a/src/plugins/discover/public/application/angular/doc_table/components/table_row/cell.html b/src/plugins/discover/public/application/angular/doc_table/components/table_row/cell.html
@@ -14,24 +14,24 @@
     <% if (filterable) { %>
       <button
         ng-click="inlineFilter($event, '+')"
-        class="fa fa-search-plus kbnDocTableRowFilterButton"
+        class="kbnDocTableRowFilterButton"
         data-column="<%- column %>"
         tooltip-append-to-body="1"
         data-test-subj="docTableCellFilter"
         tooltip="{{ ::'discover.docTable.tableRow.filterForValueButtonTooltip' | i18n: {defaultMessage: 'Filter for value'} }}"
         tooltip-placement="bottom"
         aria-label="{{ ::'discover.docTable.tableRow.filterForValueButtonAriaLabel' | i18n: {defaultMessage: 'Filter for value'} }}"
-      ></button>
+      ><icon type="'plusInCircle'" size="'s'" color="'primary'"></icon></button>
       <button
         ng-click="inlineFilter($event, '-')"
-        class="fa fa-search-minus kbnDocTableRowFilterButton"
+        class="kbnDocTableRowFilterButton"
         data-column="<%- column %>"
         data-test-subj="docTableCellFilterNegate"
         tooltip="{{ ::'discover.docTable.tableRow.filterOutValueButtonTooltip' | i18n: {defaultMessage: 'Filter out value'} }}"
         aria-label="{{ ::'discover.docTable.tableRow.filterOutValueButtonAriaLabel' | i18n: {defaultMessage: 'Filter out value'} }}"
         tooltip-append-to-body="1"
         tooltip-placement="bottom"
-      ></button>
+      ><icon type="'minusInCircle'" size="'s'" color="'primary'"></icon></button>
     <% } %>
   </span>
 </td>