Adds perPage argument on pageSuplier function

elastic · Jun 27, 2023 · 5c9ef42 · 5c9ef42
1 parent 92b521b
commit 5c9ef42
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/...security_solution/server/endpoint/services/artifacts/manifest_manager/manifest_manager.ts b/...security_solution/server/endpoint/services/artifacts/manifest_manager/manifest_manager.ts
@@ -69,18 +69,19 @@ const iterateArtifactsBuildResult = (
 };
 
 const iterateAllListItems = async <T>(
-  pageSupplier: (page: number) => Promise<ListResult<T>>,
+  pageSupplier: (page: number, perPage: number) => Promise<ListResult<T>>,
   itemCallback: (items: T[]) => void
 ) => {
   let paging = true;
   let page = 1;
+  const perPage = 1000;
 
   while (paging) {
-    const { items, total } = await pageSupplier(page);
+    const { items, total } = await pageSupplier(page, perPage);
 
     itemCallback(items);
 
-    paging = (page - 1) * 1000 + items.length < total;
+    paging = (page - 1) * perPage + items.length < total;
     page++;
   }
 };
@@ -561,7 +562,7 @@ export class ManifestManager {
   public async tryDispatch(manifest: Manifest): Promise<Error[]> {
     const allPackagePolicies: PackagePolicy[] = [];
     await iterateAllListItems(
-      (page) => this.listEndpointPolicies(page),
+      (page, perPage) => this.listEndpointPolicies(page, perPage),
       (packagePoliciesBatch) => {
         allPackagePolicies.push(...packagePoliciesBatch);
       }
@@ -663,21 +664,21 @@ export class ManifestManager {
     this.logger.info(`Committed manifest ${manifest.getSemanticVersion()}`);
   }
 
-  private async listEndpointPolicies(page: number) {
+  private async listEndpointPolicies(page: number, perPage: number) {
     return this.packagePolicyService.list(this.savedObjectsClient, {
       page,
-      perPage: 1000,
+      perPage,
       kuery: 'ingest-package-policies.package.name:endpoint',
     });
   }
 
   private async listEndpointPolicyIds() {
     const allPolicyIds: string[] = [];
     await iterateAllListItems(
-      (page) => {
+      (page, perPage) => {
         return this.packagePolicyService.listIds(this.savedObjectsClient, {
           page,
-          perPage: 1000,
+          perPage,
           kuery: 'ingest-package-policies.package.name:endpoint',
         });
       },